From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
Date: Thu, 17 Sep 2015 17:44:38 +0100 [thread overview]
Message-ID: <55FAEDF6.6060000@arm.com> (raw)
In-Reply-To: <1442467166-1460-3-git-send-email-yangyingliang@huawei.com>
On 17/09/15 06:19, Yang Yingliang wrote:
> Add move_irqs() into kernel/irq/migration.c.
> So we can use it to migrate interrupts, when
> cpu is offline.
>
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> include/linux/irq.h | 4 +++
> kernel/irq/migration.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 70 insertions(+)
>
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index 6f8b340..64e3a02 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -446,6 +446,10 @@ static inline void irq_move_irq(struct irq_data *data) { }
> static inline void irq_move_masked_irq(struct irq_data *data) { }
> #endif
>
> +#if defined(CONFIG_SMP) && defined(CONFIG_GENERIC_IRQ_MIGRATION) && defined(CONFIG_HOTPLUG_CPU)
> +void move_irqs(void);
> +#endif
> +
I don't think having this prototype guarded by this #if is very useful.
You can probably leave it standalone.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Hanjun Guo <hanjun.guo@linaro.org>
Subject: Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
Date: Thu, 17 Sep 2015 17:44:38 +0100 [thread overview]
Message-ID: <55FAEDF6.6060000@arm.com> (raw)
In-Reply-To: <1442467166-1460-3-git-send-email-yangyingliang@huawei.com>
On 17/09/15 06:19, Yang Yingliang wrote:
> Add move_irqs() into kernel/irq/migration.c.
> So we can use it to migrate interrupts, when
> cpu is offline.
>
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> include/linux/irq.h | 4 +++
> kernel/irq/migration.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 70 insertions(+)
>
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index 6f8b340..64e3a02 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -446,6 +446,10 @@ static inline void irq_move_irq(struct irq_data *data) { }
> static inline void irq_move_masked_irq(struct irq_data *data) { }
> #endif
>
> +#if defined(CONFIG_SMP) && defined(CONFIG_GENERIC_IRQ_MIGRATION) && defined(CONFIG_HOTPLUG_CPU)
> +void move_irqs(void);
> +#endif
> +
I don't think having this prototype guarded by this #if is very useful.
You can probably leave it standalone.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-09-17 16:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 5:19 [RFC PATCH v4 0/4] arm/arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-17 5:19 ` Yang Yingliang
2015-09-17 5:19 ` [RFC PATCH v4 1/4] genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION Yang Yingliang
2015-09-17 5:19 ` Yang Yingliang
2015-09-17 5:19 ` [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Yang Yingliang
2015-09-17 5:19 ` Yang Yingliang
2015-09-17 16:44 ` Marc Zyngier [this message]
2015-09-17 16:44 ` Marc Zyngier
2015-09-17 22:04 ` Thomas Gleixner
2015-09-17 22:04 ` Thomas Gleixner
2015-09-17 22:09 ` Russell King - ARM Linux
2015-09-17 22:09 ` Russell King - ARM Linux
2015-09-18 1:13 ` Yang Yingliang
2015-09-18 1:13 ` Yang Yingliang
2015-09-17 5:19 ` [RFC PATCH v4 3/4] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-17 5:19 ` Yang Yingliang
2015-09-17 16:01 ` Will Deacon
2015-09-17 16:01 ` Will Deacon
2015-09-17 5:19 ` [RFC PATCH v4 4/4] arm: " Yang Yingliang
2015-09-17 5:19 ` Yang Yingliang
2015-09-17 22:10 ` [RFC PATCH v4 0/4] arm/arm64: " Thomas Gleixner
2015-09-17 22:10 ` Thomas Gleixner
2015-09-18 1:14 ` Yang Yingliang
2015-09-18 1:14 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAEDF6.6060000@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.