All of lore.kernel.org
 help / color / mirror / Atom feed
From: yangyingliang@huawei.com (Yang Yingliang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
Date: Fri, 18 Sep 2015 09:13:01 +0800	[thread overview]
Message-ID: <55FB651D.5080101@huawei.com> (raw)
In-Reply-To: <20150917220944.GX21084@n2100.arm.linux.org.uk>



On 2015/9/18 6:09, Russell King - ARM Linux wrote:
> On Fri, Sep 18, 2015 at 12:04:06AM +0200, Thomas Gleixner wrote:
>> On Thu, 17 Sep 2015, Marc Zyngier wrote:
>>> I don't think having this prototype guarded by this #if is very useful.
>>> You can probably leave it standalone.
>>
>> Yes, there is no point if the function name is unique. Though
>> move_irqs() is rather undescriptive. irq_break_affinities() might
>> describe it quite well, but feel free to come up with soemthing better.
>
> I don't think "irq_break_affinities" is anywhere near a good name - it's
> not about always breaking affinities (moving an IRQ off one CPU onto
> another within the current affinity setting does not break the affinity.)
>
> irq_migrate_all()
>
> irq_migrate_all_off_this_cpu()
>
> irq_this_cpu_hotunplug()
>
> irq_cpu_hotunplug()
>

irq_migrate_all_off_this_cpu() describe it well, I will choose it.

Thanks,
Yang

WARNING: multiple messages have this Message-ID (diff)
From: Yang Yingliang <yangyingliang@huawei.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Will Deacon <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>,
	Hanjun Guo <hanjun.guo@linaro.org>,
	Jiang Liu <jiang.liu@linux.intel.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
Date: Fri, 18 Sep 2015 09:13:01 +0800	[thread overview]
Message-ID: <55FB651D.5080101@huawei.com> (raw)
In-Reply-To: <20150917220944.GX21084@n2100.arm.linux.org.uk>



On 2015/9/18 6:09, Russell King - ARM Linux wrote:
> On Fri, Sep 18, 2015 at 12:04:06AM +0200, Thomas Gleixner wrote:
>> On Thu, 17 Sep 2015, Marc Zyngier wrote:
>>> I don't think having this prototype guarded by this #if is very useful.
>>> You can probably leave it standalone.
>>
>> Yes, there is no point if the function name is unique. Though
>> move_irqs() is rather undescriptive. irq_break_affinities() might
>> describe it quite well, but feel free to come up with soemthing better.
>
> I don't think "irq_break_affinities" is anywhere near a good name - it's
> not about always breaking affinities (moving an IRQ off one CPU onto
> another within the current affinity setting does not break the affinity.)
>
> irq_migrate_all()
>
> irq_migrate_all_off_this_cpu()
>
> irq_this_cpu_hotunplug()
>
> irq_cpu_hotunplug()
>

irq_migrate_all_off_this_cpu() describe it well, I will choose it.

Thanks,
Yang


  reply	other threads:[~2015-09-18  1:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  5:19 [RFC PATCH v4 0/4] arm/arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-17  5:19 ` Yang Yingliang
2015-09-17  5:19 ` [RFC PATCH v4 1/4] genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17  5:19 ` [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17 16:44   ` Marc Zyngier
2015-09-17 16:44     ` Marc Zyngier
2015-09-17 22:04     ` Thomas Gleixner
2015-09-17 22:04       ` Thomas Gleixner
2015-09-17 22:09       ` Russell King - ARM Linux
2015-09-17 22:09         ` Russell King - ARM Linux
2015-09-18  1:13         ` Yang Yingliang [this message]
2015-09-18  1:13           ` Yang Yingliang
2015-09-17  5:19 ` [RFC PATCH v4 3/4] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17 16:01   ` Will Deacon
2015-09-17 16:01     ` Will Deacon
2015-09-17  5:19 ` [RFC PATCH v4 4/4] arm: " Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17 22:10 ` [RFC PATCH v4 0/4] arm/arm64: " Thomas Gleixner
2015-09-17 22:10   ` Thomas Gleixner
2015-09-18  1:14   ` Yang Yingliang
2015-09-18  1:14     ` Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FB651D.5080101@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.