* [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info
@ 2015-10-09 7:30 Shivani Bhardwaj
2015-10-09 7:44 ` [Outreachy kernel] " Sudip Mukherjee
0 siblings, 1 reply; 4+ messages in thread
From: Shivani Bhardwaj @ 2015-10-09 7:30 UTC (permalink / raw)
To: outreachy-kernel
Replaced the function printk() with dev_info() to fix the warning
generated by checkpatch : printk() should include KERN_ facility level.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
Changes in v2:
- Replaced the function pr_info() with dev_info()
drivers/staging/sm750fb/ddk750_help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..d20cd92 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId == 0xfe)
- printk("found sm750le\n");
+ dev_info("found sm750le\n");
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info
2015-10-09 7:30 [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info Shivani Bhardwaj
@ 2015-10-09 7:44 ` Sudip Mukherjee
2015-10-09 13:59 ` Shivani Bhardwaj
0 siblings, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2015-10-09 7:44 UTC (permalink / raw)
To: Shivani Bhardwaj; +Cc: outreachy-kernel
On Fri, Oct 09, 2015 at 01:00:10PM +0530, Shivani Bhardwaj wrote:
> Replaced the function printk() with dev_info() to fix the warning
> generated by checkpatch : printk() should include KERN_ facility level.
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> Changes in v2:
> - Replaced the function pr_info() with dev_info()
>
> drivers/staging/sm750fb/ddk750_help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..d20cd92 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> devId750 = devId;
> revId750 = revId;
> if (revId == 0xfe)
> - printk("found sm750le\n");
> + dev_info("found sm750le\n");
Did you try to compile it?
regards
sudip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info
2015-10-09 7:44 ` [Outreachy kernel] " Sudip Mukherjee
@ 2015-10-09 13:59 ` Shivani Bhardwaj
0 siblings, 0 replies; 4+ messages in thread
From: Shivani Bhardwaj @ 2015-10-09 13:59 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: outreachy-kernel
On Fri, Oct 9, 2015 at 1:14 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Fri, Oct 09, 2015 at 01:00:10PM +0530, Shivani Bhardwaj wrote:
>> Replaced the function printk() with dev_info() to fix the warning
>> generated by checkpatch : printk() should include KERN_ facility level.
>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>> Changes in v2:
>> - Replaced the function pr_info() with dev_info()
>>
>> drivers/staging/sm750fb/ddk750_help.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
>> index 9637dd3..d20cd92 100644
>> --- a/drivers/staging/sm750fb/ddk750_help.c
>> +++ b/drivers/staging/sm750fb/ddk750_help.c
>> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
>> devId750 = devId;
>> revId750 = revId;
>> if (revId == 0xfe)
>> - printk("found sm750le\n");
>> + dev_info("found sm750le\n");
>
> Did you try to compile it?
>
> regards
> sudip
No, I just checked it against checkpatch, I found out that I have used
the function in wrong way and I am working on fixing that.
Thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info
@ 2015-10-09 14:21 Shivani Bhardwaj
0 siblings, 0 replies; 4+ messages in thread
From: Shivani Bhardwaj @ 2015-10-09 14:21 UTC (permalink / raw)
To: outreachy-kernel
Replaced the function printk() with dev_info() to fix the warning
generated by checkpatch : printk() should include KERN_ facility level.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
Changes in v2:
-Replaced the function pr_info() with dev_info()
drivers/staging/sm750fb/ddk750_help.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..b877704 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -1,5 +1,7 @@
#include "ddk750_help.h"
+#include <linux/pci.h>
+static struct pci_dev *pdev;
void __iomem *mmio750;
char revId750;
unsigned short devId750;
@@ -11,7 +13,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId == 0xfe)
- printk("found sm750le\n");
+ dev_info(&pdev->dev, "found sm750le\n");
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-09 14:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-09 7:30 [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info Shivani Bhardwaj
2015-10-09 7:44 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-09 13:59 ` Shivani Bhardwaj
-- strict thread matches above, loose matches on Subject: below --
2015-10-09 14:21 Shivani Bhardwaj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.