Re: [Outreachy kernel] [PATCH 4/5] staging: r8723au: move constant to right of comparison test

[Alison Schofield <amsfield22@gmail.com>]

On Mon, Oct 19, 2015 at 10:06:21PM +0200, Julia Lawall wrote:
> On Mon, 19 Oct 2015, Alison Schofield wrote:
> 
> > Move constant to right of comparison test to improve readability.
> 
> Was it intentional to also move it below the comment?
> 
> julia
> 

This was not intentional and I don't see it as moved in my 'working'
file. It has raised a big red flag that the process I used to create
this patchset is wrong.  I'm going to retrace my steps, but if you have
a quick thought on where I screwed up...I'd appreciate it :)
- edited single final with all 5 types of changes.
- used git add -pi to add each hunk and commited each..one at a time
I thought the results would be 5 independent patches, but now I don't
think so!

Thanks for any pointers!

alison



> > 
> > checkpatch.pl:
> > 	WARNING: Comparisons should place the constant on the
> > 	right side of the test
> > 
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > ---
> >  drivers/staging/rtl8723au/core/rtw_cmd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c
> > index 33164d3..6034428 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
> > @@ -637,13 +637,13 @@ int rtw_disassoc_cmd23a(struct rtw_adapter *padapter, u32 deauth_timeout_ms,
> >  		init_h2fwcmd_w_parm_no_rsp(cmdobj, param, _DisConnect_CMD_);
> >  		res = rtw_enqueue_cmd23a(cmdpriv, cmdobj);
> >  	} else {
> > -		if (H2C_SUCCESS != disconnect_hdl23a(padapter, (u8 *)param))
> >  
> >  		/*
> >  		 * no need to enqueue, do the cmd hdl
> >  		 * directly and free cmd parameter
> >  		 */
> >  
> > +		if (disconnect_hdl23a(padapter, (u8 *)param) != H2C_SUCCESS)
> >  			res = _FAIL;
> >  		kfree(param);
> >  	}
> > -- 
> > 2.1.4
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/65c30e146c9e0fe672a78d4cc51ba07dfd9f4f6d.1445282918.git.amsfield22%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >