Re: [Outreachy kernel] [PATCH 2/5] staging: r8723au: replace printk() with pr_err()

[Alison Schofield <amsfield22@gmail.com>]

On Mon, Oct 19, 2015 at 10:09:46PM +0200, Julia Lawall wrote:
> On Mon, 19 Oct 2015, Alison Schofield wrote:
> 
> > Replace printk() with pr_err() for uniform error reporting.
> > Issue found by checkpatch.
> > 
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > ---
> >  drivers/staging/rtl8723au/core/rtw_cmd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c
> > index c3579ac..7bf0f30 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
> > @@ -248,7 +248,7 @@ int rtw_enqueue_cmd23a(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
> >  	res = queue_work(pcmdpriv->wq, &cmd_obj->work);
> >  
> >  	if (!res) {
> > -		printk(KERN_ERR "%s: Call to queue_work() failed\n", __func__);
> > +		pr_err("%s: Call to queue_work() failed\n", __func__);
> 
> There is no device tructure or network device structure available?
> 
> julia
>
Yes there is a netdev. Used in v2.  Thanks!

> >  		res = _FAIL;
> >  	} else
> >  		res = _SUCCESS;
> > -- 
> > 2.1.4
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/beee0bc7850917329b2b0ad3d3e0584f5cbbcdba.1445282918.git.amsfield22%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >