Re: [Outreachy kernel] [PATCH v2 5/5] staging: r8723au: use kernel preferred style for commenting

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Oct 25, 2015 at 08:12:44PM -0700, Alison Schofield wrote:
> On Sat, Oct 24, 2015 at 07:41:21PM -0700, Greg KH wrote:
> > On Tue, Oct 20, 2015 at 11:10:41PM -0700, Alison Schofield wrote:
> > > Reworked comments per kernel coding style to improve readability.
> > > 
> > > Addresses checkpatch.pl:
> > > 	WARNING: Block comments use * on subsequent lines
> > > 
> > > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > > ---
> > >  drivers/staging/rtl8723au/core/rtw_cmd.c | 159 ++++++++++++++++---------------
> > >  1 file changed, 80 insertions(+), 79 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c
> > > index 6330933..4db4dfe 100644
> > > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c
> > > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
> > > @@ -102,83 +102,76 @@ static struct cmd_hdl wlancmds[] = {
> > >  			     tdls_hdl23a)
> > >  };
> > >  
> > > -struct _cmd_callback	rtw_cmd_callback[] = {
> > > -	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
> > > +struct _cmd_callback rtw_cmd_callback[] = {
> > > +	{GEN_CMD_CODE(_Read_MACREG), NULL},				/*0*/
> > >  	{GEN_CMD_CODE(_Write_MACREG), NULL},
> > >  	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback23a},
> > >  	{GEN_CMD_CODE(_Write_BBREG), NULL},
> > >  	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback23a},
> > > -	{GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
> > > +	{GEN_CMD_CODE(_Write_RFREG), NULL},
> > >  	{GEN_CMD_CODE(_Read_EEPROM), NULL},
> > >  	{GEN_CMD_CODE(_Write_EEPROM), NULL},
> > >  	{GEN_CMD_CODE(_Read_EFUSE), NULL},
> > >  	{GEN_CMD_CODE(_Write_EFUSE), NULL},
> > > -
> > > -	{GEN_CMD_CODE(_Read_CAM),	NULL},	/*10*/
> > > -	{GEN_CMD_CODE(_Write_CAM),	 NULL},
> > > +	{GEN_CMD_CODE(_Read_CAM), NULL},				/*10*/
> > > +	{GEN_CMD_CODE(_Write_CAM), NULL},
> > >  	{GEN_CMD_CODE(_setBCNITV), NULL},
> > >  	{GEN_CMD_CODE(_setMBIDCFG), NULL},
> > > -	{GEN_CMD_CODE(_JoinBss), &rtw_joinbss_cmd23a_callback},  /*14*/
> > > -	{GEN_CMD_CODE(_DisConnect), &rtw_disassoc_cmd23a_callback}, /*15*/
> > > +	{GEN_CMD_CODE(_JoinBss), &rtw_joinbss_cmd23a_callback},
> > > +	{GEN_CMD_CODE(_DisConnect), &rtw_disassoc_cmd23a_callback},
> > 
> > Why delete the comments?
> >
> The comments note the place in the list. I didn't delete them entirely,
> but replaced them with a marker every 10 items.  This was the second of
> these two lists and I tried to give them the same look n feel.  

But maybe items 14 and 15 were "special" and wanted to be found easier,
you don't know :)

Just leave them there please.

thanks,

greg k-h