All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <amsfield22@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH v2 0/5] staging: r8723au: fix multiple checkpatch issues
Date: Tue, 20 Oct 2015 22:57:27 -0700	[thread overview]
Message-ID: <cover.1445402009.git.amsfield22@gmail.com> (raw)
In-Reply-To: <cover.1445282918.git.amsfield22@gmail.com>


This patchset addresses the last 26 checkpatch WARNINGs in file:
drivers/staging/rtl8723au/core/rtw_cmd.c

I'll call your attention to the "Line over 80 chars" cases:

I chose to address 'Line over 80 chars' because all but one could be
resolved by cleaning up a single struct definition. [PATCH 1/5]

The last one appeared to be due to excessively long function names
as opposed to deep indentation/complex code requiring refactoring.
See my notes below the --- in PATCH[4/5] for further info.

alison

Changes in v2:

The patches have been reordered.  
	The comment corrections are now the last patch in the series.

[1/5] no changes
[2/5] now using netdev_err per reviewer feedback
[3/5] no change in code, but the diff changed when I moved the comment patch.
[4/5] no change in code, but same as above, diff appears a bit 'different.'
[5/5] scanned and corrected comments thru entire file, not just those
	reported by checkpatch (ie. spacing issues)




Alison Schofield (5):
  staging: r8723au: break parameter list at separators and align to open
        braces
  staging: r8723au: replace printk() with netdev_err()
  staging: r8723au: move constant to right of comparison test
  staging: r8723au: add & use local variable to simplify references
  staging: r8723au: use kernel preferred style for commenting

 drivers/staging/rtl8723au/core/rtw_cmd.c | 239 ++++++++++++++++---------------
 1 file changed, 127 insertions(+), 112 deletions(-)

-- 
2.1.4



  parent reply	other threads:[~2015-10-21  5:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 19:57 [PATCH 0/5] staging: r8723au: fix multiple checkpatch issues Alison Schofield
2015-10-19 19:58 ` [PATCH 1/5] staging: r8723au: break parameter list at separators and align to open braces Alison Schofield
2015-10-19 19:59 ` [PATCH 2/5] staging: r8723au: replace printk() with pr_err() Alison Schofield
2015-10-19 20:09   ` [Outreachy kernel] " Julia Lawall
2015-10-21  5:51     ` Alison Schofield
2015-10-19 20:00 ` [PATCH 3/5] staging: r8723au: use kernel preferred style for block comments Alison Schofield
2015-10-19 20:07   ` [Outreachy kernel] " Julia Lawall
2015-10-20  2:29     ` Alison Schofield
2015-10-20  5:08       ` Julia Lawall
2015-10-19 20:02 ` [PATCH 4/5] staging: r8723au: move constant to right of comparison test Alison Schofield
2015-10-19 20:06   ` [Outreachy kernel] " Julia Lawall
2015-10-19 20:45     ` Alison Schofield
     [not found]     ` <20151019203548.GA23803@Ubuntu-D830>
     [not found]       ` <alpine.DEB.2.02.1510192241110.2034@localhost6.localdomain6>
2015-10-20  2:34         ` Alison Schofield
2015-10-19 20:11 ` [PATCH 5/5] staging: r8723au: add & use local variable to simplify references Alison Schofield
2015-10-21  5:57 ` Alison Schofield [this message]
2015-10-21  6:01   ` [PATCH v2 1/5] staging: r8723au: break parameter list at separators and align to open braces Alison Schofield
2015-10-25  2:40     ` [Outreachy kernel] " Greg KH
2015-10-26  3:07       ` Alison Schofield
2015-10-27  5:44         ` Greg KH
2015-11-08 21:58           ` Jes Sorensen
2015-10-21  6:06   ` [PATCH v2 2/5] staging: r8723au: replace printk() with netdev_err() Alison Schofield
2015-10-21  6:08   ` [PATCH v2 3/5] staging: r8723au: move constant to right of comparison test Alison Schofield
2015-10-21  6:09   ` [PATCH v2 4/5] staging: r8723au: add & use local variable to simplify references Alison Schofield
2015-10-21  6:10   ` [PATCH v2 5/5] staging: r8723au: use kernel preferred style for commenting Alison Schofield
2015-10-25  2:41     ` [Outreachy kernel] " Greg KH
2015-10-26  3:12       ` Alison Schofield
2015-10-27  5:45         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1445402009.git.amsfield22@gmail.com \
    --to=amsfield22@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.