From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: lee.jones@linaro.org, broonie@kernel.org,
k.kozlowski@samsung.com, mturquette@baylibre.com,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Tue, 27 Oct 2015 23:59:34 +0100 [thread overview]
Message-ID: <20151027225934.GL22331@piout.net> (raw)
In-Reply-To: <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com>
On 26/10/2015 at 18:21:22 +0530, Alim Akhtar wrote :
> RTC found in s2mps15 is almost same as one found in s2mps14.
> This patch add required changes to enable s2mps15 rtc timer.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
One really small nitpick below else you can add my
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/rtc-s5m.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> @@ -317,7 +319,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm)
> u8 data[info->regs->regs_count];
> int ret;
>
> - if (info->device_type == S2MPS14X || info->device_type == S2MPS13X) {
> + if (info->device_type == S2MPS14X || info->device_type == S2MPS15X ||
> + info->device_type == S2MPS13X) {
This line is not properly aligned.
> ret = regmap_update_bits(info->regmap,
> info->regs->rtc_udr_update,
> S2MPS_RTC_RUDR_MASK, S2MPS_RTC_RUDR_MASK);
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: lee.jones@linaro.org, broonie@kernel.org,
k.kozlowski@samsung.com, mturquette@baylibre.com,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Tue, 27 Oct 2015 23:59:34 +0100 [thread overview]
Message-ID: <20151027225934.GL22331@piout.net> (raw)
In-Reply-To: <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com>
On 26/10/2015 at 18:21:22 +0530, Alim Akhtar wrote :
> RTC found in s2mps15 is almost same as one found in s2mps14.
> This patch add required changes to enable s2mps15 rtc timer.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
One really small nitpick below else you can add my
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/rtc-s5m.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> @@ -317,7 +319,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm)
> u8 data[info->regs->regs_count];
> int ret;
>
> - if (info->device_type == S2MPS14X || info->device_type == S2MPS13X) {
> + if (info->device_type == S2MPS14X || info->device_type == S2MPS15X ||
> + info->device_type == S2MPS13X) {
This line is not properly aligned.
> ret = regmap_update_bits(info->regmap,
> info->regs->rtc_udr_update,
> S2MPS_RTC_RUDR_MASK, S2MPS_RTC_RUDR_MASK);
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-10-27 22:59 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 12:51 [PATCH v3 0/5] mfd: sec: add S2MPS15 PMIC support Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 1/5] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 14:34 ` Lee Jones
2015-10-26 14:34 ` [rtc-linux] " Lee Jones
2015-10-28 1:15 ` Krzysztof Kozlowski
2015-10-28 1:15 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 8:46 ` Lee Jones
2015-10-28 8:46 ` [rtc-linux] " Lee Jones
2015-10-28 11:21 ` Alim Akhtar
2015-10-28 11:21 ` [rtc-linux] " Alim Akhtar
2015-10-28 13:47 ` Krzysztof Kozlowski
2015-10-28 13:47 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 13:44 ` Krzysztof Kozlowski
2015-10-28 13:44 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 13:51 ` Lee Jones
2015-10-28 13:51 ` [rtc-linux] " Lee Jones
2015-10-29 4:19 ` Alim Akhtar
2015-10-29 4:19 ` [rtc-linux] " Alim Akhtar
2015-10-28 1:28 ` Krzysztof Kozlowski
2015-10-28 1:28 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-26 12:51 ` [PATCH v3 3/5] regulator: s2mps11: add support for S2MPS15 regulators Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-28 1:22 ` Krzysztof Kozlowski
2015-10-28 1:22 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 3:36 ` Alim Akhtar
2015-10-28 3:36 ` [rtc-linux] " Alim Akhtar
2015-10-28 1:26 ` Krzysztof Kozlowski
2015-10-28 1:26 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 4:34 ` Krzysztof Kozlowski
2015-10-28 4:34 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 4:55 ` Alim Akhtar
2015-10-28 4:55 ` [rtc-linux] " Alim Akhtar
2015-10-28 5:36 ` Krzysztof Kozlowski
2015-10-28 5:36 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-26 12:51 ` [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-27 22:59 ` Alexandre Belloni [this message]
2015-10-27 22:59 ` Alexandre Belloni
2015-10-28 1:29 ` Krzysztof Kozlowski
2015-10-28 1:29 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 1:53 ` Mark Brown
2015-10-28 1:53 ` [rtc-linux] " Mark Brown
2015-10-28 2:17 ` Krzysztof Kozlowski
2015-10-28 2:17 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 3:14 ` Alim Akhtar
2015-10-28 3:14 ` [rtc-linux] " Alim Akhtar
2015-10-28 3:31 ` Krzysztof Kozlowski
2015-10-28 3:31 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 3:33 ` Alim Akhtar
2015-10-28 3:33 ` [rtc-linux] " Alim Akhtar
2015-10-28 9:48 ` Alexandre Belloni
2015-10-28 9:48 ` Alexandre Belloni
2015-10-28 10:30 ` Alim Akhtar
2015-10-28 10:30 ` Alim Akhtar
2015-10-28 13:35 ` Krzysztof Kozlowski
2015-10-28 13:35 ` Krzysztof Kozlowski
2015-10-28 13:31 ` Krzysztof Kozlowski
2015-10-28 13:31 ` Krzysztof Kozlowski
2015-10-28 13:43 ` Alexandre Belloni
2015-10-28 13:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027225934.GL22331@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.