From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
lee.jones@linaro.org, mturquette@baylibre.com,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Wed, 28 Oct 2015 11:17:56 +0900 [thread overview]
Message-ID: <56303054.8060804@samsung.com> (raw)
In-Reply-To: <20151028015323.GZ28319@sirena.org.uk>
On 28.10.2015 10:53, Mark Brown wrote:
> On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote:
>
>> If that's true, then don't add new compatibles, new names etc. Re-use.
>> No new code needed, no changes needed. Keep it simple.
>
> Well, it depends - it can be useful to get the information about it
> being a different part into DT so that if in future we realise that
> there is some difference (perhaps a bug workaround even if the IP is
> intended to be the same). Though in the case of a MFD that information
> can be obtained from the MFD for the device.
We can always differentiate later and introduce new compatible.
Declaring a compatible right now would be useful only if we really cared
about using the workaround on older DTBs.
Since I cannot judge the difference (I don't have the datasheet of
S2MPS15) then I don't see the need of adding new compatible/name for the
"same device".
Of course maybe there is such need? Alim?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
lee.jones@linaro.org, mturquette@baylibre.com,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Wed, 28 Oct 2015 11:17:56 +0900 [thread overview]
Message-ID: <56303054.8060804@samsung.com> (raw)
In-Reply-To: <20151028015323.GZ28319@sirena.org.uk>
On 28.10.2015 10:53, Mark Brown wrote:
> On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote:
>
>> If that's true, then don't add new compatibles, new names etc. Re-use.
>> No new code needed, no changes needed. Keep it simple.
>
> Well, it depends - it can be useful to get the information about it
> being a different part into DT so that if in future we realise that
> there is some difference (perhaps a bug workaround even if the IP is
> intended to be the same). Though in the case of a MFD that information
> can be obtained from the MFD for the device.
We can always differentiate later and introduce new compatible.
Declaring a compatible right now would be useful only if we really cared
about using the workaround on older DTBs.
Since I cannot judge the difference (I don't have the datasheet of
S2MPS15) then I don't see the need of adding new compatible/name for the
"same device".
Of course maybe there is such need? Alim?
Best regards,
Krzysztof
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-10-28 2:17 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 12:51 [PATCH v3 0/5] mfd: sec: add S2MPS15 PMIC support Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 1/5] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 14:34 ` Lee Jones
2015-10-26 14:34 ` [rtc-linux] " Lee Jones
2015-10-28 1:15 ` Krzysztof Kozlowski
2015-10-28 1:15 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 8:46 ` Lee Jones
2015-10-28 8:46 ` [rtc-linux] " Lee Jones
2015-10-28 11:21 ` Alim Akhtar
2015-10-28 11:21 ` [rtc-linux] " Alim Akhtar
2015-10-28 13:47 ` Krzysztof Kozlowski
2015-10-28 13:47 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 13:44 ` Krzysztof Kozlowski
2015-10-28 13:44 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 13:51 ` Lee Jones
2015-10-28 13:51 ` [rtc-linux] " Lee Jones
2015-10-29 4:19 ` Alim Akhtar
2015-10-29 4:19 ` [rtc-linux] " Alim Akhtar
2015-10-28 1:28 ` Krzysztof Kozlowski
2015-10-28 1:28 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-26 12:51 ` [PATCH v3 3/5] regulator: s2mps11: add support for S2MPS15 regulators Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-28 1:22 ` Krzysztof Kozlowski
2015-10-28 1:22 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 3:36 ` Alim Akhtar
2015-10-28 3:36 ` [rtc-linux] " Alim Akhtar
2015-10-28 1:26 ` Krzysztof Kozlowski
2015-10-28 1:26 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 4:34 ` Krzysztof Kozlowski
2015-10-28 4:34 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 4:55 ` Alim Akhtar
2015-10-28 4:55 ` [rtc-linux] " Alim Akhtar
2015-10-28 5:36 ` Krzysztof Kozlowski
2015-10-28 5:36 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-26 12:51 ` [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC Alim Akhtar
2015-10-26 12:51 ` [rtc-linux] " Alim Akhtar
2015-10-27 22:59 ` Alexandre Belloni
2015-10-27 22:59 ` Alexandre Belloni
2015-10-28 1:29 ` Krzysztof Kozlowski
2015-10-28 1:29 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 1:53 ` Mark Brown
2015-10-28 1:53 ` [rtc-linux] " Mark Brown
2015-10-28 2:17 ` Krzysztof Kozlowski [this message]
2015-10-28 2:17 ` Krzysztof Kozlowski
2015-10-28 3:14 ` Alim Akhtar
2015-10-28 3:14 ` [rtc-linux] " Alim Akhtar
2015-10-28 3:31 ` Krzysztof Kozlowski
2015-10-28 3:31 ` [rtc-linux] " Krzysztof Kozlowski
2015-10-28 3:33 ` Alim Akhtar
2015-10-28 3:33 ` [rtc-linux] " Alim Akhtar
2015-10-28 9:48 ` Alexandre Belloni
2015-10-28 9:48 ` Alexandre Belloni
2015-10-28 10:30 ` Alim Akhtar
2015-10-28 10:30 ` Alim Akhtar
2015-10-28 13:35 ` Krzysztof Kozlowski
2015-10-28 13:35 ` Krzysztof Kozlowski
2015-10-28 13:31 ` Krzysztof Kozlowski
2015-10-28 13:31 ` Krzysztof Kozlowski
2015-10-28 13:43 ` Alexandre Belloni
2015-10-28 13:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56303054.8060804@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.