From: Borislav Petkov <bp@alien8.de>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tony Luck <tony.luck@intel.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects()
Date: Thu, 3 Dec 2015 19:40:51 +0100 [thread overview]
Message-ID: <20151203184051.GE3213@pd.tnic> (raw)
In-Reply-To: <1449168859.9855.54.camel@hpe.com>
On Thu, Dec 03, 2015 at 11:54:19AM -0700, Toshi Kani wrote:
> Adding a new type for regular memory will require inspecting the codes
> using IORESOURCE_MEM currently, and modify them to use the new type if
> their target ranges are regular memory. There are many references to this
> type across multiple architectures and drivers, which make this inspection
> and testing challenging.
What's wrong with adding a new type_flags to struct resource and not
touching IORESOURCE_* at all?
They'll be called something like RES_TYPE_RAM, _PMEM, _SYSMEM...
Or would that confuse more...?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tony Luck <tony.luck@intel.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects()
Date: Thu, 3 Dec 2015 19:40:51 +0100 [thread overview]
Message-ID: <20151203184051.GE3213@pd.tnic> (raw)
In-Reply-To: <1449168859.9855.54.camel@hpe.com>
On Thu, Dec 03, 2015 at 11:54:19AM -0700, Toshi Kani wrote:
> Adding a new type for regular memory will require inspecting the codes
> using IORESOURCE_MEM currently, and modify them to use the new type if
> their target ranges are regular memory. There are many references to this
> type across multiple architectures and drivers, which make this inspection
> and testing challenging.
What's wrong with adding a new type_flags to struct resource and not
touching IORESOURCE_* at all?
They'll be called something like RES_TYPE_RAM, _PMEM, _SYSMEM...
Or would that confuse more...?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-12-03 18:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 22:33 [PATCH v3 0/3] Allow EINJ to inject memory error to NVDIMM Toshi Kani
2015-11-24 22:33 ` Toshi Kani
2015-11-24 22:33 ` [PATCH v3 1/3] resource: Add @flags to region_intersects() Toshi Kani
2015-11-24 22:33 ` Toshi Kani
2015-12-01 13:50 ` Borislav Petkov
2015-12-01 13:50 ` Borislav Petkov
2015-12-01 16:54 ` Dan Williams
2015-12-01 16:54 ` Dan Williams
2015-12-01 16:54 ` Dan Williams
2015-12-01 17:02 ` Jeff Moyer
2015-12-01 17:02 ` Jeff Moyer
2015-12-01 17:02 ` Jeff Moyer
2015-12-01 17:13 ` Borislav Petkov
2015-12-01 17:13 ` Borislav Petkov
2015-12-01 17:19 ` Linus Torvalds
2015-12-01 17:19 ` Linus Torvalds
2015-12-01 17:19 ` Linus Torvalds
2015-12-03 18:54 ` Toshi Kani
2015-12-03 18:54 ` Toshi Kani
2015-12-03 18:40 ` Borislav Petkov [this message]
2015-12-03 18:40 ` Borislav Petkov
2015-12-03 19:01 ` Linus Torvalds
2015-12-03 19:01 ` Linus Torvalds
2015-12-03 19:01 ` Linus Torvalds
2015-12-03 20:35 ` Toshi Kani
2015-12-03 20:35 ` Toshi Kani
2015-12-09 16:25 ` Dan Williams
2015-12-09 16:25 ` Dan Williams
2015-12-09 16:25 ` Dan Williams
2015-12-09 21:44 ` Toshi Kani
2015-12-09 21:44 ` Toshi Kani
2015-11-24 22:33 ` [PATCH v3 2/3] resource: Add region_intersects_pmem() Toshi Kani
2015-11-24 22:33 ` Toshi Kani
2015-11-24 22:33 ` [PATCH v3 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani
2015-11-24 22:33 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203184051.GE3213@pd.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hpe.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.