From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects()
Date: Tue, 01 Dec 2015 12:02:26 -0500 [thread overview]
Message-ID: <x49y4dekspp.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <CAPcyv4g2n9yTWye2aVvKMP0X7mrm_NLKmGd5WBO2SesTj77gbg@mail.gmail.com> (Dan Williams's message of "Tue, 1 Dec 2015 08:54:23 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
>>> @@ -57,7 +57,7 @@ static void *try_ram_remap(resource_size_t offset, size_t size)
>>> */
>>> void *memremap(resource_size_t offset, size_t size, unsigned long flags)
>>> {
>>> - int is_ram = region_intersects(offset, size, "System RAM");
>>
>> Ok, question: why do those resource things types gets identified with
>> a string?! We have here "System RAM" and next patch adds "Persistent
>> Memory".
>>
>> And "persistent memory" or "System RaM" won't work and this is just
>> silly.
>>
>> Couldn't struct resource have gained some typedef flags instead which we
>> can much easily test? Using the strings looks really yucky.
>>
>
> At least in the case of region_intersects() I was just following
> existing strcmp() convention from walk_system_ram_range.
...which is done in the page fault path. I agree with the suggestion to
get strcmp out of that path.
-Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects()
Date: Tue, 01 Dec 2015 12:02:26 -0500 [thread overview]
Message-ID: <x49y4dekspp.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <CAPcyv4g2n9yTWye2aVvKMP0X7mrm_NLKmGd5WBO2SesTj77gbg@mail.gmail.com> (Dan Williams's message of "Tue, 1 Dec 2015 08:54:23 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
>>> @@ -57,7 +57,7 @@ static void *try_ram_remap(resource_size_t offset, size_t size)
>>> */
>>> void *memremap(resource_size_t offset, size_t size, unsigned long flags)
>>> {
>>> - int is_ram = region_intersects(offset, size, "System RAM");
>>
>> Ok, question: why do those resource things types gets identified with
>> a string?! We have here "System RAM" and next patch adds "Persistent
>> Memory".
>>
>> And "persistent memory" or "System RaM" won't work and this is just
>> silly.
>>
>> Couldn't struct resource have gained some typedef flags instead which we
>> can much easily test? Using the strings looks really yucky.
>>
>
> At least in the case of region_intersects() I was just following
> existing strcmp() convention from walk_system_ram_range.
...which is done in the page fault path. I agree with the suggestion to
get strcmp out of that path.
-Jeff
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-nvdimm\@lists.01.org" <linux-nvdimm@ml01.01.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects()
Date: Tue, 01 Dec 2015 12:02:26 -0500 [thread overview]
Message-ID: <x49y4dekspp.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <CAPcyv4g2n9yTWye2aVvKMP0X7mrm_NLKmGd5WBO2SesTj77gbg@mail.gmail.com> (Dan Williams's message of "Tue, 1 Dec 2015 08:54:23 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
>>> @@ -57,7 +57,7 @@ static void *try_ram_remap(resource_size_t offset, size_t size)
>>> */
>>> void *memremap(resource_size_t offset, size_t size, unsigned long flags)
>>> {
>>> - int is_ram = region_intersects(offset, size, "System RAM");
>>
>> Ok, question: why do those resource things types gets identified with
>> a string?! We have here "System RAM" and next patch adds "Persistent
>> Memory".
>>
>> And "persistent memory" or "System RaM" won't work and this is just
>> silly.
>>
>> Couldn't struct resource have gained some typedef flags instead which we
>> can much easily test? Using the strings looks really yucky.
>>
>
> At least in the case of region_intersects() I was just following
> existing strcmp() convention from walk_system_ram_range.
...which is done in the page fault path. I agree with the suggestion to
get strcmp out of that path.
-Jeff
next prev parent reply other threads:[~2015-12-01 17:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 22:33 [PATCH v3 0/3] Allow EINJ to inject memory error to NVDIMM Toshi Kani
2015-11-24 22:33 ` Toshi Kani
2015-11-24 22:33 ` [PATCH v3 1/3] resource: Add @flags to region_intersects() Toshi Kani
2015-11-24 22:33 ` Toshi Kani
2015-12-01 13:50 ` Borislav Petkov
2015-12-01 13:50 ` Borislav Petkov
2015-12-01 16:54 ` Dan Williams
2015-12-01 16:54 ` Dan Williams
2015-12-01 16:54 ` Dan Williams
2015-12-01 17:02 ` Jeff Moyer [this message]
2015-12-01 17:02 ` Jeff Moyer
2015-12-01 17:02 ` Jeff Moyer
2015-12-01 17:13 ` Borislav Petkov
2015-12-01 17:13 ` Borislav Petkov
2015-12-01 17:19 ` Linus Torvalds
2015-12-01 17:19 ` Linus Torvalds
2015-12-01 17:19 ` Linus Torvalds
2015-12-03 18:54 ` Toshi Kani
2015-12-03 18:54 ` Toshi Kani
2015-12-03 18:40 ` Borislav Petkov
2015-12-03 18:40 ` Borislav Petkov
2015-12-03 19:01 ` Linus Torvalds
2015-12-03 19:01 ` Linus Torvalds
2015-12-03 19:01 ` Linus Torvalds
2015-12-03 20:35 ` Toshi Kani
2015-12-03 20:35 ` Toshi Kani
2015-12-09 16:25 ` Dan Williams
2015-12-09 16:25 ` Dan Williams
2015-12-09 16:25 ` Dan Williams
2015-12-09 21:44 ` Toshi Kani
2015-12-09 21:44 ` Toshi Kani
2015-11-24 22:33 ` [PATCH v3 2/3] resource: Add region_intersects_pmem() Toshi Kani
2015-11-24 22:33 ` Toshi Kani
2015-11-24 22:33 ` [PATCH v3 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani
2015-11-24 22:33 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49y4dekspp.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.