From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: arm-hdlcd: remove DMA_CMA select
Date: Mon, 4 Jan 2016 09:27:25 +0100 [thread overview]
Message-ID: <20160104082725.GE23797@ulmo> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>
On Fri, Jan 01, 2016 at 03:09:10PM +0100, Arnd Bergmann wrote:
> The newly added DRM_HDLCD driver tries to select DMA_CMA, but that is
> not necessarily possible, as not all configurations contain HAVE_DMA_CONTIGUOUS:
>
> warning: (DRM_HDLCD) selects DMA_CMA which has unmet direct dependencies (HAVE_DMA_CONTIGUOUS && CMA)
> drivers/built-in.o: In function `dma_alloc_from_contiguous':
> :(.text+0x1dee00): undefined reference to `cma_alloc'
> drivers/built-in.o: In function `dma_release_from_contiguous':
> :(.text+0x1dee24): undefined reference to `cma_release'
>
> This removes the 'select' statement. It is not needed because CMA is meant
> to transparently change the behavior of dma_alloc_coherent to make it succeed
> for larger allocations, but there is no actual build-time dependency, and
> the driver can still work without CMA in many cases.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1561e558334d ("drm: Add support for ARM's HDLCD controller.")
> ---
> Found on ARM randconfig builds with yesterday's linux-next
Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160104/e10f1e0d/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dri-devel@lists.freedesktop.org,
Liviu Dudau <liviu.dudau@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: arm-hdlcd: remove DMA_CMA select
Date: Mon, 4 Jan 2016 09:27:25 +0100 [thread overview]
Message-ID: <20160104082725.GE23797@ulmo> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>
[-- Attachment #1.1: Type: text/plain, Size: 1117 bytes --]
On Fri, Jan 01, 2016 at 03:09:10PM +0100, Arnd Bergmann wrote:
> The newly added DRM_HDLCD driver tries to select DMA_CMA, but that is
> not necessarily possible, as not all configurations contain HAVE_DMA_CONTIGUOUS:
>
> warning: (DRM_HDLCD) selects DMA_CMA which has unmet direct dependencies (HAVE_DMA_CONTIGUOUS && CMA)
> drivers/built-in.o: In function `dma_alloc_from_contiguous':
> :(.text+0x1dee00): undefined reference to `cma_alloc'
> drivers/built-in.o: In function `dma_release_from_contiguous':
> :(.text+0x1dee24): undefined reference to `cma_release'
>
> This removes the 'select' statement. It is not needed because CMA is meant
> to transparently change the behavior of dma_alloc_coherent to make it succeed
> for larger allocations, but there is no actual build-time dependency, and
> the driver can still work without CMA in many cases.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1561e558334d ("drm: Add support for ARM's HDLCD controller.")
> ---
> Found on ARM randconfig builds with yesterday's linux-next
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Airlie <airlied@linux.ie>,
linux-arm-kernel@lists.infradead.org,
Liviu Dudau <liviu.dudau@arm.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: arm-hdlcd: remove DMA_CMA select
Date: Mon, 4 Jan 2016 09:27:25 +0100 [thread overview]
Message-ID: <20160104082725.GE23797@ulmo> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
On Fri, Jan 01, 2016 at 03:09:10PM +0100, Arnd Bergmann wrote:
> The newly added DRM_HDLCD driver tries to select DMA_CMA, but that is
> not necessarily possible, as not all configurations contain HAVE_DMA_CONTIGUOUS:
>
> warning: (DRM_HDLCD) selects DMA_CMA which has unmet direct dependencies (HAVE_DMA_CONTIGUOUS && CMA)
> drivers/built-in.o: In function `dma_alloc_from_contiguous':
> :(.text+0x1dee00): undefined reference to `cma_alloc'
> drivers/built-in.o: In function `dma_release_from_contiguous':
> :(.text+0x1dee24): undefined reference to `cma_release'
>
> This removes the 'select' statement. It is not needed because CMA is meant
> to transparently change the behavior of dma_alloc_coherent to make it succeed
> for larger allocations, but there is no actual build-time dependency, and
> the driver can still work without CMA in many cases.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1561e558334d ("drm: Add support for ARM's HDLCD controller.")
> ---
> Found on ARM randconfig builds with yesterday's linux-next
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-04 8:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 14:09 [PATCH] drm: arm-hdlcd: remove DMA_CMA select Arnd Bergmann
2016-01-01 14:09 ` Arnd Bergmann
2016-01-01 14:09 ` Arnd Bergmann
2016-01-01 14:38 ` [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select Arnd Bergmann
2016-01-01 14:38 ` Arnd Bergmann
2016-01-04 8:26 ` Thierry Reding
2016-01-04 8:26 ` Thierry Reding
2016-01-04 8:26 ` Thierry Reding
2016-01-01 14:39 ` [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Arnd Bergmann
2016-01-01 14:39 ` Arnd Bergmann
2016-01-01 14:39 ` Arnd Bergmann
2016-01-04 8:24 ` Thierry Reding
2016-01-04 8:24 ` Thierry Reding
2016-01-04 8:24 ` Thierry Reding
2016-01-01 22:04 ` [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann
2016-01-01 22:04 ` Arnd Bergmann
2016-01-04 8:24 ` Thierry Reding
2016-01-04 8:24 ` Thierry Reding
2016-01-04 8:24 ` Thierry Reding
2016-01-04 8:39 ` Arnd Bergmann
2016-01-04 8:39 ` Arnd Bergmann
2016-01-04 8:39 ` Arnd Bergmann
2016-01-11 11:12 ` Liviu Dudau
2016-01-11 11:12 ` Liviu Dudau
2016-01-11 12:18 ` Arnd Bergmann
2016-01-11 12:18 ` Arnd Bergmann
2016-01-11 12:26 ` Liviu Dudau
2016-01-11 12:26 ` Liviu Dudau
2016-01-11 12:26 ` Liviu Dudau
2016-01-11 13:49 ` Arnd Bergmann
2016-01-11 13:49 ` Arnd Bergmann
2016-01-11 13:49 ` Arnd Bergmann
2016-01-11 14:14 ` Liviu Dudau
2016-01-11 14:14 ` Liviu Dudau
2016-01-11 14:14 ` Liviu Dudau
2016-01-04 8:27 ` Thierry Reding [this message]
2016-01-04 8:27 ` [PATCH] drm: arm-hdlcd: remove DMA_CMA select Thierry Reding
2016-01-04 8:27 ` Thierry Reding
2016-01-11 10:37 ` Liviu Dudau
2016-01-11 10:37 ` Liviu Dudau
2016-01-11 10:37 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104082725.GE23797@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.