All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency
Date: Fri, 01 Jan 2016 23:04:07 +0100	[thread overview]
Message-ID: <5213510.IMdSbsXdoQ@wuerfel> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>

CONFIG_DRM_HDLCD is a tristate option that depends on the boolean
CONFIG_DRM_ARM, which in turn depends on the tristate CONFIG_DRM.
The effect of this is that a configuration with CONFIG_DRM=m
and CONFIG_DRM_HDLCD=y can be chosen, but won't link because the
DRM core symbols are not reachable from builtin code:

drivers/built-in.o: In function `hdlcd_drm_unbind':
drivers/gpu/drm/arm/hdlcd_drv.c:445: undefined reference to `drm_fbdev_cma_fini'
drivers/gpu/drm/arm/hdlcd_drv.c:448: undefined reference to `drm_kms_helper_poll_fini'
drivers/gpu/drm/arm/hdlcd_drv.c:450: undefined reference to `drm_vblank_cleanup'
drivers/gpu/drm/arm/hdlcd_drv.c:452: undefined reference to `drm_irq_uninstall'
drivers/gpu/drm/arm/hdlcd_drv.c:460: undefined reference to `drm_mode_config_cleanup'
drivers/gpu/drm/arm/hdlcd_drv.c:461: undefined reference to `drm_dev_unregister'
drivers/gpu/drm/arm/hdlcd_drv.c:462: undefined reference to `drm_dev_unref'
...

This adds another dependency on CONFIG_DRM to enforce that DRM_HDLCD
cannot be builtin if DRM is not.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Ok, I found yet another one after a few hundred extra randconfig builds
on today's next. Let me know if you'd rather have the three Kconfig
changes combined into a single patch, it's starting to get ridiculous.

diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 81ea7802ca50..487fb1f0c979 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -7,7 +7,7 @@ config DRM_ARM
 
 config DRM_HDLCD
 	tristate "ARM HDLCD"
-	depends on DRM_ARM
+	depends on DRM_ARM && DRM
 	depends on COMMON_CLK
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: David Airlie <airlied@linux.ie>,
	Liviu Dudau <liviu.dudau@arm.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency
Date: Fri, 01 Jan 2016 23:04:07 +0100	[thread overview]
Message-ID: <5213510.IMdSbsXdoQ@wuerfel> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>

CONFIG_DRM_HDLCD is a tristate option that depends on the boolean
CONFIG_DRM_ARM, which in turn depends on the tristate CONFIG_DRM.
The effect of this is that a configuration with CONFIG_DRM=m
and CONFIG_DRM_HDLCD=y can be chosen, but won't link because the
DRM core symbols are not reachable from builtin code:

drivers/built-in.o: In function `hdlcd_drm_unbind':
drivers/gpu/drm/arm/hdlcd_drv.c:445: undefined reference to `drm_fbdev_cma_fini'
drivers/gpu/drm/arm/hdlcd_drv.c:448: undefined reference to `drm_kms_helper_poll_fini'
drivers/gpu/drm/arm/hdlcd_drv.c:450: undefined reference to `drm_vblank_cleanup'
drivers/gpu/drm/arm/hdlcd_drv.c:452: undefined reference to `drm_irq_uninstall'
drivers/gpu/drm/arm/hdlcd_drv.c:460: undefined reference to `drm_mode_config_cleanup'
drivers/gpu/drm/arm/hdlcd_drv.c:461: undefined reference to `drm_dev_unregister'
drivers/gpu/drm/arm/hdlcd_drv.c:462: undefined reference to `drm_dev_unref'
...

This adds another dependency on CONFIG_DRM to enforce that DRM_HDLCD
cannot be builtin if DRM is not.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Ok, I found yet another one after a few hundred extra randconfig builds
on today's next. Let me know if you'd rather have the three Kconfig
changes combined into a single patch, it's starting to get ridiculous.

diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 81ea7802ca50..487fb1f0c979 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -7,7 +7,7 @@ config DRM_ARM
 
 config DRM_HDLCD
 	tristate "ARM HDLCD"
-	depends on DRM_ARM
+	depends on DRM_ARM && DRM
 	depends on COMMON_CLK
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER

  parent reply	other threads:[~2016-01-01 22:04 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 14:09 [PATCH] drm: arm-hdlcd: remove DMA_CMA select Arnd Bergmann
2016-01-01 14:09 ` Arnd Bergmann
2016-01-01 14:09 ` Arnd Bergmann
2016-01-01 14:38 ` [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select Arnd Bergmann
2016-01-01 14:38   ` Arnd Bergmann
2016-01-04  8:26   ` Thierry Reding
2016-01-04  8:26     ` Thierry Reding
2016-01-04  8:26     ` Thierry Reding
2016-01-01 14:39 ` [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Arnd Bergmann
2016-01-01 14:39   ` Arnd Bergmann
2016-01-01 14:39   ` Arnd Bergmann
2016-01-04  8:24   ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-01 22:04 ` Arnd Bergmann [this message]
2016-01-01 22:04   ` [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann
2016-01-04  8:24   ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-04  8:39     ` Arnd Bergmann
2016-01-04  8:39       ` Arnd Bergmann
2016-01-04  8:39       ` Arnd Bergmann
2016-01-11 11:12       ` Liviu Dudau
2016-01-11 11:12         ` Liviu Dudau
2016-01-11 12:18         ` Arnd Bergmann
2016-01-11 12:18           ` Arnd Bergmann
2016-01-11 12:26           ` Liviu Dudau
2016-01-11 12:26             ` Liviu Dudau
2016-01-11 12:26             ` Liviu Dudau
2016-01-11 13:49             ` Arnd Bergmann
2016-01-11 13:49               ` Arnd Bergmann
2016-01-11 13:49               ` Arnd Bergmann
2016-01-11 14:14               ` Liviu Dudau
2016-01-11 14:14                 ` Liviu Dudau
2016-01-11 14:14                 ` Liviu Dudau
2016-01-04  8:27 ` [PATCH] drm: arm-hdlcd: remove DMA_CMA select Thierry Reding
2016-01-04  8:27   ` Thierry Reding
2016-01-04  8:27   ` Thierry Reding
2016-01-11 10:37 ` Liviu Dudau
2016-01-11 10:37   ` Liviu Dudau
2016-01-11 10:37   ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5213510.IMdSbsXdoQ@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.