From: Michal Hocko <mhocko@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mm, vmstat: kernel BUG at mm/vmstat.c:1408!
Date: Thu, 21 Jan 2016 17:51:49 +0100 [thread overview]
Message-ID: <20160121165148.GF29520@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.20.1601210941540.7063@east.gentwo.org>
On Thu 21-01-16 09:45:12, Christoph Lameter wrote:
> On Thu, 21 Jan 2016, Michal Hocko wrote:
[...]
> > The vmstat update might be still waiting for its timer, idle mode started
> > and kick vmstat_update which might cpumask_test_and_set_cpu. Once the
> > idle terminates and the originally schedule vmstate_update executes it
> > sees the bit set and BUG_ON.
>
> Ok so we are going into idle mode and the vmstat_update timer is pending.
> Then the timer will not fire since going idle switches preemption off.
> quiet_vmstat will run without the chance of running vmstat_update
>
> We could be going idle and not have disabled preemption yet. Then
> vmstat_update will run. On return to the idling operation preemption will
> be disabled and quiet_vmstat() will be run.
>
> I do not see how these two things could race.
It goes like this:
CPU0: CPU1
vmstat_update
cpumask_test_and_set_cpu (0->1)
[...]
vmstat_shepherd
<enter idle> cpumask_test_and_clear_cpu(CPU0) (1->0)
quiet_vmstat
cpumask_test_and_set_cpu (0->1)
queue_delayed_work_on(CPU0)
refresh_cpu_vm_stats()
[...]
vmstat_update
nothing_to_do
cpumask_test_and_set_cpu (1->1)
VM_BUG_ON
Or am I missing something?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mm, vmstat: kernel BUG at mm/vmstat.c:1408!
Date: Thu, 21 Jan 2016 17:51:49 +0100 [thread overview]
Message-ID: <20160121165148.GF29520@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.20.1601210941540.7063@east.gentwo.org>
On Thu 21-01-16 09:45:12, Christoph Lameter wrote:
> On Thu, 21 Jan 2016, Michal Hocko wrote:
[...]
> > The vmstat update might be still waiting for its timer, idle mode started
> > and kick vmstat_update which might cpumask_test_and_set_cpu. Once the
> > idle terminates and the originally schedule vmstate_update executes it
> > sees the bit set and BUG_ON.
>
> Ok so we are going into idle mode and the vmstat_update timer is pending.
> Then the timer will not fire since going idle switches preemption off.
> quiet_vmstat will run without the chance of running vmstat_update
>
> We could be going idle and not have disabled preemption yet. Then
> vmstat_update will run. On return to the idling operation preemption will
> be disabled and quiet_vmstat() will be run.
>
> I do not see how these two things could race.
It goes like this:
CPU0: CPU1
vmstat_update
cpumask_test_and_set_cpu (0->1)
[...]
vmstat_shepherd
<enter idle> cpumask_test_and_clear_cpu(CPU0) (1->0)
quiet_vmstat
cpumask_test_and_set_cpu (0->1)
queue_delayed_work_on(CPU0)
refresh_cpu_vm_stats()
[...]
vmstat_update
nothing_to_do
cpumask_test_and_set_cpu (1->1)
VM_BUG_ON
Or am I missing something?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-01-21 16:51 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 0:33 mm, vmstat: kernel BUG at mm/vmstat.c:1408! Sasha Levin
2015-12-19 0:33 ` Sasha Levin
2015-12-21 13:08 ` Christoph Lameter
2015-12-21 13:08 ` Christoph Lameter
2015-12-21 20:28 ` Sasha Levin
2015-12-21 20:28 ` Sasha Levin
2015-12-21 21:07 ` Sasha Levin
2015-12-21 21:07 ` Sasha Levin
2015-12-21 21:14 ` Christoph Lameter
2015-12-21 21:14 ` Christoph Lameter
2015-12-22 17:21 ` Christoph Lameter
2015-12-22 17:21 ` Christoph Lameter
2015-12-24 20:14 ` Sasha Levin
2015-12-29 17:01 ` Christoph Lameter
2015-12-29 17:01 ` Christoph Lameter
2015-12-29 17:18 ` Christoph Lameter
2015-12-29 17:18 ` Christoph Lameter
2016-01-04 18:05 ` Christoph Lameter
2016-01-04 18:05 ` Christoph Lameter
2016-01-04 18:46 ` Sasha Levin
2016-01-04 18:46 ` Sasha Levin
2016-01-12 11:31 ` Shiraz Hashim
2016-01-12 11:31 ` Shiraz Hashim
2016-01-12 12:23 ` Christoph Lameter
2016-01-12 12:23 ` Christoph Lameter
2016-01-12 12:27 ` Shiraz Hashim
2016-01-12 12:27 ` Shiraz Hashim
2016-01-13 11:36 ` Shiraz Hashim
2016-01-13 11:36 ` Shiraz Hashim
2016-01-13 12:32 ` Shiraz Hashim
2016-01-13 12:32 ` Shiraz Hashim
2016-01-14 21:06 ` Sasha Levin
2016-01-14 21:06 ` Sasha Levin
2016-01-20 14:37 ` Michal Hocko
2016-01-20 14:37 ` Michal Hocko
2016-01-20 14:56 ` Sasha Levin
2016-01-20 14:56 ` Sasha Levin
2016-01-20 15:10 ` Michal Hocko
2016-01-20 15:10 ` Michal Hocko
2016-01-20 15:20 ` Christoph Lameter
2016-01-20 15:20 ` Christoph Lameter
2016-01-20 15:49 ` Sasha Levin
2016-01-20 15:49 ` Sasha Levin
2016-01-20 15:55 ` Christoph Lameter
2016-01-20 15:55 ` Christoph Lameter
2016-01-20 21:28 ` Michal Hocko
2016-01-20 21:28 ` Michal Hocko
2016-01-20 21:57 ` Christoph Lameter
2016-01-20 21:57 ` Christoph Lameter
2016-01-21 8:24 ` Michal Hocko
2016-01-21 8:24 ` Michal Hocko
2016-01-21 15:45 ` Christoph Lameter
2016-01-21 15:45 ` Christoph Lameter
2016-01-21 16:51 ` Michal Hocko [this message]
2016-01-21 16:51 ` Michal Hocko
2016-01-21 17:38 ` Christoph Lameter
2016-01-21 17:38 ` Christoph Lameter
2016-01-22 11:00 ` Shiraz Hashim
2016-01-22 11:00 ` Shiraz Hashim
2016-01-22 14:04 ` Michal Hocko
2016-01-22 14:04 ` Michal Hocko
2016-01-22 16:07 ` Christoph Lameter
2016-01-22 16:07 ` Christoph Lameter
2016-01-22 16:12 ` Michal Hocko
2016-01-22 16:12 ` Michal Hocko
2016-01-22 16:46 ` Christoph Lameter
2016-01-22 16:46 ` Christoph Lameter
2016-01-22 17:12 ` Michal Hocko
2016-01-22 17:12 ` Michal Hocko
2016-01-23 16:21 ` fast path cycle muncher (vmstat: make vmstat_updater deferrable again and shut down on idle) Mike Galbraith
2016-01-24 0:33 ` Christoph Lameter
2016-01-24 2:46 ` Mike Galbraith
2016-01-24 3:46 ` Christoph Lameter
2016-01-24 5:36 ` Mike Galbraith
2016-01-25 17:42 ` Michal Hocko
2016-01-25 18:02 ` Christoph Lameter
2016-01-25 20:13 ` Michal Hocko
2016-01-26 16:25 ` Christoph Lameter
2016-01-26 18:31 ` Mike Galbraith
2016-01-26 18:34 ` Christoph Lameter
2016-01-26 18:45 ` Mike Galbraith
2016-01-26 19:20 ` Christoph Lameter
2016-01-27 3:12 ` Mike Galbraith
2016-01-27 4:15 ` Mike Galbraith
2016-01-27 16:28 ` Christoph Lameter
2016-01-28 15:36 ` Frederic Weisbecker
2016-01-28 16:42 ` Christoph Lameter
2016-01-26 2:14 ` Mike Galbraith
2016-01-26 2:25 ` Mike Galbraith
2016-01-26 16:26 ` Christoph Lameter
2016-01-26 17:39 ` Mike Galbraith
2016-01-26 18:19 ` Christoph Lameter
2016-01-26 16:26 ` Christoph Lameter
2016-01-26 17:08 ` Mike Galbraith
2016-01-26 18:22 ` Christoph Lameter
2016-01-26 19:09 ` Mike Galbraith
2016-01-26 19:22 ` Christoph Lameter
2016-01-27 16:48 ` [PATCH] mm, vmstat: make quiet_vmstat lighter (was: Re: fast path cycle muncher (vmstat: make vmstat_updater deferrable) " Michal Hocko
2016-01-27 17:03 ` Mike Galbraith
2016-01-27 18:26 ` Christoph Lameter
2016-01-28 15:21 ` Michal Hocko
2016-01-28 16:40 ` Christoph Lameter
2016-01-28 16:53 ` Michal Hocko
2016-01-28 17:05 ` Christoph Lameter
2016-01-28 15:31 ` Michal Hocko
2016-01-28 15:37 ` [PATCH] vmstat: make vmstat_update deferrable (was: Re: [PATCH] mm, vmstat: make quiet_vmstat lighter) " Michal Hocko
2016-01-28 16:48 ` Christoph Lameter
2016-01-28 16:42 ` [PATCH] mm, vmstat: make quiet_vmstat lighter (was: Re: fast " Christoph Lameter
2016-01-24 16:57 ` mm, vmstat: kernel BUG at mm/vmstat.c:1408! Linus Torvalds
2016-01-24 16:57 ` Linus Torvalds
2016-01-20 15:14 ` Christoph Lameter
2016-01-20 15:14 ` Christoph Lameter
2016-01-20 15:20 ` Michal Hocko
2016-01-20 15:20 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121165148.GF29520@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.