All of lore.kernel.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: select CLKSRC_MMIO where needed
Date: Mon, 25 Jan 2016 21:09:16 +0200	[thread overview]
Message-ID: <20160125190916.GO2916@tarshish> (raw)
In-Reply-To: <1453737776-1960372-1-git-send-email-arnd@arndb.de>

Hi Arnd,

On Mon, Jan 25, 2016 at 05:02:49PM +0100, Arnd Bergmann wrote:
> The Tegra clocksource implementation uses the clocksource_mmio helper
> functions, but currently can be configured without them, which fails:
> 
> drivers/clocksource/built-in.o: In function `tegra20_init_timer':
> :(.init.text+0xac): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up'
> 
> The same problem exists for Digicolor:
> 
> drivers/clocksource/built-in.o: In function `digicolor_timer_init':
> :(.init.text+0xfa): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down'
> 
> I've inspected the Kconfig file to look for other cases that I have not
> yet run into, and added an explicit 'select' to each one to ensure we
> can successfully link the drivers.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

For Digicolor:

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: select CLKSRC_MMIO where needed
Date: Mon, 25 Jan 2016 21:09:16 +0200	[thread overview]
Message-ID: <20160125190916.GO2916@tarshish> (raw)
In-Reply-To: <1453737776-1960372-1-git-send-email-arnd@arndb.de>

Hi Arnd,

On Mon, Jan 25, 2016 at 05:02:49PM +0100, Arnd Bergmann wrote:
> The Tegra clocksource implementation uses the clocksource_mmio helper
> functions, but currently can be configured without them, which fails:
> 
> drivers/clocksource/built-in.o: In function `tegra20_init_timer':
> :(.init.text+0xac): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up'
> 
> The same problem exists for Digicolor:
> 
> drivers/clocksource/built-in.o: In function `digicolor_timer_init':
> :(.init.text+0xfa): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down'
> 
> I've inspected the Kconfig file to look for other cases that I have not
> yet run into, and added an explicit 'select' to each one to ensure we
> can successfully link the drivers.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

For Digicolor:

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2016-01-25 19:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 16:02 [PATCH] clocksource: select CLKSRC_MMIO where needed Arnd Bergmann
2016-01-25 16:02 ` Arnd Bergmann
2016-01-25 19:09 ` Baruch Siach [this message]
2016-01-25 19:09   ` Baruch Siach
2016-01-26 15:40 ` [tip:timers/urgent] clocksource: Select " tip-bot for Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160125190916.GO2916@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.