Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

[Bin Liu]

Hi,


On Wed, Mar 30, 2016 at 06:56:28AM +0800, Antonio Victor Hilario wrote:
> I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and had found and corrected this on my local build tree.
> 
> Kernel build fails when the source file drivers/usb/musb/musb_cppi41.c is built, with these kernel options enabled:
> 
> CONFIG_USB_MUSB_HDRC=y
> CONFIG_USB_TI_CPPI41_DMA=y
> 
> The build fails with these errors, due to a misspelled constant name EP_MODE_AUTOREQ_NONE:
> 
> drivers/usb/musb/musb_cppi41.c: In function 'cppi41_dma_channel_abort':
> drivers/usb/musb/musb_cppi41.c:544:43: error: 'EP_MODE_AUTOREQ_NONE' undeclared (first use in this function)
>    cppi41_set_autoreq_mode(cppi41_channel, EP_MODE_AUTOREQ_NONE);
>                                            ^
> drivers/usb/musb/musb_cppi41.c:544:43: note: each undeclared identifier is reported only once for each function it appears in
> scripts/Makefile.build:257: recipe for target 'drivers/usb/musb/musb_cppi41.o' failed
> make[3]: *** [drivers/usb/musb/musb_cppi41.o] Error 1
> scripts/Makefile.build:402: recipe for target 'drivers/usb/musb' failed
> make[2]: *** [drivers/usb/musb] Error 2
> scripts/Makefile.build:402: recipe for target 'drivers/usb' failed
> make[1]: *** [drivers/usb] Error 2
> Makefile:937: recipe for target 'drivers' failed
> 

This is due to the stable kernel misses patch 0149b07 (usb: musb:
cppi41: correct the macro name EP_MODE_AUTOREG_*) from the upstream when
back porting.

I believe this has been corrected in v3.12, but not sure about other
stable kernels - I wasn't cc'd in these backport notification emails.

Regards,
-Bin.

Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

[Bin Liu]

Hi,

On Wed, Mar 30, 2016 at 10:23:31AM -0500, Bin Liu wrote:
> Hi,
> 
> 
> On Wed, Mar 30, 2016 at 06:56:28AM +0800, Antonio Victor Hilario wrote:
> > I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and had found and corrected this on my local build tree.
> > 
> > Kernel build fails when the source file drivers/usb/musb/musb_cppi41.c is built, with these kernel options enabled:
> > 
> > CONFIG_USB_MUSB_HDRC=y
> > CONFIG_USB_TI_CPPI41_DMA=y
> > 
> > The build fails with these errors, due to a misspelled constant name EP_MODE_AUTOREQ_NONE:
> > 
> > drivers/usb/musb/musb_cppi41.c: In function 'cppi41_dma_channel_abort':
> > drivers/usb/musb/musb_cppi41.c:544:43: error: 'EP_MODE_AUTOREQ_NONE' undeclared (first use in this function)
> >    cppi41_set_autoreq_mode(cppi41_channel, EP_MODE_AUTOREQ_NONE);
> >                                            ^
> > drivers/usb/musb/musb_cppi41.c:544:43: note: each undeclared identifier is reported only once for each function it appears in
> > scripts/Makefile.build:257: recipe for target 'drivers/usb/musb/musb_cppi41.o' failed
> > make[3]: *** [drivers/usb/musb/musb_cppi41.o] Error 1
> > scripts/Makefile.build:402: recipe for target 'drivers/usb/musb' failed
> > make[2]: *** [drivers/usb/musb] Error 2
> > scripts/Makefile.build:402: recipe for target 'drivers/usb' failed
> > make[1]: *** [drivers/usb] Error 2
> > Makefile:937: recipe for target 'drivers' failed
> > 
> 
> This is due to the stable kernel misses patch 0149b07 (usb: musb:
> cppi41: correct the macro name EP_MODE_AUTOREG_*) from the upstream when
> back porting.
> 
> I believe this has been corrected in v3.12, but not sure about other
> stable kernels - I wasn't cc'd in these backport notification emails.

FYI -
http://article.gmane.org/gmane.linux.kernel.stable/167063/match=cppi41

> 
> Regards,
> -Bin.
>