All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Yves-Alexis Perez <corsac@debian.org>,
	Emrah Demir <ed@abdsec.com>, Jonathan Corbet <corbet@lwn.net>,
	x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH] Prefer kASLR over Hibernation
Date: Wed, 6 Apr 2016 23:56:38 +0200	[thread overview]
Message-ID: <20160406215638.GA25539@gmail.com> (raw)
In-Reply-To: <CAJZ5v0ieAd3WSiytzcdtD=eueLPk_SM1KgrqZXHBa6+bwK=KnQ@mail.gmail.com>


* Rafael J. Wysocki <rafael@kernel.org> wrote:

> On Wed, Apr 6, 2016 at 9:44 PM, Kees Cook <keescook@chromium.org> wrote:
> > When building with both CONFIG_HIBERNATION and CONFIG_RANDOMIZE_BASE,
> > one or the other must be chosen at boot-time. Until now, hibernation
> > was selected when no choice was made on the command line.
> >
> > To make the security benefits of kASLR more widely available to end
> > users (since the use of hibernation is becoming more rare and kASLR,
> > already available on x86, will be available on arm64 and MIPS soon),
> > this changes the default to preferring kASLR over hibernation. Users
> > wanting hibernation can turn off kASLR by adding "nokaslr" to the kernel
> > command line.
> >
> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Or do you want me to apply it?

I don't think this is a good idea, as it turns off emergency hibernation of 
laptops - many desktop distros support it by default.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Yves-Alexis Perez <corsac@debian.org>,
	Emrah Demir <ed@abdsec.com>, Jonathan Corbet <corbet@lwn.net>,
	x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] Prefer kASLR over Hibernation
Date: Wed, 6 Apr 2016 23:56:38 +0200	[thread overview]
Message-ID: <20160406215638.GA25539@gmail.com> (raw)
In-Reply-To: <CAJZ5v0ieAd3WSiytzcdtD=eueLPk_SM1KgrqZXHBa6+bwK=KnQ@mail.gmail.com>


* Rafael J. Wysocki <rafael@kernel.org> wrote:

> On Wed, Apr 6, 2016 at 9:44 PM, Kees Cook <keescook@chromium.org> wrote:
> > When building with both CONFIG_HIBERNATION and CONFIG_RANDOMIZE_BASE,
> > one or the other must be chosen at boot-time. Until now, hibernation
> > was selected when no choice was made on the command line.
> >
> > To make the security benefits of kASLR more widely available to end
> > users (since the use of hibernation is becoming more rare and kASLR,
> > already available on x86, will be available on arm64 and MIPS soon),
> > this changes the default to preferring kASLR over hibernation. Users
> > wanting hibernation can turn off kASLR by adding "nokaslr" to the kernel
> > command line.
> >
> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Or do you want me to apply it?

I don't think this is a good idea, as it turns off emergency hibernation of 
laptops - many desktop distros support it by default.

Thanks,

	Ingo

  reply	other threads:[~2016-04-06 21:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 19:44 [kernel-hardening] [PATCH] Prefer kASLR over Hibernation Kees Cook
2016-04-06 19:44 ` Kees Cook
2016-04-06 20:17 ` [kernel-hardening] " Pavel Machek
2016-04-06 20:17   ` Pavel Machek
2016-04-06 20:56   ` [kernel-hardening] " Linus Torvalds
2016-04-06 20:56     ` Linus Torvalds
2016-04-06 21:25     ` [kernel-hardening] " Kees Cook
2016-04-06 21:25       ` Kees Cook
2016-04-06 21:48       ` [kernel-hardening] " Ingo Molnar
2016-04-06 21:48         ` Ingo Molnar
2016-04-06 21:52         ` [kernel-hardening] " Ingo Molnar
2016-04-06 21:52           ` Ingo Molnar
2016-04-06 22:32           ` [kernel-hardening] " Rafael J. Wysocki
2016-04-06 22:32             ` Rafael J. Wysocki
2016-04-07  0:49             ` [kernel-hardening] " Ingo Molnar
2016-04-07  0:49               ` Ingo Molnar
2016-04-06 21:49 ` [kernel-hardening] " Rafael J. Wysocki
2016-04-06 21:49   ` Rafael J. Wysocki
2016-04-06 21:56   ` Ingo Molnar [this message]
2016-04-06 21:56     ` Ingo Molnar
2016-04-06 22:04     ` [kernel-hardening] " Rafael J. Wysocki
2016-04-06 22:04       ` Rafael J. Wysocki
2016-04-06 22:16       ` [kernel-hardening] " Kees Cook
2016-04-06 22:16         ` Kees Cook
2016-04-06 22:41         ` [kernel-hardening] " Paul Bolle
2016-04-06 22:41           ` Paul Bolle
2016-04-07  0:05         ` [kernel-hardening] " Ingo Molnar
2016-04-07  0:05           ` Ingo Molnar
2016-04-11  8:00 ` [kernel-hardening] " James Morse
2016-04-11  8:00   ` James Morse
2016-04-11 18:03   ` [kernel-hardening] " Kees Cook
2016-04-11 18:03     ` Kees Cook
2016-04-11 18:21     ` [kernel-hardening] " Geert Uytterhoeven
2016-04-11 18:21       ` Geert Uytterhoeven
2016-04-11 18:47       ` [kernel-hardening] " Kees Cook
2016-04-11 18:47         ` Kees Cook
2016-04-12 17:51     ` [kernel-hardening] " James Morse
2016-04-12 17:51       ` James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406215638.GA25539@gmail.com \
    --to=mingo@kernel.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bp@suse.de \
    --cc=corbet@lwn.net \
    --cc=corsac@debian.org \
    --cc=ed@abdsec.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=matt.redfearn@imgtec.com \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.