From: helgaas@kernel.org (Bjorn Helgaas)
Subject: [PATCH 1/2] PCI: Provide sensible irq vector alloc/free routines
Date: Fri, 6 May 2016 11:35:10 -0500 [thread overview]
Message-ID: <20160506163510.GA20754@localhost> (raw)
In-Reply-To: <20160506162823.GB7999@lst.de>
On Fri, May 06, 2016@06:28:23PM +0200, Christoph Hellwig wrote:
> On Fri, May 06, 2016@11:04:08AM -0500, Bjorn Helgaas wrote:
> > I like this a lot. One relatively minor comment below.
>
> Do you want this addressed? The problem is that I probably will also
> need something like this flags argument for introducing the irq spreading
> as we can't simply do it for all callers directly. If you take
> the patch as-is I'd be happy to do another pass later to remove it
> and look into different no-MSI quirking once we're done with the
> MSI-X spreading work.
I don't know what sort of clues you'll need for IRQ spreading, but
that sounds like a good reason for the argument. So if you will need
the flags argument for something else, then I think it's OK as-is.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: agordeev@redhat.com, pjw@netapp.com, axboe@fb.com,
keith.busch@intel.com, linux-pci@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] PCI: Provide sensible irq vector alloc/free routines
Date: Fri, 6 May 2016 11:35:10 -0500 [thread overview]
Message-ID: <20160506163510.GA20754@localhost> (raw)
In-Reply-To: <20160506162823.GB7999@lst.de>
On Fri, May 06, 2016 at 06:28:23PM +0200, Christoph Hellwig wrote:
> On Fri, May 06, 2016 at 11:04:08AM -0500, Bjorn Helgaas wrote:
> > I like this a lot. One relatively minor comment below.
>
> Do you want this addressed? The problem is that I probably will also
> need something like this flags argument for introducing the irq spreading
> as we can't simply do it for all callers directly. If you take
> the patch as-is I'd be happy to do another pass later to remove it
> and look into different no-MSI quirking once we're done with the
> MSI-X spreading work.
I don't know what sort of clues you'll need for IRQ spreading, but
that sounds like a good reason for the argument. So if you will need
the flags argument for something else, then I think it's OK as-is.
Bjorn
next prev parent reply other threads:[~2016-05-06 16:35 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 14:04 PCI: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-05-05 14:04 ` Christoph Hellwig
2016-05-05 14:04 ` [PATCH 1/2] " Christoph Hellwig
2016-05-05 14:04 ` Christoph Hellwig
2016-05-06 16:04 ` Bjorn Helgaas
2016-05-06 16:04 ` Bjorn Helgaas
2016-05-06 16:28 ` Christoph Hellwig
2016-05-06 16:28 ` Christoph Hellwig
2016-05-06 16:35 ` Bjorn Helgaas [this message]
2016-05-06 16:35 ` Bjorn Helgaas
2016-05-08 9:05 ` Christoph Hellwig
2016-05-08 9:05 ` Christoph Hellwig
2016-05-09 22:46 ` Bjorn Helgaas
2016-05-09 22:46 ` Bjorn Helgaas
2016-05-11 8:52 ` Christoph Hellwig
2016-05-11 8:52 ` Christoph Hellwig
2016-05-16 19:39 ` Bjorn Helgaas
2016-05-16 19:39 ` Bjorn Helgaas
2016-05-17 16:45 ` Christoph Hellwig
2016-05-17 16:45 ` Christoph Hellwig
2016-05-11 7:45 ` Alexander Gordeev
2016-05-11 7:45 ` Alexander Gordeev
2016-05-11 8:50 ` Christoph Hellwig
2016-05-11 8:50 ` Christoph Hellwig
2016-05-11 9:44 ` Alexander Gordeev
2016-05-11 9:44 ` Alexander Gordeev
2016-05-12 7:35 ` Christoph Hellwig
2016-05-12 7:35 ` Christoph Hellwig
2016-05-12 9:44 ` Alexander Gordeev
2016-05-12 9:44 ` Alexander Gordeev
2016-05-12 11:03 ` Christoph Hellwig
2016-05-12 11:03 ` Christoph Hellwig
2016-05-12 12:11 ` Alexander Gordeev
2016-05-12 12:11 ` Alexander Gordeev
2016-05-12 12:19 ` Christoph Hellwig
2016-05-12 12:19 ` Christoph Hellwig
2016-05-12 14:29 ` Christoph Hellwig
2016-05-12 14:29 ` Christoph Hellwig
2016-05-13 8:29 ` Alexander Gordeev
2016-05-13 8:29 ` Alexander Gordeev
2016-06-11 1:14 ` Bjorn Helgaas
2016-06-11 1:14 ` Bjorn Helgaas
2016-06-13 15:15 ` Christoph Hellwig
2016-06-13 15:15 ` Christoph Hellwig
2016-06-21 14:33 ` Christoph Hellwig
2016-06-21 14:33 ` Christoph Hellwig
2016-05-12 11:04 ` Alexander Gordeev
2016-05-12 11:04 ` Alexander Gordeev
2016-05-12 11:04 ` Christoph Hellwig
2016-05-12 11:04 ` Christoph Hellwig
2016-05-05 14:04 ` [PATCH 2/2] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-05-05 14:04 ` Christoph Hellwig
2016-05-10 15:27 ` Keith Busch
2016-05-10 15:27 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506163510.GA20754@localhost \
--to=helgaas@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.