All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] PCI: Provide sensible irq vector alloc/free routines
Date: Thu, 12 May 2016 13:04:29 +0200	[thread overview]
Message-ID: <20160512110429.GA9352@lst.de> (raw)
In-Reply-To: <20160512110456.GA8681@agordeev.lab.eng.brq.redhat.com>

On Thu, May 12, 2016@01:04:58PM +0200, Alexander Gordeev wrote:
> Because MSI vectors are allocated sequentially we do not really
> need pdev->irqs[] for MSI. It is 32 items at most, but still.

The allocator itself doesn't "need" it.  Any driver that doesn't want
to special case MSI vs MSI-X all through the code needs it, though.


(oh, and please don't full quote the whole email, thank you!)

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	helgaas@kernel.org, pjw@netapp.com, axboe@fb.com,
	keith.busch@intel.com, linux-pci@vger.kernel.org,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] PCI: Provide sensible irq vector alloc/free routines
Date: Thu, 12 May 2016 13:04:29 +0200	[thread overview]
Message-ID: <20160512110429.GA9352@lst.de> (raw)
In-Reply-To: <20160512110456.GA8681@agordeev.lab.eng.brq.redhat.com>

On Thu, May 12, 2016 at 01:04:58PM +0200, Alexander Gordeev wrote:
> Because MSI vectors are allocated sequentially we do not really
> need pdev->irqs[] for MSI. It is 32 items at most, but still.

The allocator itself doesn't "need" it.  Any driver that doesn't want
to special case MSI vs MSI-X all through the code needs it, though.


(oh, and please don't full quote the whole email, thank you!)

  reply	other threads:[~2016-05-12 11:04 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05 14:04 PCI: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-05-05 14:04 ` Christoph Hellwig
2016-05-05 14:04 ` [PATCH 1/2] " Christoph Hellwig
2016-05-05 14:04   ` Christoph Hellwig
2016-05-06 16:04   ` Bjorn Helgaas
2016-05-06 16:04     ` Bjorn Helgaas
2016-05-06 16:28     ` Christoph Hellwig
2016-05-06 16:28       ` Christoph Hellwig
2016-05-06 16:35       ` Bjorn Helgaas
2016-05-06 16:35         ` Bjorn Helgaas
2016-05-08  9:05         ` Christoph Hellwig
2016-05-08  9:05           ` Christoph Hellwig
2016-05-09 22:46   ` Bjorn Helgaas
2016-05-09 22:46     ` Bjorn Helgaas
2016-05-11  8:52     ` Christoph Hellwig
2016-05-11  8:52       ` Christoph Hellwig
2016-05-16 19:39     ` Bjorn Helgaas
2016-05-16 19:39       ` Bjorn Helgaas
2016-05-17 16:45       ` Christoph Hellwig
2016-05-17 16:45         ` Christoph Hellwig
2016-05-11  7:45   ` Alexander Gordeev
2016-05-11  7:45     ` Alexander Gordeev
2016-05-11  8:50     ` Christoph Hellwig
2016-05-11  8:50       ` Christoph Hellwig
2016-05-11  9:44       ` Alexander Gordeev
2016-05-11  9:44         ` Alexander Gordeev
2016-05-12  7:35         ` Christoph Hellwig
2016-05-12  7:35           ` Christoph Hellwig
2016-05-12  9:44           ` Alexander Gordeev
2016-05-12  9:44             ` Alexander Gordeev
2016-05-12 11:03             ` Christoph Hellwig
2016-05-12 11:03               ` Christoph Hellwig
2016-05-12 12:11               ` Alexander Gordeev
2016-05-12 12:11                 ` Alexander Gordeev
2016-05-12 12:19                 ` Christoph Hellwig
2016-05-12 12:19                   ` Christoph Hellwig
2016-05-12 14:29                   ` Christoph Hellwig
2016-05-12 14:29                     ` Christoph Hellwig
2016-05-13  8:29                     ` Alexander Gordeev
2016-05-13  8:29                       ` Alexander Gordeev
2016-06-11  1:14                       ` Bjorn Helgaas
2016-06-11  1:14                         ` Bjorn Helgaas
2016-06-13 15:15                         ` Christoph Hellwig
2016-06-13 15:15                           ` Christoph Hellwig
2016-06-21 14:33                         ` Christoph Hellwig
2016-06-21 14:33                           ` Christoph Hellwig
2016-05-12 11:04   ` Alexander Gordeev
2016-05-12 11:04     ` Alexander Gordeev
2016-05-12 11:04     ` Christoph Hellwig [this message]
2016-05-12 11:04       ` Christoph Hellwig
2016-05-05 14:04 ` [PATCH 2/2] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-05-05 14:04   ` Christoph Hellwig
2016-05-10 15:27   ` Keith Busch
2016-05-10 15:27     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160512110429.GA9352@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.