Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 839 bytes --]

On Wed, May 18, 2016 at 05:18:41PM +0200, Alexander Stein wrote:

> Well, it's debatable if using dev_err() and then returning EPROBE_DEFER is 
> correct either. IMHO if there is an actual error, an error code has to be 
> returned and not "well, can't continue now, probe me again later".
> At first glance those EPROBE_DEFER are correct as other dependent drivers may 
> be probed later, so printing an error in that case seems wrong to me.

Half the point with probe deferral is that it's transparent to anything
that isn't actually resolving a resource - if we have to add custom code
in to everywhere were we need to print an error in a probe path that's
not great either.  We also don't want to silently ignore probe deferral
all the time since then it becomes very hard to diagnose why something
is not instantiating.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]