Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe

[Takashi Iwai <tiwai@suse.de>]

On Wed, 18 May 2016 18:21:54 +0200,
Mark Brown wrote:
> 
> On Wed, May 18, 2016 at 05:50:50PM +0200, Alexander Stein wrote:
> 
> > My first idea was to use dev_dbg() but that actualy remove that message at 
> > all, unless dynamic debug is used, so I went with dev_notice. It's still 
> > there, but does not clobber quiet boot log, nor some sophisticated kernel log 
> > parser as journalctl which prints errors in red color.
> 
> It's just shifting the problem around...  it sounds like for your use
> case suppressing the messages until we finish kernel boot would deal
> with most of the issue in a far more general fashion.

It comes to the question whether this message must be shown verbosely
as an error at all.  EPROBE_DEFER is usually a mechanism for the
delayed probe, and it doesn't indicate an error per se.  dev_err() is,
OTOH, for real errors that have to be notified to user inevitably.
That's why "quiet" boot option still shows it.


Takashi