Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]

On Thu, May 19, 2016 at 08:53:31AM +0200, Takashi Iwai wrote:
> Alexander Stein wrote:
> > On Wednesday 18 May 2016 21:33:01, Takashi Iwai wrote:

> > > dev_notice() lowers the log level to somewhat between info and
> > > warning, and it looks like a sensible choice to me.

> > You want me to change the subject to be more clear?

> If the patch can go in, yes.  The changelog text should be also
> clearer why it's needed and what it gives, too.

There's also the problem with it just squashing all errors, not just
probe deferral.  I really would prefer to see at least some attempt to
push this into a central helper rather than just open coding hacks in
every single user though, that's the thing here.  We want a simple and
consistent way of handling this, going round and doing something custom
at every single caller is going to result in inconsistent behaviour and
means that it's harder to deploy and new and better solutions.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]