From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe
Date: Wed, 18 May 2016 17:18:41 +0200 [thread overview]
Message-ID: <209086304.1BTKYSBN0B@ws-stein> (raw)
In-Reply-To: <20160518150812.GK8104@sirena.org.uk>
On Wednesday 18 May 2016 16:08:12, Mark Brown wrote:
> On Wed, May 18, 2016 at 03:41:29PM +0200, Alexander Stein wrote:
> > In case there is no DAI (yet), do not print an error, this might happen
> > a lot of times. Print a notice instead.
>
> This is changing *all* error reports which isn't OK.
Well, it's debatable if using dev_err() and then returning EPROBE_DEFER is
correct either. IMHO if there is an actual error, an error code has to be
returned and not "well, can't continue now, probe me again later".
At first glance those EPROBE_DEFER are correct as other dependent drivers may
be probed later, so printing an error in that case seems wrong to me.
Best regards,
Alexander
next prev parent reply other threads:[~2016-05-18 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 13:41 [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe Alexander Stein
2016-05-18 14:25 ` Ricard Wanderlof
2016-05-18 15:08 ` Mark Brown
2016-05-18 15:18 ` Alexander Stein [this message]
2016-05-18 15:28 ` Mark Brown
2016-05-18 15:50 ` Alexander Stein
2016-05-18 16:21 ` Mark Brown
2016-05-18 16:57 ` Takashi Iwai
2016-05-18 17:20 ` Mark Brown
2016-05-18 19:33 ` Takashi Iwai
2016-05-19 6:28 ` Alexander Stein
2016-05-19 6:53 ` Takashi Iwai
2016-05-19 10:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=209086304.1BTKYSBN0B@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.