All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Sylvain Lemieux <slemieux.tyco@gmail.com>
Cc: vz@mleia.com, linux-arm-kernel@lists.infradead.org,
	linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: lpc32xx: Set PWM_PIN_LEVEL bit in lpc32xx_pwm_disable
Date: Wed, 22 Jun 2016 14:32:22 +0200	[thread overview]
Message-ID: <20160622123222.GD26943@ulmo.ba.sec> (raw)
In-Reply-To: <1464982677-24883-1-git-send-email-slemieux.tyco@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On Fri, Jun 03, 2016 at 03:37:57PM -0400, Sylvain Lemieux wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
> 
> If the PWM_PIN_LEVEL bit is setup to 1 in the bootloader, when the kernel
> disable the PWM, the PWM output is always set as a logic 1.

I presume there's a reason why the bootloader set this bit to 1. Why do
you assume it's the right thing to clear it?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: lpc32xx: Set PWM_PIN_LEVEL bit in lpc32xx_pwm_disable
Date: Wed, 22 Jun 2016 14:32:22 +0200	[thread overview]
Message-ID: <20160622123222.GD26943@ulmo.ba.sec> (raw)
In-Reply-To: <1464982677-24883-1-git-send-email-slemieux.tyco@gmail.com>

On Fri, Jun 03, 2016 at 03:37:57PM -0400, Sylvain Lemieux wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
> 
> If the PWM_PIN_LEVEL bit is setup to 1 in the bootloader, when the kernel
> disable the PWM, the PWM output is always set as a logic 1.

I presume there's a reason why the bootloader set this bit to 1. Why do
you assume it's the right thing to clear it?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160622/6ba5f7b9/attachment.sig>

  parent reply	other threads:[~2016-06-22 12:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 19:37 [PATCH] pwm: lpc32xx: Set PWM_PIN_LEVEL bit in lpc32xx_pwm_disable Sylvain Lemieux
2016-06-03 19:37 ` Sylvain Lemieux
2016-06-21  2:11 ` Vladimir Zapolskiy
2016-06-21  2:11   ` Vladimir Zapolskiy
2016-06-21 12:39   ` Sylvain Lemieux
2016-06-21 12:39     ` Sylvain Lemieux
2016-06-21 21:57     ` Vladimir Zapolskiy
2016-06-21 21:57       ` Vladimir Zapolskiy
2016-06-22 12:32 ` Thierry Reding [this message]
2016-06-22 12:32   ` Thierry Reding
2016-06-22 13:26   ` Sylvain Lemieux
2016-06-22 13:26     ` Sylvain Lemieux
2016-06-22 14:36     ` Thierry Reding
2016-06-22 14:36       ` Thierry Reding
2016-06-22 15:10       ` Vladimir Zapolskiy
2016-06-22 15:10         ` Vladimir Zapolskiy
2016-06-22 15:30         ` Sylvain Lemieux
2016-06-22 15:30           ` Sylvain Lemieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622123222.GD26943@ulmo.ba.sec \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=slemieux.tyco@gmail.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.