From: Thierry Reding <thierry.reding@gmail.com>
To: Sylvain Lemieux <slemieux.tyco@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
vz@mleia.com
Subject: Re: [PATCH] pwm: lpc32xx: Set PWM_PIN_LEVEL bit in lpc32xx_pwm_disable
Date: Wed, 22 Jun 2016 16:36:50 +0200 [thread overview]
Message-ID: <20160622143650.GO26943@ulmo.ba.sec> (raw)
In-Reply-To: <1466601964.5316.19.camel@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 1612 bytes --]
On Wed, Jun 22, 2016 at 09:26:04AM -0400, Sylvain Lemieux wrote:
> Hi Thierry,
>
> On Wed, 2016-06-22 at 14:32 +0200, Thierry Reding wrote:
> > On Fri, Jun 03, 2016 at 03:37:57PM -0400, Sylvain Lemieux wrote:
> > > From: Sylvain Lemieux <slemieux@tycoint.com>
> > >
> > > If the PWM_PIN_LEVEL bit is setup to 1 in the bootloader, when the kernel
> > > disable the PWM, the PWM output is always set as a logic 1.
> >
> > I presume there's a reason why the bootloader set this bit to 1. Why do
> > you assume it's the right thing to clear it?
> >
> There is an alternative mode for the PWM output pin; using the
> PWM_PIN_LEVEL bit to control the PWM output (logical 0 or 1 on
> output) when the PWM is disable.
>
> In this case, the bootloader is using the PWM_PIN_LEVEL bit
> to control the PWM output (always 1) to enable the LCD; the
> application is using the PWM to control the intensity of the
> LCD output. When disabling the PWM, the line level should be
> setup to 0.
But doesn't that mean that if the pin is used in PWM mode there's never
a use-case for having it go high when disabled? Given that this is a PWM
driver I don't see how we'd ever be in the case where the alternate
setting makes sense.
> A version 2 of this patch will be send with support to select
> the alternate PWM disable level high from the device tree.
>
> For details, you can refer to:
> http://thread.gmane.org/gmane.linux.pwm/3882/focus=508758
Given the above I don't think we should add this new device tree
property until we encounter a setup where it's needed.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: lpc32xx: Set PWM_PIN_LEVEL bit in lpc32xx_pwm_disable
Date: Wed, 22 Jun 2016 16:36:50 +0200 [thread overview]
Message-ID: <20160622143650.GO26943@ulmo.ba.sec> (raw)
In-Reply-To: <1466601964.5316.19.camel@localhost>
On Wed, Jun 22, 2016 at 09:26:04AM -0400, Sylvain Lemieux wrote:
> Hi Thierry,
>
> On Wed, 2016-06-22 at 14:32 +0200, Thierry Reding wrote:
> > On Fri, Jun 03, 2016 at 03:37:57PM -0400, Sylvain Lemieux wrote:
> > > From: Sylvain Lemieux <slemieux@tycoint.com>
> > >
> > > If the PWM_PIN_LEVEL bit is setup to 1 in the bootloader, when the kernel
> > > disable the PWM, the PWM output is always set as a logic 1.
> >
> > I presume there's a reason why the bootloader set this bit to 1. Why do
> > you assume it's the right thing to clear it?
> >
> There is an alternative mode for the PWM output pin; using the
> PWM_PIN_LEVEL bit to control the PWM output (logical 0 or 1 on
> output) when the PWM is disable.
>
> In this case, the bootloader is using the PWM_PIN_LEVEL bit
> to control the PWM output (always 1) to enable the LCD; the
> application is using the PWM to control the intensity of the
> LCD output. When disabling the PWM, the line level should be
> setup to 0.
But doesn't that mean that if the pin is used in PWM mode there's never
a use-case for having it go high when disabled? Given that this is a PWM
driver I don't see how we'd ever be in the case where the alternate
setting makes sense.
> A version 2 of this patch will be send with support to select
> the alternate PWM disable level high from the device tree.
>
> For details, you can refer to:
> http://thread.gmane.org/gmane.linux.pwm/3882/focus=508758
Given the above I don't think we should add this new device tree
property until we encounter a setup where it's needed.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160622/de943625/attachment.sig>
next prev parent reply other threads:[~2016-06-22 14:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 19:37 [PATCH] pwm: lpc32xx: Set PWM_PIN_LEVEL bit in lpc32xx_pwm_disable Sylvain Lemieux
2016-06-03 19:37 ` Sylvain Lemieux
2016-06-21 2:11 ` Vladimir Zapolskiy
2016-06-21 2:11 ` Vladimir Zapolskiy
2016-06-21 12:39 ` Sylvain Lemieux
2016-06-21 12:39 ` Sylvain Lemieux
2016-06-21 21:57 ` Vladimir Zapolskiy
2016-06-21 21:57 ` Vladimir Zapolskiy
2016-06-22 12:32 ` Thierry Reding
2016-06-22 12:32 ` Thierry Reding
2016-06-22 13:26 ` Sylvain Lemieux
2016-06-22 13:26 ` Sylvain Lemieux
2016-06-22 14:36 ` Thierry Reding [this message]
2016-06-22 14:36 ` Thierry Reding
2016-06-22 15:10 ` Vladimir Zapolskiy
2016-06-22 15:10 ` Vladimir Zapolskiy
2016-06-22 15:30 ` Sylvain Lemieux
2016-06-22 15:30 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622143650.GO26943@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.