[PATCH v2] Staging: i4l: Return NULL instead of 0.

[PATCH v2] Staging: i4l: Return NULL instead of 0.

[Sandhya Bankar]

Return NULL instead of 0, if card with given driverId is not found.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v2:
* Correcting commit message
 drivers/staging/i4l/act2000/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
index 39a8940..6a6c911 100755
--- a/drivers/staging/i4l/act2000/module.c
+++ b/drivers/staging/i4l/act2000/module.c
@@ -499,7 +499,7 @@ act2000_findcard(int driverid)
 			return p;
 		p = p->next;
 	}
-	return (act2000_card *) 0;
+	return NULL;
 }
 
 /*
-- 
1.7.1

Re: [Outreachy kernel] [PATCH v2] Staging: i4l: Return NULL instead of 0.

[Julia Lawall]

On Sat, 17 Sep 2016, Sandhya Bankar wrote:

> Return NULL instead of 0, if card with given driverId is not found.

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> Changes in v2:
> * Correcting commit message
>  drivers/staging/i4l/act2000/module.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 39a8940..6a6c911 100755
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -499,7 +499,7 @@ act2000_findcard(int driverid)
>  			return p;
>  		p = p->next;
>  	}
> -	return (act2000_card *) 0;
> +	return NULL;
>  }
>
>  /*
> --
> 1.7.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917071702.GA16260%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] Staging: i4l: Return NULL instead of 0.

[Alison Schofield]

On Sat, Sep 17, 2016 at 12:47:02PM +0530, Sandhya Bankar wrote:
> Return NULL instead of 0, if card with given driverId is not found.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>

Sandhya, 

Not related to this patch specifically, but seems like most
of the function declarations are not in kernel preferred style.  They
put the function type on a separate line, before the function name.  
(Could be that someone's already cleaned this and I'm behind in my
email)

alison


> ---
> Changes in v2:
> * Correcting commit message
>  drivers/staging/i4l/act2000/module.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 39a8940..6a6c911 100755
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -499,7 +499,7 @@ act2000_findcard(int driverid)
>  			return p;
>  		p = p->next;
>  	}
> -	return (act2000_card *) 0;
> +	return NULL;
>  }
>  
>  /*
> -- 
> 1.7.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917071702.GA16260%40sandhya.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH v2] Staging: i4l: Return NULL instead of 0.

[Alison Schofield]

On Sat, Sep 17, 2016 at 12:47:02PM +0530, Sandhya Bankar wrote:
> Return NULL instead of 0, if card with given driverId is not found.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>

Greg, 

I was going to say something else here about there being a lot of
printk's that maybe could be converted, but then I looked at the TODO
file.

>>    * The icn, pcbit and act2000 drivers are dead, remove them in 2017
>>    after another longterm kernel has been released, just in the
>>    unlikely case someone still has this hardware.

Do you want work done on a driver that's on it's way out?

alisons


> ---
> Changes in v2:
> * Correcting commit message
>  drivers/staging/i4l/act2000/module.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 39a8940..6a6c911 100755
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -499,7 +499,7 @@ act2000_findcard(int driverid)
>  			return p;
>  		p = p->next;
>  	}
> -	return (act2000_card *) 0;
> +	return NULL;
>  }
>  
>  /*
> -- 
> 1.7.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917071702.GA16260%40sandhya.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH v2] Staging: i4l: Return NULL instead of 0.

[Greg KH]

On Sat, Sep 17, 2016 at 02:24:45PM -0700, Alison Schofield wrote:
> On Sat, Sep 17, 2016 at 12:47:02PM +0530, Sandhya Bankar wrote:
> > Return NULL instead of 0, if card with given driverId is not found.
> > 
> > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> 
> Greg, 
> 
> I was going to say something else here about there being a lot of
> printk's that maybe could be converted, but then I looked at the TODO
> file.
> 
> >>    * The icn, pcbit and act2000 drivers are dead, remove them in 2017
> >>    after another longterm kernel has been released, just in the
> >>    unlikely case someone still has this hardware.
> 
> Do you want work done on a driver that's on it's way out?

If people want to "practice" on such a driver, it is fine with me.

thanks,

greg k-h