From: Adam Manzanares <adam.manzanares@wdc.com>
To: Tejun Heo <tj@kernel.org>
Cc: Adam Manzanares <adam.manzanares@hgst.com>, <axboe@kernel.dk>,
<dan.j.williams@intel.com>, <hare@suse.de>,
<martin.petersen@oracle.com>, <mchristi@redhat.com>,
<toshi.kani@hpe.com>, <ming.lei@canonical.com>,
<sathya.prakash@broadcom.com>, <chaitra.basappa@broadcom.com>,
<suganath-prabu.subramani@broadcom.com>,
<linux-block@vger.kernel.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<MPT-FusionLinux.pdl@broadcom.com>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default
Date: Thu, 13 Oct 2016 16:37:43 -0700 [thread overview]
Message-ID: <20161013233742.GA5854@hgst.com> (raw)
In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org>
SGVsbG8gVGVqdW4sCgpUaGUgMTAvMTMvMjAxNiAxOToyMiwgVGVqdW4gSGVvIHdyb3RlOgo+IEhl
bGxvLCBBZGFtLgo+IAo+IFNvcnJ5IGFib3V0IGxhdGUgcmVwbHkuICBXYXMgb24gdmFjYXRpb24u
CgpOUCBJIHdhcyBvbiB2YWNhdGlvbiBhdCB0aGUgZW5kIG9mIHRoZSB3ZWVrIGxhc3Qgd2Vlay4K
Cj4gCj4gT24gVGh1LCBPY3QgMTMsIDIwMTYgYXQgMDQ6MDA6MzFQTSAtMDcwMCwgQWRhbSBNYW56
YW5hcmVzIHdyb3RlOgo+ID4gQWRkIGEgc3lzZnMgZW50cnkgdG8gdHVybiBvbiBwcmlvcml0eSBp
bmZvcm1hdGlvbiBiZWluZyBwYXNzZWQKPiA+IHRvIGEgQVRBIGRldmljZS4gQnkgZGVmYXVsdCB0
aGlzIGZlYXR1cmUgaXMgdHVybmVkIG9mZi4KPiA+IAo+ID4gVGhpcyBwYXRjaCBkZXBlbmRzIG9u
IGF0YTogRW5hYmxpbmcgQVRBIENvbW1hbmQgUHJpb3JpdGllcwo+IAo+IExvb2tzIGdlbmVyYWxs
eSBnb29kIGJ1dCBjYW4gd2UgcGxlYXNlIHVzZSBhIGRldmljZSBhdHRyaWJ1dGUgbmFtZQo+IHdo
aWNoIGlzIG1vcmUgc3BlY2lmaWMgLSBpZS4gZW5hYmxlX25jcV9wcmlvPwoKV2lsbCBkbywgSSds
bCBhbHNvIGRvdWJsZSBjaGVjayB0aGUgbmFtaW5nIHNjaGVtZSBvZiBmdW5jdGlvbnMgYW5kIHZh
cmlhYmxlcyAKYWxzby4gVGhlIGZ1bmN0aW9ucyB0aGF0IGNoZWNrIGlmIHRoZSBkZXZpY2UgaGFz
IHRoZSBuY3EgcHJpbyBjYXBhYmlsaXR5IG1pZ2h0CmJlIHRvbyBzaW1pbGFyIHRvIHRoZSBmdW5j
dGlvbiB0aGF0IGNoZWNrcyBpZiB0aGUgZGV2aWNlIGF0dHJpYnV0ZSBpcyAKZW5hYmxlZC4KCj4g
Cj4gVGhhbmtzLgo+IAo+IC0tIAo+IHRlanVuCgpUYWtlIGNhcmUsCkFkYW0KV2VzdGVybiBEaWdp
dGFsIENvcnBvcmF0aW9uIChhbmQgaXRzIHN1YnNpZGlhcmllcykgRS1tYWlsIENvbmZpZGVudGlh
bGl0eSBOb3RpY2UgJiBEaXNjbGFpbWVyOgoKVGhpcyBlLW1haWwgYW5kIGFueSBmaWxlcyB0cmFu
c21pdHRlZCB3aXRoIGl0IG1heSBjb250YWluIGNvbmZpZGVudGlhbCBvciBsZWdhbGx5IHByaXZp
bGVnZWQgaW5mb3JtYXRpb24gb2YgV0RDIGFuZC9vciBpdHMgYWZmaWxpYXRlcywgYW5kIGFyZSBp
bnRlbmRlZCBzb2xlbHkgZm9yIHRoZSB1c2Ugb2YgdGhlIGluZGl2aWR1YWwgb3IgZW50aXR5IHRv
IHdoaWNoIHRoZXkgYXJlIGFkZHJlc3NlZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJl
Y2lwaWVudCwgYW55IGRpc2Nsb3N1cmUsIGNvcHlpbmcsIGRpc3RyaWJ1dGlvbiBvciBhbnkgYWN0
aW9uIHRha2VuIG9yIG9taXR0ZWQgdG8gYmUgdGFrZW4gaW4gcmVsaWFuY2Ugb24gaXQsIGlzIHBy
b2hpYml0ZWQuIElmIHlvdSBoYXZlIHJlY2VpdmVkIHRoaXMgZS1tYWlsIGluIGVycm9yLCBwbGVh
c2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkgYW5kIGRlbGV0ZSB0aGUgZS1tYWlsIGlu
IGl0cyBlbnRpcmV0eSBmcm9tIHlvdXIgc3lzdGVtLgo=
WARNING: multiple messages have this Message-ID (diff)
From: Adam Manzanares <adam.manzanares@wdc.com>
To: Tejun Heo <tj@kernel.org>
Cc: Adam Manzanares <adam.manzanares@hgst.com>,
axboe@kernel.dk, dan.j.williams@intel.com, hare@suse.de,
martin.petersen@oracle.com, mchristi@redhat.com,
toshi.kani@hpe.com, ming.lei@canonical.com,
sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com,
suganath-prabu.subramani@broadcom.com,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default
Date: Thu, 13 Oct 2016 16:37:43 -0700 [thread overview]
Message-ID: <20161013233742.GA5854@hgst.com> (raw)
In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org>
Hello Tejun,
The 10/13/2016 19:22, Tejun Heo wrote:
> Hello, Adam.
>
> Sorry about late reply. Was on vacation.
NP I was on vacation at the end of the week last week.
>
> On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote:
> > Add a sysfs entry to turn on priority information being passed
> > to a ATA device. By default this feature is turned off.
> >
> > This patch depends on ata: Enabling ATA Command Priorities
>
> Looks generally good but can we please use a device attribute name
> which is more specific - ie. enable_ncq_prio?
Will do, I'll also double check the naming scheme of functions and variables
also. The functions that check if the device has the ncq prio capability might
be too similar to the function that checks if the device attribute is
enabled.
>
> Thanks.
>
> --
> tejun
Take care,
Adam
WARNING: multiple messages have this Message-ID (diff)
From: Adam Manzanares <adam.manzanares@wdc.com>
To: Tejun Heo <tj@kernel.org>
Cc: Adam Manzanares <adam.manzanares@hgst.com>, <axboe@kernel.dk>,
<dan.j.williams@intel.com>, <hare@suse.de>,
<martin.petersen@oracle.com>, <mchristi@redhat.com>,
<toshi.kani@hpe.com>, <ming.lei@canonical.com>,
<sathya.prakash@broadcom.com>, <chaitra.basappa@broadcom.com>,
<suganath-prabu.subramani@broadcom.com>,
<linux-block@vger.kernel.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<MPT-FusionLinux.pdl@broadcom.com>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default
Date: Thu, 13 Oct 2016 16:37:43 -0700 [thread overview]
Message-ID: <20161013233742.GA5854@hgst.com> (raw)
In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org>
Hello Tejun,
The 10/13/2016 19:22, Tejun Heo wrote:
> Hello, Adam.
>
> Sorry about late reply. Was on vacation.
NP I was on vacation at the end of the week last week.
>
> On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote:
> > Add a sysfs entry to turn on priority information being passed
> > to a ATA device. By default this feature is turned off.
> >
> > This patch depends on ata: Enabling ATA Command Priorities
>
> Looks generally good but can we please use a device attribute name
> which is more specific - ie. enable_ncq_prio?
Will do, I'll also double check the naming scheme of functions and variables
also. The functions that check if the device has the ncq prio capability might
be too similar to the function that checks if the device attribute is
enabled.
>
> Thanks.
>
> --
> tejun
Take care,
Adam
next prev parent reply other threads:[~2016-10-13 23:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 23:00 [PATCH v5 0/4] Enabling ATA Command Priorities Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` [PATCH v5 1/4] block: Add iocontext priority to request Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` [PATCH v5 2/4] fusion: remove iopriority handling Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:36 ` Shaun Tancheff
2016-10-13 23:36 ` Shaun Tancheff
2016-10-14 5:34 ` Christoph Hellwig
2016-10-14 18:08 ` Adam Manzanares
2016-10-14 18:08 ` Adam Manzanares
2016-10-14 18:08 ` Adam Manzanares
2016-10-13 23:00 ` [PATCH v5 3/4] ata: Enabling ATA Command Priorities Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:23 ` Tejun Heo
2016-10-13 23:00 ` [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:00 ` Adam Manzanares
2016-10-13 23:22 ` Tejun Heo
2016-10-13 23:37 ` Adam Manzanares [this message]
2016-10-13 23:37 ` Adam Manzanares
2016-10-13 23:37 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013233742.GA5854@hgst.com \
--to=adam.manzanares@wdc.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=adam.manzanares@hgst.com \
--cc=axboe@kernel.dk \
--cc=chaitra.basappa@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=ming.lei@canonical.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.