From: Lukasz Majewski <l.majewski@majess.pl>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Stefan Agner <stefan@agner.ch>,
thierry.reding@gmail.com, mark.rutland@arm.com,
linux-pwm@vger.kernel.org,
Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
kernel@pengutronix.de, fabio.estevam@nxp.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
Lothar Wassmann <LW@karo-electronics.de>
Subject: Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion
Date: Sun, 23 Oct 2016 08:40:27 +0200 [thread overview]
Message-ID: <20161023084027.4a2aae51@jawa> (raw)
In-Reply-To: <20161022140118.7a6cb583@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Hi Boris,
> >
> > Could you be more specific here?
> >
> > As I mentioned before, the problem is not with the lack of
> > "atomic" API.
>
> Below is a quick and dirty I made on top of this patch to show you how
> atomic update can be implemented in this driver.
Thank you for example patch.
I will implement the ->apply() callback and post patches very soon :-).
I had two issues with the ->apply() implementation:
- Do my work on top of this patch (https://lkml.org/lkml/2016/10/7/454
as you did) to avoid rewriting work already done.
- In the example ->apply() implementation for rockchip
(https://patchwork.kernel.org/patch/7228221/) the ->config() callback
was not removed when ->apply() was implemented. I was confused with
such approach, but as you explained in this mail, the solely ->apply()
is enough.
> It's not tested, and
> probably not working, but it should give you a better idea of what is
> expected.
Thanks for explanation,
Łukasz Majewski
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: l.majewski@majess.pl (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/6] pwm: imx: support output polarity inversion
Date: Sun, 23 Oct 2016 08:40:27 +0200 [thread overview]
Message-ID: <20161023084027.4a2aae51@jawa> (raw)
In-Reply-To: <20161022140118.7a6cb583@bbrezillon>
Hi Boris,
> >
> > Could you be more specific here?
> >
> > As I mentioned before, the problem is not with the lack of
> > "atomic" API.
>
> Below is a quick and dirty I made on top of this patch to show you how
> atomic update can be implemented in this driver.
Thank you for example patch.
I will implement the ->apply() callback and post patches very soon :-).
I had two issues with the ->apply() implementation:
- Do my work on top of this patch (https://lkml.org/lkml/2016/10/7/454
as you did) to avoid rewriting work already done.
- In the example ->apply() implementation for rockchip
(https://patchwork.kernel.org/patch/7228221/) the ->config() callback
was not removed when ->apply() was implemented. I was confused with
such approach, but as you explained in this mail, the solely ->apply()
is enough.
> It's not tested, and
> probably not working, but it should give you a better idea of what is
> expected.
Thanks for explanation,
?ukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161023/a40e15be/attachment.sig>
next prev parent reply other threads:[~2016-10-23 6:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:11 [PATCH v3 0/6] Support PWM polarity control Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` [PATCH v3 1/6] pwm: print error messages with pr_err() instead of pr_debug() Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` [PATCH v3 2/6] pwm: core: make the PWM_POLARITY flag in DTB optional Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` [PATCH v3 3/6] pwm: imx: support output polarity inversion Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-08 14:32 ` Lukasz Majewski
2016-10-08 14:32 ` Lukasz Majewski
2016-10-08 14:32 ` Lukasz Majewski
2016-10-10 21:01 ` Stefan Agner
2016-10-10 21:01 ` Stefan Agner
2016-10-12 22:15 ` Lukasz Majewski
2016-10-12 22:15 ` Lukasz Majewski
2016-10-12 22:15 ` Lukasz Majewski
2016-10-12 23:18 ` Stefan Agner
2016-10-12 23:18 ` Stefan Agner
2016-10-13 4:58 ` Lukasz Majewski
2016-10-13 4:58 ` Lukasz Majewski
2016-10-13 4:58 ` Lukasz Majewski
2016-10-20 8:30 ` Lukasz Majewski
2016-10-20 8:30 ` Lukasz Majewski
2016-10-20 22:46 ` Stefan Agner
2016-10-20 22:46 ` Stefan Agner
2016-10-21 21:49 ` Lukasz Majewski
2016-10-21 21:49 ` Lukasz Majewski
2016-10-21 21:49 ` Lukasz Majewski
2016-10-22 10:57 ` Boris Brezillon
2016-10-22 10:57 ` Boris Brezillon
2016-10-22 12:01 ` Boris Brezillon
2016-10-22 12:01 ` Boris Brezillon
2016-10-22 12:01 ` Boris Brezillon
2016-10-23 6:40 ` Lukasz Majewski [this message]
2016-10-23 6:40 ` Lukasz Majewski
[not found] ` <20161007151129.6043-4-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2016-10-10 17:10 ` Rob Herring
2016-10-10 17:10 ` Rob Herring
2016-10-10 17:10 ` Rob Herring
2016-10-22 10:33 ` Boris Brezillon
2016-10-22 10:33 ` Boris Brezillon
2016-10-22 10:33 ` Boris Brezillon
2016-10-07 15:11 ` [PATCH v3 4/6] arm: dts: imx7: Update #pwm-cells for PWM polarity control Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` [PATCH v3 5/6] arm: dts: imx7-colibri: Use pwm " Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` [PATCH v3 6/6] arm: dts: imx7-colibri: Use enable-gpios for BL_ON Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
2016-10-07 15:11 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023084027.4a2aae51@jawa \
--to=l.majewski@majess.pl \
--cc=LW@karo-electronics.de \
--cc=bhuvanchandra.dv@toradex.com \
--cc=boris.brezillon@free-electrons.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.