All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/16] drivers/fsi: Add crc4 helpers
Date: Wed, 7 Dec 2016 10:02:19 +0100	[thread overview]
Message-ID: <20161207090219.GA14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-2-git-send-email-christopher.lee.bostic@gmail.com>

On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> Add some helpers for the crc checks for the slave configuration table.
> This works 4-bits-at-a-time, using a simple table approach.
> 
> We will need this in the FSI core code, as well as any master
> implementations that need to calculate CRCs in software.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c   | 21 +++++++++++++++++++++
>  drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++
>  2 files changed, 42 insertions(+)

Why not just create lib/crc4.c with these functions, like the other crc
functions in the kernel?  Don't bury these in some random driver
subsystem please.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bostic <christopher.lee.bostic@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	benh@kernel.crashing.org, geert+renesas@glider.be,
	andrew@aj.id.au, linux-kernel@vger.kernel.org,
	mturquette@baylibre.com, linux@armlinux.org.uk,
	Chris Bostic <cbostic@us.ibm.com>,
	sre@kernel.org, robh+dt@kernel.org, Jeremy Kerr <jk@ozlabs.org>,
	alistair@popple.id.au, linux-arm-kernel@lists.infradead.org,
	joel@jms.id.au
Subject: Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers
Date: Wed, 7 Dec 2016 10:02:19 +0100	[thread overview]
Message-ID: <20161207090219.GA14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-2-git-send-email-christopher.lee.bostic@gmail.com>

On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> Add some helpers for the crc checks for the slave configuration table.
> This works 4-bits-at-a-time, using a simple table approach.
> 
> We will need this in the FSI core code, as well as any master
> implementations that need to calculate CRCs in software.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c   | 21 +++++++++++++++++++++
>  drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++
>  2 files changed, 42 insertions(+)

Why not just create lib/crc4.c with these functions, like the other crc
functions in the kernel?  Don't bury these in some random driver
subsystem please.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bostic <christopher.lee.bostic@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
	sre@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jeremy Kerr <jk@ozlabs.org>,
	joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
	alistair@popple.id.au, benh@kernel.crashing.org,
	Chris Bostic <cbostic@us.ibm.com>
Subject: Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers
Date: Wed, 7 Dec 2016 10:02:19 +0100	[thread overview]
Message-ID: <20161207090219.GA14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-2-git-send-email-christopher.lee.bostic@gmail.com>

On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> Add some helpers for the crc checks for the slave configuration table.
> This works 4-bits-at-a-time, using a simple table approach.
> 
> We will need this in the FSI core code, as well as any master
> implementations that need to calculate CRCs in software.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c   | 21 +++++++++++++++++++++
>  drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++
>  2 files changed, 42 insertions(+)

Why not just create lib/crc4.c with these functions, like the other crc
functions in the kernel?  Don't bury these in some random driver
subsystem please.

thanks,

greg k-h

  reply	other threads:[~2016-12-07  9:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  2:09 [PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic
2016-12-07  2:09 ` Chris Bostic
2016-12-07  2:09 ` Chris Bostic
2016-12-07  2:09 ` [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic
2016-12-07  2:09   ` Chris Bostic
2016-12-07  9:02   ` Greg KH [this message]
2016-12-07  9:02     ` Greg KH
2016-12-07  9:02     ` Greg KH
2016-12-07 23:33     ` Jeremy Kerr
2016-12-07 23:33       ` Jeremy Kerr
2016-12-08 19:43       ` Christopher Bostic
2016-12-08 19:43         ` Christopher Bostic
2016-12-08 19:43         ` Christopher Bostic
2016-12-07  2:09 ` [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic
2016-12-07  2:09   ` Chris Bostic
2016-12-07  2:09 ` [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic
2016-12-07  2:09   ` Chris Bostic
2016-12-07  2:09   ` Chris Bostic
2016-12-07  9:29   ` Greg KH
2016-12-07  9:29     ` Greg KH
2016-12-07  9:29     ` Greg KH
2016-12-07  2:09 ` [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic
2016-12-07  2:09   ` Chris Bostic
2016-12-07  2:09   ` Chris Bostic
2016-12-07  9:06 ` [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH
2016-12-07  9:06   ` Greg KH
2016-12-07  9:06   ` Greg KH
2016-12-08 22:49   ` Christopher Bostic
2016-12-08 22:49     ` Christopher Bostic
2016-12-08 22:49     ` Christopher Bostic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161207090219.GA14742@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.