From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/16] drivers/fsi: Add fsi master definition
Date: Wed, 7 Dec 2016 10:06:10 +0100 [thread overview]
Message-ID: <20161207090610.GB14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com>
On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
> drivers/fsi/fsi-core.c | 20 ++++++++++++++++++++
> drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 57 insertions(+)
> create mode 100644 drivers/fsi/fsi-master.h
>
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 3d55bd5..ce9428d 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -17,6 +17,26 @@
> #include <linux/fsi.h>
> #include <linux/module.h>
>
> +#include "fsi-master.h"
> +
> +static atomic_t master_idx = ATOMIC_INIT(-1);
You don't really want/need an atomic variable, please use the simple ida
interface instead.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Chris Bostic
<christopher.lee.bostic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Jeremy Kerr <jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
andrew-zrmu5oMJ5Fs@public.gmane.org,
alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
Chris Bostic <cbostic-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 04/16] drivers/fsi: Add fsi master definition
Date: Wed, 7 Dec 2016 10:06:10 +0100 [thread overview]
Message-ID: <20161207090610.GB14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-1-git-send-email-christopher.lee.bostic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
>
> Signed-off-by: Jeremy Kerr <jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Chris Bostic <cbostic-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/fsi/fsi-core.c | 20 ++++++++++++++++++++
> drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 57 insertions(+)
> create mode 100644 drivers/fsi/fsi-master.h
>
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 3d55bd5..ce9428d 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -17,6 +17,26 @@
> #include <linux/fsi.h>
> #include <linux/module.h>
>
> +#include "fsi-master.h"
> +
> +static atomic_t master_idx = ATOMIC_INIT(-1);
You don't really want/need an atomic variable, please use the simple ida
interface instead.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bostic <christopher.lee.bostic@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
sre@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jeremy Kerr <jk@ozlabs.org>,
joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
alistair@popple.id.au, benh@kernel.crashing.org,
Chris Bostic <cbostic@us.ibm.com>
Subject: Re: [PATCH 04/16] drivers/fsi: Add fsi master definition
Date: Wed, 7 Dec 2016 10:06:10 +0100 [thread overview]
Message-ID: <20161207090610.GB14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com>
On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
> drivers/fsi/fsi-core.c | 20 ++++++++++++++++++++
> drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 57 insertions(+)
> create mode 100644 drivers/fsi/fsi-master.h
>
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 3d55bd5..ce9428d 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -17,6 +17,26 @@
> #include <linux/fsi.h>
> #include <linux/module.h>
>
> +#include "fsi-master.h"
> +
> +static atomic_t master_idx = ATOMIC_INIT(-1);
You don't really want/need an atomic variable, please use the simple ida
interface instead.
thanks,
greg k-h
next prev parent reply other threads:[~2016-12-07 9:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 2:09 [PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 9:02 ` Greg KH
2016-12-07 9:02 ` Greg KH
2016-12-07 9:02 ` Greg KH
2016-12-07 23:33 ` Jeremy Kerr
2016-12-07 23:33 ` Jeremy Kerr
2016-12-08 19:43 ` Christopher Bostic
2016-12-08 19:43 ` Christopher Bostic
2016-12-08 19:43 ` Christopher Bostic
2016-12-07 2:09 ` [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 9:29 ` Greg KH
2016-12-07 9:29 ` Greg KH
2016-12-07 9:29 ` Greg KH
2016-12-07 2:09 ` [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 9:06 ` Greg KH [this message]
2016-12-07 9:06 ` [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH
2016-12-07 9:06 ` Greg KH
2016-12-08 22:49 ` Christopher Bostic
2016-12-08 22:49 ` Christopher Bostic
2016-12-08 22:49 ` Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207090610.GB14742@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.