From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions
Date: Wed, 7 Dec 2016 10:29:07 +0100 [thread overview]
Message-ID: <20161207092907.GC14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-4-git-send-email-christopher.lee.bostic@gmail.com>
On Tue, Dec 06, 2016 at 08:09:33PM -0600, Chris Bostic wrote:
> diff --git a/include/linux/fsi.h b/include/linux/fsi.h
> index efa55ba..66bce48 100644
> --- a/include/linux/fsi.h
> +++ b/include/linux/fsi.h
> @@ -27,6 +27,12 @@ struct fsi_device {
> uint32_t size;
> };
>
> +extern int fsi_device_read(struct fsi_device *dev, uint32_t addr,
> + void *val, size_t size);
> +extern int fsi_device_write(struct fsi_device *dev, uint32_t addr,
> + const void *val, size_t size);
> +extern int fsi_device_peek(struct fsi_device *dev, void *val);
> +
> struct fsi_device_id {
> u8 engine_type;
> u8 version;
> @@ -40,7 +46,6 @@ struct fsi_device_id {
> #define FSI_DEVICE_VERSIONED(t, v) \
> .engine_type = (t), .version = (v),
>
> -
> struct fsi_driver {
> struct device_driver drv;
> const struct fsi_device_id *id_table;
Strange whitespace change here :)
Not a real problem, I like the fact that you have broken this down into
very logical pieces making it much easier to review, thanks so much for
doing this.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bostic <christopher.lee.bostic@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
benh@kernel.crashing.org, geert+renesas@glider.be,
andrew@aj.id.au, linux-kernel@vger.kernel.org,
mturquette@baylibre.com, linux@armlinux.org.uk,
Chris Bostic <cbostic@us.ibm.com>,
sre@kernel.org, robh+dt@kernel.org, Jeremy Kerr <jk@ozlabs.org>,
alistair@popple.id.au, linux-arm-kernel@lists.infradead.org,
joel@jms.id.au
Subject: Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions
Date: Wed, 7 Dec 2016 10:29:07 +0100 [thread overview]
Message-ID: <20161207092907.GC14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-4-git-send-email-christopher.lee.bostic@gmail.com>
On Tue, Dec 06, 2016 at 08:09:33PM -0600, Chris Bostic wrote:
> diff --git a/include/linux/fsi.h b/include/linux/fsi.h
> index efa55ba..66bce48 100644
> --- a/include/linux/fsi.h
> +++ b/include/linux/fsi.h
> @@ -27,6 +27,12 @@ struct fsi_device {
> uint32_t size;
> };
>
> +extern int fsi_device_read(struct fsi_device *dev, uint32_t addr,
> + void *val, size_t size);
> +extern int fsi_device_write(struct fsi_device *dev, uint32_t addr,
> + const void *val, size_t size);
> +extern int fsi_device_peek(struct fsi_device *dev, void *val);
> +
> struct fsi_device_id {
> u8 engine_type;
> u8 version;
> @@ -40,7 +46,6 @@ struct fsi_device_id {
> #define FSI_DEVICE_VERSIONED(t, v) \
> .engine_type = (t), .version = (v),
>
> -
> struct fsi_driver {
> struct device_driver drv;
> const struct fsi_device_id *id_table;
Strange whitespace change here :)
Not a real problem, I like the fact that you have broken this down into
very logical pieces making it much easier to review, thanks so much for
doing this.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bostic <christopher.lee.bostic@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
sre@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jeremy Kerr <jk@ozlabs.org>,
joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
alistair@popple.id.au, benh@kernel.crashing.org,
Chris Bostic <cbostic@us.ibm.com>
Subject: Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions
Date: Wed, 7 Dec 2016 10:29:07 +0100 [thread overview]
Message-ID: <20161207092907.GC14742@kroah.com> (raw)
In-Reply-To: <1481076574-54711-4-git-send-email-christopher.lee.bostic@gmail.com>
On Tue, Dec 06, 2016 at 08:09:33PM -0600, Chris Bostic wrote:
> diff --git a/include/linux/fsi.h b/include/linux/fsi.h
> index efa55ba..66bce48 100644
> --- a/include/linux/fsi.h
> +++ b/include/linux/fsi.h
> @@ -27,6 +27,12 @@ struct fsi_device {
> uint32_t size;
> };
>
> +extern int fsi_device_read(struct fsi_device *dev, uint32_t addr,
> + void *val, size_t size);
> +extern int fsi_device_write(struct fsi_device *dev, uint32_t addr,
> + const void *val, size_t size);
> +extern int fsi_device_peek(struct fsi_device *dev, void *val);
> +
> struct fsi_device_id {
> u8 engine_type;
> u8 version;
> @@ -40,7 +46,6 @@ struct fsi_device_id {
> #define FSI_DEVICE_VERSIONED(t, v) \
> .engine_type = (t), .version = (v),
>
> -
> struct fsi_driver {
> struct device_driver drv;
> const struct fsi_device_id *id_table;
Strange whitespace change here :)
Not a real problem, I like the fact that you have broken this down into
very logical pieces making it much easier to review, thanks so much for
doing this.
greg k-h
next prev parent reply other threads:[~2016-12-07 9:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 2:09 [PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 9:02 ` Greg KH
2016-12-07 9:02 ` Greg KH
2016-12-07 9:02 ` Greg KH
2016-12-07 23:33 ` Jeremy Kerr
2016-12-07 23:33 ` Jeremy Kerr
2016-12-08 19:43 ` Christopher Bostic
2016-12-08 19:43 ` Christopher Bostic
2016-12-08 19:43 ` Christopher Bostic
2016-12-07 2:09 ` [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 9:29 ` Greg KH [this message]
2016-12-07 9:29 ` Greg KH
2016-12-07 9:29 ` Greg KH
2016-12-07 2:09 ` [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 2:09 ` Chris Bostic
2016-12-07 9:06 ` [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH
2016-12-07 9:06 ` Greg KH
2016-12-07 9:06 ` Greg KH
2016-12-08 22:49 ` Christopher Bostic
2016-12-08 22:49 ` Christopher Bostic
2016-12-08 22:49 ` Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207092907.GC14742@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.