* [linux-sunxi][PATCH 0/3] Enable SPDIF on the Mele I7 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper at gmail.com @ 2016-12-20 10:40 UTC (permalink / raw) To: linux-arm-kernel From: Marcus Cooper <codekipper@gmail.com> Hi All, here is the patch set required to enable SPDIF on the Mele I7 which is a A31 based TV-box. To get this working a fix has to be applied to the clock driver and this will be pushed seperately. For now the dtsi changes can be applied and when the clk change is merged then we can finialise this push by applying the I7 patch. BR, CK Marcus Cooper (3): ARM: dts: sun6i: Add SPDIF TX pin to the A31 ARM: dts: sun6i: Add the SPDIF block to the A31 ARM: dts: sun6i: Add SPDIF to the Mele I7 arch/arm/boot/dts/sun6i-a31-i7.dts | 24 ++++++++++++++++++++++++ arch/arm/boot/dts/sun6i-a31.dtsi | 19 +++++++++++++++++++ 2 files changed, 43 insertions(+) -- 2.11.0 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 0/3] Enable SPDIF on the Mele I7 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2016-12-20 10:40 UTC (permalink / raw) To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Hi All, here is the patch set required to enable SPDIF on the Mele I7 which is a A31 based TV-box. To get this working a fix has to be applied to the clock driver and this will be pushed seperately. For now the dtsi changes can be applied and when the clk change is merged then we can finialise this push by applying the I7 patch. BR, CK Marcus Cooper (3): ARM: dts: sun6i: Add SPDIF TX pin to the A31 ARM: dts: sun6i: Add the SPDIF block to the A31 ARM: dts: sun6i: Add SPDIF to the Mele I7 arch/arm/boot/dts/sun6i-a31-i7.dts | 24 ++++++++++++++++++++++++ arch/arm/boot/dts/sun6i-a31.dtsi | 19 +++++++++++++++++++ 2 files changed, 43 insertions(+) -- 2.11.0 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 1/3] ARM: dts: sun6i: Add SPDIF TX pin to the A31 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper at gmail.com @ 2016-12-20 10:40 UTC (permalink / raw) To: linux-arm-kernel From: Marcus Cooper <codekipper@gmail.com> Add the SPDIF TX pin to the A31 dtsi. Signed-off-by: Marcus Cooper <codekipper@gmail.com> --- arch/arm/boot/dts/sun6i-a31.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 20a0331ddfb5..7370ba6c9993 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -586,6 +586,11 @@ bias-pull-up; }; + spdif_pins_a: spdif at 0 { + pins = "PH28"; + function = "spdif"; + }; + uart0_pins_a: uart0 at 0 { pins = "PH20", "PH21"; function = "uart0"; -- 2.11.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/3] ARM: dts: sun6i: Add SPDIF TX pin to the A31 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2016-12-20 10:40 UTC (permalink / raw) To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Add the SPDIF TX pin to the A31 dtsi. Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/sun6i-a31.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 20a0331ddfb5..7370ba6c9993 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -586,6 +586,11 @@ bias-pull-up; }; + spdif_pins_a: spdif@0 { + pins = "PH28"; + function = "spdif"; + }; + uart0_pins_a: uart0@0 { pins = "PH20", "PH21"; function = "uart0"; -- 2.11.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 1/3] ARM: dts: sun6i: Add SPDIF TX pin to the A31 @ 2016-12-20 19:07 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2016-12-20 19:07 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 20, 2016 at 11:40:36AM +0100, codekipper at gmail.com wrote: > From: Marcus Cooper <codekipper@gmail.com> > > Add the SPDIF TX pin to the A31 dtsi. > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161220/804105e1/attachment.sig> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] ARM: dts: sun6i: Add SPDIF TX pin to the A31 @ 2016-12-20 19:07 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2016-12-20 19:07 UTC (permalink / raw) To: codekipper-Re5JQEeQqe8AvxtiuMwx3w Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 428 bytes --] On Tue, Dec 20, 2016 at 11:40:36AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Add the SPDIF TX pin to the A31 dtsi. > > Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper at gmail.com @ 2016-12-20 10:40 UTC (permalink / raw) To: linux-arm-kernel From: Marcus Cooper <codekipper@gmail.com> Add the SPDIF transceiver controller block to the A31 dtsi. Signed-off-by: Marcus Cooper <codekipper@gmail.com> --- arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 7370ba6c9993..559c53efa7e6 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -613,6 +613,20 @@ reg = <0x01c20ca0 0x20>; }; + spdif: spdif at 01c21000 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun6i-a31-spdif"; + reg = <0x01c21000 0x400>; + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; + resets = <&ccu RST_APB1_SPDIF>; + clock-names = "apb", "spdif"; + dmas = <&dma 2>, <&dma 2>; + dma-names = "rx", "tx"; + spdif-out = "disabled"; + status = "disabled"; + }; + lradc: lradc at 01c22800 { compatible = "allwinner,sun4i-a10-lradc-keys"; reg = <0x01c22800 0x100>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2016-12-20 10:40 UTC (permalink / raw) To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Add the SPDIF transceiver controller block to the A31 dtsi. Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 7370ba6c9993..559c53efa7e6 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -613,6 +613,20 @@ reg = <0x01c20ca0 0x20>; }; + spdif: spdif@01c21000 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun6i-a31-spdif"; + reg = <0x01c21000 0x400>; + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; + resets = <&ccu RST_APB1_SPDIF>; + clock-names = "apb", "spdif"; + dmas = <&dma 2>, <&dma 2>; + dma-names = "rx", "tx"; + spdif-out = "disabled"; + status = "disabled"; + }; + lradc: lradc@01c22800 { compatible = "allwinner,sun4i-a10-lradc-keys"; reg = <0x01c22800 0x100>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 14:07 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2016-12-20 14:07 UTC (permalink / raw) To: linux-arm-kernel Hi, On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper at gmail.com wrote: > From: Marcus Cooper <codekipper@gmail.com> > > Add the SPDIF transceiver controller block to the A31 dtsi. > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > index 7370ba6c9993..559c53efa7e6 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -613,6 +613,20 @@ > reg = <0x01c20ca0 0x20>; > }; > > + spdif: spdif at 01c21000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun6i-a31-spdif"; > + reg = <0x01c21000 0x400>; > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > + resets = <&ccu RST_APB1_SPDIF>; > + clock-names = "apb", "spdif"; > + dmas = <&dma 2>, <&dma 2>; > + dma-names = "rx", "tx"; > + spdif-out = "disabled"; That property isn't documented anywhere, and doesn't seem to be used in your driver either. On a separate topic, is the channel inversion bug also found on the A31? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161220/b0c1450a/attachment.sig> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 14:07 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2016-12-20 14:07 UTC (permalink / raw) To: codekipper-Re5JQEeQqe8AvxtiuMwx3w Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 1394 bytes --] Hi, On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Add the SPDIF transceiver controller block to the A31 dtsi. > > Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > index 7370ba6c9993..559c53efa7e6 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -613,6 +613,20 @@ > reg = <0x01c20ca0 0x20>; > }; > > + spdif: spdif@01c21000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun6i-a31-spdif"; > + reg = <0x01c21000 0x400>; > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > + resets = <&ccu RST_APB1_SPDIF>; > + clock-names = "apb", "spdif"; > + dmas = <&dma 2>, <&dma 2>; > + dma-names = "rx", "tx"; > + spdif-out = "disabled"; That property isn't documented anywhere, and doesn't seem to be used in your driver either. On a separate topic, is the channel inversion bug also found on the A31? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 2016-12-20 14:07 ` [PATCH " Maxime Ripard @ 2016-12-20 14:34 ` Code Kipper -1 siblings, 0 replies; 20+ messages in thread From: Code Kipper @ 2016-12-20 14:34 UTC (permalink / raw) To: linux-arm-kernel On 20 December 2016 at 15:07, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper at gmail.com wrote: >> From: Marcus Cooper <codekipper@gmail.com> >> >> Add the SPDIF transceiver controller block to the A31 dtsi. >> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> >> --- >> arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi >> index 7370ba6c9993..559c53efa7e6 100644 >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi >> @@ -613,6 +613,20 @@ >> reg = <0x01c20ca0 0x20>; >> }; >> >> + spdif: spdif at 01c21000 { >> + #sound-dai-cells = <0>; >> + compatible = "allwinner,sun6i-a31-spdif"; >> + reg = <0x01c21000 0x400>; >> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; >> + resets = <&ccu RST_APB1_SPDIF>; >> + clock-names = "apb", "spdif"; >> + dmas = <&dma 2>, <&dma 2>; >> + dma-names = "rx", "tx"; >> + spdif-out = "disabled"; > > That property isn't documented anywhere, and doesn't seem to be used > in your driver either. Ooops....do you want me to respin a new patch or will you do your magic with 'dd'? It fell through the cracks as it was cherry picked from my dev branch where I was at one time playing with spdif-in. This has pretty much been relegated to the bottom of my todo/finish list. > > On a separate topic, is the channel inversion bug also found on the > A31? I have seen this and I'm sure that was also on my A31 hardware but I've just fired her up and the speaker test worked as expected. I also repeated the test on my A10 device and didn't hear the issue. CK > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 14:34 ` Code Kipper 0 siblings, 0 replies; 20+ messages in thread From: Code Kipper @ 2016-12-20 14:34 UTC (permalink / raw) To: Maxime Ripard; +Cc: linux-arm-kernel, devicetree, linux-sunxi On 20 December 2016 at 15:07, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > Hi, > > On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> >> Add the SPDIF transceiver controller block to the A31 dtsi. >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi >> index 7370ba6c9993..559c53efa7e6 100644 >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi >> @@ -613,6 +613,20 @@ >> reg = <0x01c20ca0 0x20>; >> }; >> >> + spdif: spdif@01c21000 { >> + #sound-dai-cells = <0>; >> + compatible = "allwinner,sun6i-a31-spdif"; >> + reg = <0x01c21000 0x400>; >> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; >> + resets = <&ccu RST_APB1_SPDIF>; >> + clock-names = "apb", "spdif"; >> + dmas = <&dma 2>, <&dma 2>; >> + dma-names = "rx", "tx"; >> + spdif-out = "disabled"; > > That property isn't documented anywhere, and doesn't seem to be used > in your driver either. Ooops....do you want me to respin a new patch or will you do your magic with 'dd'? It fell through the cracks as it was cherry picked from my dev branch where I was at one time playing with spdif-in. This has pretty much been relegated to the bottom of my todo/finish list. > > On a separate topic, is the channel inversion bug also found on the > A31? I have seen this and I'm sure that was also on my A31 hardware but I've just fired her up and the speaker test worked as expected. I also repeated the test on my A10 device and didn't hear the issue. CK > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 19:11 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2016-12-20 19:11 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 20, 2016 at 03:34:10PM +0100, Code Kipper wrote: > On 20 December 2016 at 15:07, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi, > > > > On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper at gmail.com wrote: > >> From: Marcus Cooper <codekipper@gmail.com> > >> > >> Add the SPDIF transceiver controller block to the A31 dtsi. > >> > >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> > >> --- > >> arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > >> index 7370ba6c9993..559c53efa7e6 100644 > >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi > >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > >> @@ -613,6 +613,20 @@ > >> reg = <0x01c20ca0 0x20>; > >> }; > >> > >> + spdif: spdif at 01c21000 { > >> + #sound-dai-cells = <0>; > >> + compatible = "allwinner,sun6i-a31-spdif"; > >> + reg = <0x01c21000 0x400>; > >> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > >> + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > >> + resets = <&ccu RST_APB1_SPDIF>; > >> + clock-names = "apb", "spdif"; > >> + dmas = <&dma 2>, <&dma 2>; > >> + dma-names = "rx", "tx"; > >> + spdif-out = "disabled"; > > > > That property isn't documented anywhere, and doesn't seem to be used > > in your driver either. > > Ooops....do you want me to respin a new patch or will you do your > magic with 'dd'? Sorry, it's C-w for me :) > It fell through the cracks as it was cherry picked from my dev > branch where I was at one time playing with spdif-in. This has > pretty much been relegated to the bottom of my todo/finish list. I fixed and applied. > > On a separate topic, is the channel inversion bug also found on the > > A31? > > I have seen this and I'm sure that was also on my A31 hardware but > I've just fired her up and the speaker test worked as expected. I also > repeated the test on my A10 device and didn't hear the issue. Ok. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161220/20d095e5/attachment-0001.sig> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 @ 2016-12-20 19:11 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2016-12-20 19:11 UTC (permalink / raw) To: Code Kipper; +Cc: linux-arm-kernel, devicetree, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 2462 bytes --] On Tue, Dec 20, 2016 at 03:34:10PM +0100, Code Kipper wrote: > On 20 December 2016 at 15:07, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > Hi, > > > > On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> > >> Add the SPDIF transceiver controller block to the A31 dtsi. > >> > >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> --- > >> arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > >> index 7370ba6c9993..559c53efa7e6 100644 > >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi > >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > >> @@ -613,6 +613,20 @@ > >> reg = <0x01c20ca0 0x20>; > >> }; > >> > >> + spdif: spdif@01c21000 { > >> + #sound-dai-cells = <0>; > >> + compatible = "allwinner,sun6i-a31-spdif"; > >> + reg = <0x01c21000 0x400>; > >> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > >> + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > >> + resets = <&ccu RST_APB1_SPDIF>; > >> + clock-names = "apb", "spdif"; > >> + dmas = <&dma 2>, <&dma 2>; > >> + dma-names = "rx", "tx"; > >> + spdif-out = "disabled"; > > > > That property isn't documented anywhere, and doesn't seem to be used > > in your driver either. > > Ooops....do you want me to respin a new patch or will you do your > magic with 'dd'? Sorry, it's C-w for me :) > It fell through the cracks as it was cherry picked from my dev > branch where I was at one time playing with spdif-in. This has > pretty much been relegated to the bottom of my todo/finish list. I fixed and applied. > > On a separate topic, is the channel inversion bug also found on the > > A31? > > I have seen this and I'm sure that was also on my A31 hardware but > I've just fired her up and the speaker test worked as expected. I also > repeated the test on my A10 device and didn't hear the issue. Ok. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper at gmail.com @ 2016-12-20 10:40 UTC (permalink / raw) To: linux-arm-kernel From: Marcus Cooper <codekipper@gmail.com> Enable the S/PDIF transmitter that is present on the Mele I7. Signed-off-by: Marcus Cooper <codekipper@gmail.com> --- arch/arm/boot/dts/sun6i-a31-i7.dts | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31-i7.dts b/arch/arm/boot/dts/sun6i-a31-i7.dts index a2193309a199..2bc57d2dcd80 100644 --- a/arch/arm/boot/dts/sun6i-a31-i7.dts +++ b/arch/arm/boot/dts/sun6i-a31-i7.dts @@ -69,6 +69,23 @@ gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; }; }; + + sound { + compatible = "simple-audio-card"; + simple-audio-card,name = "On-board SPDIF"; + simple-audio-card,cpu { + sound-dai = <&spdif>; + }; + + simple-audio-card,codec { + sound-dai = <&spdif_out>; + }; + }; + + spdif_out: spdif-out { + #sound-dai-cells = <0>; + compatible = "linux,spdif-dit"; + }; }; &codec { @@ -138,6 +155,13 @@ status = "okay"; }; +&spdif { + pinctrl-names = "default"; + pinctrl-0 = <&spdif_pins_a>; + spdif-out = "okay"; + status = "okay"; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 @ 2016-12-20 10:40 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w 0 siblings, 0 replies; 20+ messages in thread From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2016-12-20 10:40 UTC (permalink / raw) To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Enable the S/PDIF transmitter that is present on the Mele I7. Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/sun6i-a31-i7.dts | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31-i7.dts b/arch/arm/boot/dts/sun6i-a31-i7.dts index a2193309a199..2bc57d2dcd80 100644 --- a/arch/arm/boot/dts/sun6i-a31-i7.dts +++ b/arch/arm/boot/dts/sun6i-a31-i7.dts @@ -69,6 +69,23 @@ gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; }; }; + + sound { + compatible = "simple-audio-card"; + simple-audio-card,name = "On-board SPDIF"; + simple-audio-card,cpu { + sound-dai = <&spdif>; + }; + + simple-audio-card,codec { + sound-dai = <&spdif_out>; + }; + }; + + spdif_out: spdif-out { + #sound-dai-cells = <0>; + compatible = "linux,spdif-dit"; + }; }; &codec { @@ -138,6 +155,13 @@ status = "okay"; }; +&spdif { + pinctrl-names = "default"; + pinctrl-0 = <&spdif_pins_a>; + spdif-out = "okay"; + status = "okay"; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 @ 2017-01-07 19:16 ` Chen-Yu Tsai 0 siblings, 0 replies; 20+ messages in thread From: Chen-Yu Tsai @ 2017-01-07 19:16 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 20, 2016 at 6:40 PM, <codekipper@gmail.com> wrote: > From: Marcus Cooper <codekipper@gmail.com> > > Enable the S/PDIF transmitter that is present on the Mele I7. > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> Acked-by: Chen-Yu Tsai <wens@csie.org> This patch should be ready to be merged. The associated clk and dtsi changes are already in Maxime's tree. > --- > arch/arm/boot/dts/sun6i-a31-i7.dts | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31-i7.dts b/arch/arm/boot/dts/sun6i-a31-i7.dts > index a2193309a199..2bc57d2dcd80 100644 > --- a/arch/arm/boot/dts/sun6i-a31-i7.dts > +++ b/arch/arm/boot/dts/sun6i-a31-i7.dts > @@ -69,6 +69,23 @@ > gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; > }; > }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "On-board SPDIF"; > + simple-audio-card,cpu { > + sound-dai = <&spdif>; > + }; > + > + simple-audio-card,codec { > + sound-dai = <&spdif_out>; > + }; > + }; > + > + spdif_out: spdif-out { > + #sound-dai-cells = <0>; > + compatible = "linux,spdif-dit"; > + }; > }; > > &codec { > @@ -138,6 +155,13 @@ > status = "okay"; > }; > > +&spdif { > + pinctrl-names = "default"; > + pinctrl-0 = <&spdif_pins_a>; > + spdif-out = "okay"; > + status = "okay"; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pins_a>; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe at googlegroups.com. > For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [linux-sunxi][PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 @ 2017-01-07 19:16 ` Chen-Yu Tsai 0 siblings, 0 replies; 20+ messages in thread From: Chen-Yu Tsai @ 2017-01-07 19:16 UTC (permalink / raw) To: Code Kipper; +Cc: Maxime Ripard, linux-arm-kernel, devicetree, linux-sunxi On Tue, Dec 20, 2016 at 6:40 PM, <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Enable the S/PDIF transmitter that is present on the Mele I7. > > Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> This patch should be ready to be merged. The associated clk and dtsi changes are already in Maxime's tree. > --- > arch/arm/boot/dts/sun6i-a31-i7.dts | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31-i7.dts b/arch/arm/boot/dts/sun6i-a31-i7.dts > index a2193309a199..2bc57d2dcd80 100644 > --- a/arch/arm/boot/dts/sun6i-a31-i7.dts > +++ b/arch/arm/boot/dts/sun6i-a31-i7.dts > @@ -69,6 +69,23 @@ > gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; > }; > }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "On-board SPDIF"; > + simple-audio-card,cpu { > + sound-dai = <&spdif>; > + }; > + > + simple-audio-card,codec { > + sound-dai = <&spdif_out>; > + }; > + }; > + > + spdif_out: spdif-out { > + #sound-dai-cells = <0>; > + compatible = "linux,spdif-dit"; > + }; > }; > > &codec { > @@ -138,6 +155,13 @@ > status = "okay"; > }; > > +&spdif { > + pinctrl-names = "default"; > + pinctrl-0 = <&spdif_pins_a>; > + spdif-out = "okay"; > + status = "okay"; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pins_a>; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 20+ messages in thread
* [linux-sunxi][PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 @ 2017-01-09 10:03 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2017-01-09 10:03 UTC (permalink / raw) To: linux-arm-kernel On Sun, Jan 08, 2017 at 03:16:22AM +0800, Chen-Yu Tsai wrote: > On Tue, Dec 20, 2016 at 6:40 PM, <codekipper@gmail.com> wrote: > > From: Marcus Cooper <codekipper@gmail.com> > > > > Enable the S/PDIF transmitter that is present on the Mele I7. > > > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > This patch should be ready to be merged. The associated clk > and dtsi changes are already in Maxime's tree. Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170109/c439d597/attachment.sig> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 @ 2017-01-09 10:03 ` Maxime Ripard 0 siblings, 0 replies; 20+ messages in thread From: Maxime Ripard @ 2017-01-09 10:03 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: Code Kipper, linux-arm-kernel, devicetree, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 696 bytes --] On Sun, Jan 08, 2017 at 03:16:22AM +0800, Chen-Yu Tsai wrote: > On Tue, Dec 20, 2016 at 6:40 PM, <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > > > Enable the S/PDIF transmitter that is present on the Mele I7. > > > > Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > > This patch should be ready to be merged. The associated clk > and dtsi changes are already in Maxime's tree. Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2017-01-09 10:03 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-20 10:40 [linux-sunxi][PATCH 0/3] Enable SPDIF on the Mele I7 codekipper at gmail.com 2016-12-20 10:40 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w 2016-12-20 10:40 ` [linux-sunxi][PATCH 1/3] ARM: dts: sun6i: Add SPDIF TX pin to the A31 codekipper at gmail.com 2016-12-20 10:40 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w 2016-12-20 19:07 ` [linux-sunxi][PATCH " Maxime Ripard 2016-12-20 19:07 ` [PATCH " Maxime Ripard 2016-12-20 10:40 ` [linux-sunxi][PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block " codekipper at gmail.com 2016-12-20 10:40 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w 2016-12-20 14:07 ` [linux-sunxi][PATCH " Maxime Ripard 2016-12-20 14:07 ` [PATCH " Maxime Ripard 2016-12-20 14:34 ` [linux-sunxi][PATCH " Code Kipper 2016-12-20 14:34 ` [PATCH " Code Kipper 2016-12-20 19:11 ` [linux-sunxi][PATCH " Maxime Ripard 2016-12-20 19:11 ` [PATCH " Maxime Ripard 2016-12-20 10:40 ` [linux-sunxi][PATCH 3/3] ARM: dts: sun6i: Add SPDIF to the Mele I7 codekipper at gmail.com 2016-12-20 10:40 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w 2017-01-07 19:16 ` [linux-sunxi][PATCH " Chen-Yu Tsai 2017-01-07 19:16 ` Chen-Yu Tsai 2017-01-09 10:03 ` Maxime Ripard 2017-01-09 10:03 ` [PATCH " Maxime Ripard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.