From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains
Date: Thu, 26 Jan 2017 17:57:13 +0000 [thread overview]
Message-ID: <20170126175712.GP14167@arm.com> (raw)
In-Reply-To: <20170126170329.GB27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On Thu, Jan 26, 2017 at 06:03:30PM +0100, Joerg Roedel wrote:
> On Thu, Jan 19, 2017 at 06:19:11PM +0000, Will Deacon wrote:
> > The ARM SMMU drivers provide a DOMAIN_ATTR_NESTING domain attribute,
> > which allows callers of the IOMMU API to request that the page table
> > for a domain is installed at stage-2, if supported by the hardware.
> >
> > Since setting this attribute only makes sense for UNMANAGED domains,
> > this patch returns -ENODEV if the domain_{get,set}_attr operations are
> > called on other domain types.
>
> Isn't -EINVAL more suitable here? In the end the domain passed in is
> invalid because it does not support attributes, no?
Sure, I can change that.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains
Date: Thu, 26 Jan 2017 17:57:13 +0000 [thread overview]
Message-ID: <20170126175712.GP14167@arm.com> (raw)
In-Reply-To: <20170126170329.GB27598@8bytes.org>
On Thu, Jan 26, 2017 at 06:03:30PM +0100, Joerg Roedel wrote:
> On Thu, Jan 19, 2017 at 06:19:11PM +0000, Will Deacon wrote:
> > The ARM SMMU drivers provide a DOMAIN_ATTR_NESTING domain attribute,
> > which allows callers of the IOMMU API to request that the page table
> > for a domain is installed at stage-2, if supported by the hardware.
> >
> > Since setting this attribute only makes sense for UNMANAGED domains,
> > this patch returns -ENODEV if the domain_{get,set}_attr operations are
> > called on other domain types.
>
> Isn't -EINVAL more suitable here? In the end the domain passed in is
> invalid because it does not support attributes, no?
Sure, I can change that.
Will
next prev parent reply other threads:[~2017-01-26 17:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:19 [PATCH 0/5] Implement SMMU passthrough using the default domain Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 18:19 ` [PATCH 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 18:41 ` Robin Murphy
2017-01-19 18:41 ` Robin Murphy
[not found] ` <89d795b9-a6d7-7f41-705c-b918ee66ebf0-5wv7dgnIgG8@public.gmane.org>
2017-01-26 17:06 ` Joerg Roedel
2017-01-26 17:06 ` Joerg Roedel
2017-01-26 17:03 ` Joerg Roedel
2017-01-26 17:03 ` Joerg Roedel
[not found] ` <20170126170329.GB27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-26 17:57 ` Will Deacon [this message]
2017-01-26 17:57 ` Will Deacon
2017-01-19 18:19 ` [PATCH 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-01-19 18:19 ` Will Deacon
2017-01-19 18:50 ` Robin Murphy
2017-01-19 18:50 ` Robin Murphy
2017-01-19 18:19 ` [PATCH 3/5] iommu/arm-smmu-v3: Install bypass STEs " Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-4-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 18:56 ` Robin Murphy
2017-01-19 18:56 ` Robin Murphy
2017-01-19 18:19 ` [PATCH 4/5] arm64: dma-mapping: Only swizzle DMA ops for IOMMU_DOMAIN_DMA Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-5-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 19:00 ` Robin Murphy
2017-01-19 19:00 ` Robin Murphy
2017-01-26 17:57 ` Will Deacon
2017-01-26 17:57 ` Will Deacon
2017-01-19 18:19 ` [PATCH 5/5] iommu: Allow default domain type to be set on the kernel command line Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-6-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-26 17:15 ` Joerg Roedel
2017-01-26 17:15 ` Joerg Roedel
[not found] ` <20170126171555.GD27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-26 17:26 ` Robin Murphy
2017-01-26 17:26 ` Robin Murphy
2017-01-26 17:48 ` Will Deacon
2017-01-26 17:48 ` Will Deacon
2017-01-24 15:12 ` [PATCH 0/5] Implement SMMU passthrough using the default domain Sricharan
2017-01-24 15:12 ` Sricharan
2017-01-26 17:18 ` Joerg Roedel
2017-01-26 17:18 ` Joerg Roedel
[not found] ` <20170126171857.GE27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-02-02 15:02 ` Rob Clark
2017-02-02 15:02 ` Rob Clark
[not found] ` <CAF6AEGtfrrwVZ_W86_HqVsiqfcM=XFa+g2LECFYQJmvv7-JSqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-02 15:12 ` Will Deacon
2017-02-02 15:12 ` Will Deacon
[not found] ` <20170202151241.GE13839-5wv7dgnIgG8@public.gmane.org>
2017-02-03 12:20 ` Rob Clark
2017-02-03 12:20 ` Rob Clark
2017-02-02 15:45 ` Sricharan
2017-02-02 15:45 ` Sricharan
2017-02-02 16:10 ` Will Deacon
2017-02-02 16:10 ` Will Deacon
[not found] ` <20170202161047.GG13839-5wv7dgnIgG8@public.gmane.org>
2017-02-03 16:33 ` Sricharan
2017-02-03 16:33 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126175712.GP14167@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.