From: Will Deacon <will.deacon@arm.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, joro@8bytes.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] arm64: dma-mapping: Only swizzle DMA ops for IOMMU_DOMAIN_DMA
Date: Thu, 26 Jan 2017 17:57:45 +0000 [thread overview]
Message-ID: <20170126175745.GQ14167@arm.com> (raw)
In-Reply-To: <91cf771f-af55-f66f-ea24-9582fc83f03a@arm.com>
On Thu, Jan 19, 2017 at 07:00:25PM +0000, Robin Murphy wrote:
> On 19/01/17 18:19, Will Deacon wrote:
> > The arm64 DMA-mapping implementation sets the DMA ops to the IOMMU DMA
> > ops if we detect that an IOMMU is present for the master and the DMA
> > ranges are valid.
> >
> > In the case when the IOMMU domain for the device is not of type
> > IOMMU_DOMAIN_DMA, then we have no business swizzling the ops, since
> > we're not in control of the underlying address space. This patch leaves
> > the DMA ops alone for masters attached to non-DMA IOMMU domains.
>
> In fact, I don't think there would be any harm in taking this one
> through arm64 straight away. The DMA ops can't be expected to work
> successfully on any old domain, so it's a reasonable sanity check
> regardless.
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Good point; I'll queue this one for 4.11 via arm64.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] arm64: dma-mapping: Only swizzle DMA ops for IOMMU_DOMAIN_DMA
Date: Thu, 26 Jan 2017 17:57:45 +0000 [thread overview]
Message-ID: <20170126175745.GQ14167@arm.com> (raw)
In-Reply-To: <91cf771f-af55-f66f-ea24-9582fc83f03a@arm.com>
On Thu, Jan 19, 2017 at 07:00:25PM +0000, Robin Murphy wrote:
> On 19/01/17 18:19, Will Deacon wrote:
> > The arm64 DMA-mapping implementation sets the DMA ops to the IOMMU DMA
> > ops if we detect that an IOMMU is present for the master and the DMA
> > ranges are valid.
> >
> > In the case when the IOMMU domain for the device is not of type
> > IOMMU_DOMAIN_DMA, then we have no business swizzling the ops, since
> > we're not in control of the underlying address space. This patch leaves
> > the DMA ops alone for masters attached to non-DMA IOMMU domains.
>
> In fact, I don't think there would be any harm in taking this one
> through arm64 straight away. The DMA ops can't be expected to work
> successfully on any old domain, so it's a reasonable sanity check
> regardless.
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Good point; I'll queue this one for 4.11 via arm64.
Will
next prev parent reply other threads:[~2017-01-26 17:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:19 [PATCH 0/5] Implement SMMU passthrough using the default domain Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 18:19 ` [PATCH 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 18:41 ` Robin Murphy
2017-01-19 18:41 ` Robin Murphy
[not found] ` <89d795b9-a6d7-7f41-705c-b918ee66ebf0-5wv7dgnIgG8@public.gmane.org>
2017-01-26 17:06 ` Joerg Roedel
2017-01-26 17:06 ` Joerg Roedel
2017-01-26 17:03 ` Joerg Roedel
2017-01-26 17:03 ` Joerg Roedel
[not found] ` <20170126170329.GB27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-26 17:57 ` Will Deacon
2017-01-26 17:57 ` Will Deacon
2017-01-19 18:19 ` [PATCH 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-01-19 18:19 ` Will Deacon
2017-01-19 18:50 ` Robin Murphy
2017-01-19 18:50 ` Robin Murphy
2017-01-19 18:19 ` [PATCH 3/5] iommu/arm-smmu-v3: Install bypass STEs " Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-4-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 18:56 ` Robin Murphy
2017-01-19 18:56 ` Robin Murphy
2017-01-19 18:19 ` [PATCH 4/5] arm64: dma-mapping: Only swizzle DMA ops for IOMMU_DOMAIN_DMA Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-5-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-19 19:00 ` Robin Murphy
2017-01-19 19:00 ` Robin Murphy
2017-01-26 17:57 ` Will Deacon [this message]
2017-01-26 17:57 ` Will Deacon
2017-01-19 18:19 ` [PATCH 5/5] iommu: Allow default domain type to be set on the kernel command line Will Deacon
2017-01-19 18:19 ` Will Deacon
[not found] ` <1484849955-1871-6-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-01-26 17:15 ` Joerg Roedel
2017-01-26 17:15 ` Joerg Roedel
[not found] ` <20170126171555.GD27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-26 17:26 ` Robin Murphy
2017-01-26 17:26 ` Robin Murphy
2017-01-26 17:48 ` Will Deacon
2017-01-26 17:48 ` Will Deacon
2017-01-24 15:12 ` [PATCH 0/5] Implement SMMU passthrough using the default domain Sricharan
2017-01-24 15:12 ` Sricharan
2017-01-26 17:18 ` Joerg Roedel
2017-01-26 17:18 ` Joerg Roedel
[not found] ` <20170126171857.GE27598-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-02-02 15:02 ` Rob Clark
2017-02-02 15:02 ` Rob Clark
[not found] ` <CAF6AEGtfrrwVZ_W86_HqVsiqfcM=XFa+g2LECFYQJmvv7-JSqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-02 15:12 ` Will Deacon
2017-02-02 15:12 ` Will Deacon
[not found] ` <20170202151241.GE13839-5wv7dgnIgG8@public.gmane.org>
2017-02-03 12:20 ` Rob Clark
2017-02-03 12:20 ` Rob Clark
2017-02-02 15:45 ` Sricharan
2017-02-02 15:45 ` Sricharan
2017-02-02 16:10 ` Will Deacon
2017-02-02 16:10 ` Will Deacon
[not found] ` <20170202161047.GG13839-5wv7dgnIgG8@public.gmane.org>
2017-02-03 16:33 ` Sricharan
2017-02-03 16:33 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126175745.GQ14167@arm.com \
--to=will.deacon@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.