All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/15] ARM: dts: imx6ul-isiot: Add Sound card with codec node
Date: Wed, 29 Mar 2017 11:27:36 +0800	[thread overview]
Message-ID: <20170329032733.GW30608@dragon> (raw)
In-Reply-To: <1490372330-5611-8-git-send-email-jagan@openedev.com>

On Fri, Mar 24, 2017 at 09:48:42PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> Add support for Sound card and related codec(via i2c1) nodes
> on Engicam Is.IoT MX6UL variant module boards.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

<snip>

> diff --git a/arch/arm/boot/dts/imx6ul-isiot.dtsi b/arch/arm/boot/dts/imx6ul-isiot.dtsi
> index ea30380..9648de9 100644
> --- a/arch/arm/boot/dts/imx6ul-isiot.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-isiot.dtsi
> @@ -69,6 +69,35 @@
>  				    100>;
>  		default-brightness-level = <100>;
>  	};
> +
> +	reg_1p8v: regulator-1p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "1P8V";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	reg_3p3v: regulator-3p3v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "3P3V";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	sound {
> +		compatible = "fsl,imx-audio-sgtl5000";
> +		model = "imx6ul-isiot-sgtl5000";
> +		cpu-dai = <&sai2>;
> +		audio-codec = <&sgtl5000>;
> +		audio-routing =
> +			"MIC_IN", "Mic Jack",
> +			"Mic Jack", "Mic Bias",
> +			"Headphone Jack", "HP_OUT";
> +	};

Can you consider to use simple-audio-card bindings instead?

Shawn

>  };
>  
>  &i2c1 {
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Jagan Teki <jagan@openedev.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Matteo Lisi <matteo.lisi@engicam.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH v2 07/15] ARM: dts: imx6ul-isiot: Add Sound card with codec node
Date: Wed, 29 Mar 2017 11:27:36 +0800	[thread overview]
Message-ID: <20170329032733.GW30608@dragon> (raw)
In-Reply-To: <1490372330-5611-8-git-send-email-jagan@openedev.com>

On Fri, Mar 24, 2017 at 09:48:42PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> Add support for Sound card and related codec(via i2c1) nodes
> on Engicam Is.IoT MX6UL variant module boards.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

<snip>

> diff --git a/arch/arm/boot/dts/imx6ul-isiot.dtsi b/arch/arm/boot/dts/imx6ul-isiot.dtsi
> index ea30380..9648de9 100644
> --- a/arch/arm/boot/dts/imx6ul-isiot.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-isiot.dtsi
> @@ -69,6 +69,35 @@
>  				    100>;
>  		default-brightness-level = <100>;
>  	};
> +
> +	reg_1p8v: regulator-1p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "1P8V";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	reg_3p3v: regulator-3p3v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "3P3V";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	sound {
> +		compatible = "fsl,imx-audio-sgtl5000";
> +		model = "imx6ul-isiot-sgtl5000";
> +		cpu-dai = <&sai2>;
> +		audio-codec = <&sgtl5000>;
> +		audio-routing =
> +			"MIC_IN", "Mic Jack",
> +			"Mic Jack", "Mic Bias",
> +			"Headphone Jack", "HP_OUT";
> +	};

Can you consider to use simple-audio-card bindings instead?

Shawn

>  };
>  
>  &i2c1 {
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-03-29  3:27 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 16:18 [PATCH v2 00/15] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 01/15] ARM: dts: imx6ul-geam: Add backlight support for lcdif Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 02/15] ARM: dts: imx6ul-isiot: " Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 03/15] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 04/15] ARM: dts: imx6ul-isiot: Add i2c nodes Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 05/15] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 06/15] ARM: dts: imx6ul-[geam|isiot]: Add sai2 node Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 07/15] ARM: dts: imx6ul-isiot: Add Sound card with codec node Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-29  3:27   ` Shawn Guo [this message]
2017-03-29  3:27     ` Shawn Guo
2017-03-24 16:18 ` [PATCH v2 08/15] ARM: dts: imx6ul-geam: " Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 09/15] ARM: dts: imx6qdl-icore: " Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 10/15] ARM: dts: imx6dl-icore-rqs: Add sgtl5000 " Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-29  3:29   ` Shawn Guo
2017-03-29  3:29     ` Shawn Guo
2017-03-29  3:29     ` Shawn Guo
2017-03-24 16:18 ` [PATCH v2 11/15] ARM: dts: imx6qdl-icore-rqs: Replace codec 'lable: node@addr' Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 12/15] ARM: dts: imx6dl-icore: Add LVDS support Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 13/15] ARM: dts: imx6dl-icore: Add touchscreen node Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 14/15] ARM: dts: imx6qdl-icore-rqs: Add CAN nodes Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 15/15] ARM: dts: imx6ul-isiot: Add FEC node support Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-24 16:18   ` Jagan Teki
2017-03-29  3:40 ` [PATCH v2 00/15] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Shawn Guo
2017-03-29  3:40   ` Shawn Guo
2017-03-29  3:40   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329032733.GW30608@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.