From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/15] ARM: dts: imx6dl-icore-rqs: Add sgtl5000 codec node
Date: Wed, 29 Mar 2017 11:29:12 +0800 [thread overview]
Message-ID: <20170329032910.GX30608@dragon> (raw)
In-Reply-To: <1490372330-5611-11-git-send-email-jagan@openedev.com>
On Fri, Mar 24, 2017 at 09:48:45PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> - Moved sound card node on imx6qdl-icore-rqs.dtsi
> - Added codec node in imx6dl-icore-rqs from imx6q-icore-rqs
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - Newly added patch
>
> arch/arm/boot/dts/imx6dl-icore-rqs.dts | 11 +++++++++++
> arch/arm/boot/dts/imx6q-icore-rqs.dts | 13 -------------
> arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 13 +++++++++++++
> 3 files changed, 24 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-icore-rqs.dts b/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> index cf42c2f..5b4c14c 100644
> --- a/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> +++ b/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> @@ -49,3 +49,14 @@
> model = "Engicam i.CoreM6 DualLite/Solo RQS Starter Kit";
> compatible = "engicam,imx6-icore-rqs", "fsl,imx6dl";
> };
> +
> +&i2c3 {
> + codec: sgtl5000 at 0a {
Why adding something that the following patch will change right away?
Shawn
> + compatible = "fsl,sgtl5000";
> + reg = <0x0a>;
> + clocks = <&clks IMX6QDL_CLK_CKO>;
> + VDDA-supply = <®_2p5v>;
> + VDDIO-supply = <®_3p3v>;
> + VDDD-supply = <®_1p8v>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/imx6q-icore-rqs.dts b/arch/arm/boot/dts/imx6q-icore-rqs.dts
> index e451b4c..441a28e5 100644
> --- a/arch/arm/boot/dts/imx6q-icore-rqs.dts
> +++ b/arch/arm/boot/dts/imx6q-icore-rqs.dts
> @@ -47,19 +47,6 @@
> / {
> model = "Engicam i.CoreM6 Quad/Dual RQS Starter Kit";
> compatible = "engicam,imx6-icore-rqs", "fsl,imx6q";
> -
> - sound {
> - compatible = "fsl,imx-audio-sgtl5000";
> - model = "imx-audio-sgtl5000";
> - ssi-controller = <&ssi1>;
> - audio-codec = <&codec>;
> - audio-routing =
> - "MIC_IN", "Mic Jack",
> - "Mic Jack", "Mic Bias",
> - "Headphone Jack", "HP_OUT";
> - mux-int-port = <1>;
> - mux-ext-port = <4>;
> - };
> };
>
> &i2c3 {
> diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> index 5fab5be..4032d38 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> @@ -118,6 +118,19 @@
> clocks = <&clks IMX6QDL_CLK_LVDS2_GATE>;
> clock-names = "refclk";
> };
> +
> + sound {
> + compatible = "fsl,imx-audio-sgtl5000";
> + model = "imx-audio-sgtl5000";
> + ssi-controller = <&ssi1>;
> + audio-codec = <&codec>;
> + audio-routing =
> + "MIC_IN", "Mic Jack",
> + "Mic Jack", "Mic Bias",
> + "Headphone Jack", "HP_OUT";
> + mux-int-port = <1>;
> + mux-ext-port = <4>;
> + };
> };
>
> &clks {
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jagan Teki <jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>,
Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
Jagan Teki
<jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH v2 10/15] ARM: dts: imx6dl-icore-rqs: Add sgtl5000 codec node
Date: Wed, 29 Mar 2017 11:29:12 +0800 [thread overview]
Message-ID: <20170329032910.GX30608@dragon> (raw)
In-Reply-To: <1490372330-5611-11-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
On Fri, Mar 24, 2017 at 09:48:45PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
>
> - Moved sound card node on imx6qdl-icore-rqs.dtsi
> - Added codec node in imx6dl-icore-rqs from imx6q-icore-rqs
>
> Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>
> Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> ---
> Changes for v2:
> - Newly added patch
>
> arch/arm/boot/dts/imx6dl-icore-rqs.dts | 11 +++++++++++
> arch/arm/boot/dts/imx6q-icore-rqs.dts | 13 -------------
> arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 13 +++++++++++++
> 3 files changed, 24 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-icore-rqs.dts b/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> index cf42c2f..5b4c14c 100644
> --- a/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> +++ b/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> @@ -49,3 +49,14 @@
> model = "Engicam i.CoreM6 DualLite/Solo RQS Starter Kit";
> compatible = "engicam,imx6-icore-rqs", "fsl,imx6dl";
> };
> +
> +&i2c3 {
> + codec: sgtl5000@0a {
Why adding something that the following patch will change right away?
Shawn
> + compatible = "fsl,sgtl5000";
> + reg = <0x0a>;
> + clocks = <&clks IMX6QDL_CLK_CKO>;
> + VDDA-supply = <®_2p5v>;
> + VDDIO-supply = <®_3p3v>;
> + VDDD-supply = <®_1p8v>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/imx6q-icore-rqs.dts b/arch/arm/boot/dts/imx6q-icore-rqs.dts
> index e451b4c..441a28e5 100644
> --- a/arch/arm/boot/dts/imx6q-icore-rqs.dts
> +++ b/arch/arm/boot/dts/imx6q-icore-rqs.dts
> @@ -47,19 +47,6 @@
> / {
> model = "Engicam i.CoreM6 Quad/Dual RQS Starter Kit";
> compatible = "engicam,imx6-icore-rqs", "fsl,imx6q";
> -
> - sound {
> - compatible = "fsl,imx-audio-sgtl5000";
> - model = "imx-audio-sgtl5000";
> - ssi-controller = <&ssi1>;
> - audio-codec = <&codec>;
> - audio-routing =
> - "MIC_IN", "Mic Jack",
> - "Mic Jack", "Mic Bias",
> - "Headphone Jack", "HP_OUT";
> - mux-int-port = <1>;
> - mux-ext-port = <4>;
> - };
> };
>
> &i2c3 {
> diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> index 5fab5be..4032d38 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> @@ -118,6 +118,19 @@
> clocks = <&clks IMX6QDL_CLK_LVDS2_GATE>;
> clock-names = "refclk";
> };
> +
> + sound {
> + compatible = "fsl,imx-audio-sgtl5000";
> + model = "imx-audio-sgtl5000";
> + ssi-controller = <&ssi1>;
> + audio-codec = <&codec>;
> + audio-routing =
> + "MIC_IN", "Mic Jack",
> + "Mic Jack", "Mic Bias",
> + "Headphone Jack", "HP_OUT";
> + mux-int-port = <1>;
> + mux-ext-port = <4>;
> + };
> };
>
> &clks {
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Jagan Teki <jagan@openedev.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH v2 10/15] ARM: dts: imx6dl-icore-rqs: Add sgtl5000 codec node
Date: Wed, 29 Mar 2017 11:29:12 +0800 [thread overview]
Message-ID: <20170329032910.GX30608@dragon> (raw)
In-Reply-To: <1490372330-5611-11-git-send-email-jagan@openedev.com>
On Fri, Mar 24, 2017 at 09:48:45PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> - Moved sound card node on imx6qdl-icore-rqs.dtsi
> - Added codec node in imx6dl-icore-rqs from imx6q-icore-rqs
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - Newly added patch
>
> arch/arm/boot/dts/imx6dl-icore-rqs.dts | 11 +++++++++++
> arch/arm/boot/dts/imx6q-icore-rqs.dts | 13 -------------
> arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 13 +++++++++++++
> 3 files changed, 24 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-icore-rqs.dts b/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> index cf42c2f..5b4c14c 100644
> --- a/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> +++ b/arch/arm/boot/dts/imx6dl-icore-rqs.dts
> @@ -49,3 +49,14 @@
> model = "Engicam i.CoreM6 DualLite/Solo RQS Starter Kit";
> compatible = "engicam,imx6-icore-rqs", "fsl,imx6dl";
> };
> +
> +&i2c3 {
> + codec: sgtl5000@0a {
Why adding something that the following patch will change right away?
Shawn
> + compatible = "fsl,sgtl5000";
> + reg = <0x0a>;
> + clocks = <&clks IMX6QDL_CLK_CKO>;
> + VDDA-supply = <®_2p5v>;
> + VDDIO-supply = <®_3p3v>;
> + VDDD-supply = <®_1p8v>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/imx6q-icore-rqs.dts b/arch/arm/boot/dts/imx6q-icore-rqs.dts
> index e451b4c..441a28e5 100644
> --- a/arch/arm/boot/dts/imx6q-icore-rqs.dts
> +++ b/arch/arm/boot/dts/imx6q-icore-rqs.dts
> @@ -47,19 +47,6 @@
> / {
> model = "Engicam i.CoreM6 Quad/Dual RQS Starter Kit";
> compatible = "engicam,imx6-icore-rqs", "fsl,imx6q";
> -
> - sound {
> - compatible = "fsl,imx-audio-sgtl5000";
> - model = "imx-audio-sgtl5000";
> - ssi-controller = <&ssi1>;
> - audio-codec = <&codec>;
> - audio-routing =
> - "MIC_IN", "Mic Jack",
> - "Mic Jack", "Mic Bias",
> - "Headphone Jack", "HP_OUT";
> - mux-int-port = <1>;
> - mux-ext-port = <4>;
> - };
> };
>
> &i2c3 {
> diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> index 5fab5be..4032d38 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> @@ -118,6 +118,19 @@
> clocks = <&clks IMX6QDL_CLK_LVDS2_GATE>;
> clock-names = "refclk";
> };
> +
> + sound {
> + compatible = "fsl,imx-audio-sgtl5000";
> + model = "imx-audio-sgtl5000";
> + ssi-controller = <&ssi1>;
> + audio-codec = <&codec>;
> + audio-routing =
> + "MIC_IN", "Mic Jack",
> + "Mic Jack", "Mic Bias",
> + "Headphone Jack", "HP_OUT";
> + mux-int-port = <1>;
> + mux-ext-port = <4>;
> + };
> };
>
> &clks {
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-03-29 3:29 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 16:18 [PATCH v2 00/15] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 01/15] ARM: dts: imx6ul-geam: Add backlight support for lcdif Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 02/15] ARM: dts: imx6ul-isiot: " Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 03/15] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 04/15] ARM: dts: imx6ul-isiot: Add i2c nodes Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 05/15] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 06/15] ARM: dts: imx6ul-[geam|isiot]: Add sai2 node Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 07/15] ARM: dts: imx6ul-isiot: Add Sound card with codec node Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-29 3:27 ` Shawn Guo
2017-03-29 3:27 ` Shawn Guo
2017-03-24 16:18 ` [PATCH v2 08/15] ARM: dts: imx6ul-geam: " Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 09/15] ARM: dts: imx6qdl-icore: " Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 10/15] ARM: dts: imx6dl-icore-rqs: Add sgtl5000 " Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-29 3:29 ` Shawn Guo [this message]
2017-03-29 3:29 ` Shawn Guo
2017-03-29 3:29 ` Shawn Guo
2017-03-24 16:18 ` [PATCH v2 11/15] ARM: dts: imx6qdl-icore-rqs: Replace codec 'lable: node@addr' Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 12/15] ARM: dts: imx6dl-icore: Add LVDS support Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 13/15] ARM: dts: imx6dl-icore: Add touchscreen node Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 14/15] ARM: dts: imx6qdl-icore-rqs: Add CAN nodes Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` [PATCH v2 15/15] ARM: dts: imx6ul-isiot: Add FEC node support Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-24 16:18 ` Jagan Teki
2017-03-29 3:40 ` [PATCH v2 00/15] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Shawn Guo
2017-03-29 3:40 ` Shawn Guo
2017-03-29 3:40 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329032910.GX30608@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.