All of lore.kernel.org
 help / color / mirror / Atom feed
From: ville.syrjala@linux.intel.com (Ville Syrjälä)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] drm/arm: hdlcd: check for rotation
Date: Fri, 31 Mar 2017 13:11:23 +0300	[thread overview]
Message-ID: <20170331101123.GK30290@intel.com> (raw)
In-Reply-To: <E1cttDk-00067G-1b@rmk-PC.armlinux.org.uk>

On Fri, Mar 31, 2017 at 10:51:52AM +0100, Russell King wrote:
> hdlcd does not support rotation - check for it and reject plane updates
> that try to rotate a plane.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/gpu/drm/arm/hdlcd_crtc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
> index cf70184fd028..171acc842368 100644
> --- a/drivers/gpu/drm/arm/hdlcd_crtc.c
> +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
> @@ -215,6 +215,10 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane,
>  	if (!crtc)
>  		return 0;
>  
> +	/* We do not support rotation */
> +	if (state->rotation != DRM_ROTATE_0)
> +		return -EINVAL;

This can't happen unless you attach a rotation property with a bogus
set of supported rotations to the plane.

> +
>  	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
>  	if (!crtc_state->enable)
>  		return -EINVAL;
> -- 
> 2.7.4

-- 
Ville Syrj?l?
Intel OTC

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
	DRI devel <dri-devel@lists.freedesktop.org>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] drm/arm: hdlcd: check for rotation
Date: Fri, 31 Mar 2017 13:11:23 +0300	[thread overview]
Message-ID: <20170331101123.GK30290@intel.com> (raw)
In-Reply-To: <E1cttDk-00067G-1b@rmk-PC.armlinux.org.uk>

On Fri, Mar 31, 2017 at 10:51:52AM +0100, Russell King wrote:
> hdlcd does not support rotation - check for it and reject plane updates
> that try to rotate a plane.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/gpu/drm/arm/hdlcd_crtc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
> index cf70184fd028..171acc842368 100644
> --- a/drivers/gpu/drm/arm/hdlcd_crtc.c
> +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
> @@ -215,6 +215,10 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane,
>  	if (!crtc)
>  		return 0;
>  
> +	/* We do not support rotation */
> +	if (state->rotation != DRM_ROTATE_0)
> +		return -EINVAL;

This can't happen unless you attach a rotation property with a bogus
set of supported rotations to the plane.

> +
>  	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
>  	if (!crtc_state->enable)
>  		return -EINVAL;
> -- 
> 2.7.4

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-03-31 10:11 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 23:37 [BUG] hdlcd gets confused about base address Russell King - ARM Linux
2016-11-18 23:37 ` Russell King - ARM Linux
2016-11-21  9:44 ` Daniel Vetter
2016-11-21  9:44   ` Daniel Vetter
2016-11-21 11:06 ` Liviu Dudau
2016-11-21 11:06   ` Liviu Dudau
2016-11-21 11:20   ` Russell King - ARM Linux
2016-11-21 11:20     ` Russell King - ARM Linux
2016-11-21 11:32     ` Liviu Dudau
2016-11-21 11:32       ` Liviu Dudau
2016-11-21 12:25       ` Russell King - ARM Linux
2016-11-21 12:25         ` Russell King - ARM Linux
2016-11-21 12:56         ` Liviu Dudau
2016-11-21 12:56           ` Liviu Dudau
2016-11-21 13:24           ` Russell King - ARM Linux
2016-11-21 13:24             ` Russell King - ARM Linux
2016-11-21 13:50             ` Liviu Dudau
2016-11-21 13:50               ` Liviu Dudau
2016-11-21 14:03               ` Russell King - ARM Linux
2016-11-21 14:03                 ` Russell King - ARM Linux
2016-11-21 17:32                 ` Liviu Dudau
2016-11-21 17:32                   ` Liviu Dudau
2016-11-21 17:56                   ` Russell King - ARM Linux
2016-11-21 17:56                     ` Russell King - ARM Linux
2016-11-21 18:16                     ` Russell King - ARM Linux
2016-11-21 18:16                       ` Russell King - ARM Linux
2016-11-21 18:25                       ` Liviu Dudau
2016-11-21 18:25                         ` Liviu Dudau
2016-11-21 18:23                     ` Liviu Dudau
2016-11-21 18:23                       ` Liviu Dudau
2016-11-21 18:43                       ` Russell King - ARM Linux
2016-11-21 18:43                         ` Russell King - ARM Linux
2016-11-21 14:30             ` Russell King - ARM Linux
2016-11-21 14:30               ` Russell King - ARM Linux
2016-11-21 14:55               ` Russell King - ARM Linux
2016-11-21 14:55                 ` Russell King - ARM Linux
2016-11-22  7:02                 ` Daniel Vetter
2016-11-22  7:02                   ` Daniel Vetter
2017-02-20 12:16 ` Russell King - ARM Linux
2017-02-20 12:16   ` Russell King - ARM Linux
2017-02-20 17:53   ` Liviu Dudau
2017-02-20 17:53     ` Liviu Dudau
2017-02-20 17:57     ` Russell King - ARM Linux
2017-02-20 17:57       ` Russell King - ARM Linux
2017-02-20 18:05     ` Ville Syrjälä
2017-02-20 18:05       ` Ville Syrjälä
2017-02-20 18:59       ` Russell King - ARM Linux
2017-02-20 18:59         ` Russell King - ARM Linux
2017-02-22 15:42         ` Ville Syrjälä
2017-02-22 15:42           ` Ville Syrjälä
2017-02-26 19:31           ` Daniel Vetter
2017-02-26 19:31             ` Daniel Vetter
2017-02-22 15:15       ` Liviu Dudau
2017-02-22 15:15         ` Liviu Dudau
2017-02-22 15:30         ` Ville Syrjälä
2017-02-22 15:30           ` Ville Syrjälä
2017-03-08 16:30           ` [PATCH v2] drm: hdlcd: Fix the calculation of the scanout start address Liviu Dudau
2017-03-08 16:30             ` Liviu Dudau
2017-03-31  9:49             ` Russell King - ARM Linux
2017-03-31  9:49               ` Russell King - ARM Linux
2017-03-31  9:51               ` [PATCH 1/3] drm/arm: hdlcd: properly validate plane state Russell King
2017-03-31  9:51                 ` Russell King
2017-03-31 10:18                 ` Liviu Dudau
2017-03-31 10:18                   ` Liviu Dudau
2017-03-31 10:20                   ` Russell King - ARM Linux
2017-03-31 10:20                     ` Russell King - ARM Linux
2017-03-31 10:23                     ` Liviu Dudau
2017-03-31 10:23                       ` Liviu Dudau
2017-03-31 10:27                       ` Russell King - ARM Linux
2017-03-31 10:27                         ` Russell King - ARM Linux
2017-03-31 11:41                         ` Liviu Dudau
2017-03-31 11:41                           ` Liviu Dudau
2017-03-31 12:21                           ` Russell King - ARM Linux
2017-03-31 12:21                             ` Russell King - ARM Linux
2017-03-31  9:51               ` [PATCH 2/3] drm/arm: hdlcd: fix plane base address calculation Russell King
2017-03-31  9:51                 ` Russell King
2017-03-31 13:13                 ` Liviu Dudau
2017-03-31 13:13                   ` Liviu Dudau
2017-03-31  9:51               ` [PATCH 3/3] drm/arm: hdlcd: check for rotation Russell King
2017-03-31  9:51                 ` Russell King
2017-03-31 10:11                 ` Ville Syrjälä [this message]
2017-03-31 10:11                   ` Ville Syrjälä
2017-03-31 10:21                   ` Liviu Dudau
2017-03-31 10:21                     ` Liviu Dudau
2017-03-31 13:18               ` [PATCH v2] drm: hdlcd: Fix the calculation of the scanout start address Liviu Dudau
2017-03-31 13:18                 ` Liviu Dudau
2017-03-31 13:48                 ` Russell King - ARM Linux
2017-03-31 13:48                   ` Russell King - ARM Linux
2017-04-03 10:31                   ` Liviu Dudau
2017-04-03 10:31                     ` Liviu Dudau
2017-04-03 13:13                     ` Russell King - ARM Linux
2017-04-03 13:13                       ` Russell King - ARM Linux
2017-04-03 14:07                       ` Liviu Dudau
2017-04-03 14:07                         ` Liviu Dudau
2017-04-06 11:07                       ` Jani Nikula
2017-04-06 11:07                         ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331101123.GK30290@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.