From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Peng Fan <peng.fan-3arQi8VN3Tc@public.gmane.org>,
joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] iommu: arm-smmu: correct sid to mask
Date: Mon, 24 Apr 2017 16:54:54 +0100 [thread overview]
Message-ID: <20170424155453.GP12323@arm.com> (raw)
In-Reply-To: <1492765416-30835-1-git-send-email-peng.fan-3arQi8VN3Tc@public.gmane.org>
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan-3arQi8VN3Tc@public.gmane.org>
> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> Cc: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Joerg: do you mind picking this one up, please?
Thanks,
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu: arm-smmu: correct sid to mask
Date: Mon, 24 Apr 2017 16:54:54 +0100 [thread overview]
Message-ID: <20170424155453.GP12323@arm.com> (raw)
In-Reply-To: <1492765416-30835-1-git-send-email-peng.fan@nxp.com>
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Joerg: do you mind picking this one up, please?
Thanks,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Peng Fan <peng.fan@nxp.com>, joro@8bytes.org
Cc: robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: arm-smmu: correct sid to mask
Date: Mon, 24 Apr 2017 16:54:54 +0100 [thread overview]
Message-ID: <20170424155453.GP12323@arm.com> (raw)
In-Reply-To: <1492765416-30835-1-git-send-email-peng.fan@nxp.com>
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Joerg: do you mind picking this one up, please?
Thanks,
Will
next prev parent reply other threads:[~2017-04-24 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 9:03 [PATCH] iommu: arm-smmu: correct sid to mask Peng Fan
2017-04-21 9:03 ` Peng Fan
2017-04-21 9:03 ` Peng Fan
[not found] ` <1492765416-30835-1-git-send-email-peng.fan-3arQi8VN3Tc@public.gmane.org>
2017-04-24 15:54 ` Will Deacon [this message]
2017-04-24 15:54 ` Will Deacon
2017-04-24 15:54 ` Will Deacon
[not found] ` <20170424155453.GP12323-5wv7dgnIgG8@public.gmane.org>
2017-04-25 12:26 ` Joerg Roedel
2017-04-25 12:26 ` Joerg Roedel
2017-04-25 12:26 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424155453.GP12323@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peng.fan-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.