* [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-21 9:03 ` Peng Fan
0 siblings, 0 replies; 9+ messages in thread
From: Peng Fan @ 2017-04-21 9:03 UTC (permalink / raw)
To: will.deacon; +Cc: robin.murphy, linux-arm-kernel, iommu, linux-kernel, Peng Fan
>From code "SMR mask 0x%x out of range for SMMU",
so, we need to use mask, not sid.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index b493c99..5a06de2 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
}
if (mask & ~smmu->smr_mask_mask) {
dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
- sid, smmu->smr_mask_mask);
+ mask, smmu->smr_mask_mask);
goto out_free;
}
}
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-21 9:03 ` Peng Fan
0 siblings, 0 replies; 9+ messages in thread
From: Peng Fan @ 2017-04-21 9:03 UTC (permalink / raw)
To: will.deacon; +Cc: robin.murphy, linux-arm-kernel, iommu, linux-kernel, Peng Fan
>From code "SMR mask 0x%x out of range for SMMU",
so, we need to use mask, not sid.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index b493c99..5a06de2 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
}
if (mask & ~smmu->smr_mask_mask) {
dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
- sid, smmu->smr_mask_mask);
+ mask, smmu->smr_mask_mask);
goto out_free;
}
}
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-21 9:03 ` Peng Fan
0 siblings, 0 replies; 9+ messages in thread
From: Peng Fan @ 2017-04-21 9:03 UTC (permalink / raw)
To: linux-arm-kernel
>From code "SMR mask 0x%x out of range for SMMU",
so, we need to use mask, not sid.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index b493c99..5a06de2 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
}
if (mask & ~smmu->smr_mask_mask) {
dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
- sid, smmu->smr_mask_mask);
+ mask, smmu->smr_mask_mask);
goto out_free;
}
}
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread[parent not found: <1492765416-30835-1-git-send-email-peng.fan-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH] iommu: arm-smmu: correct sid to mask
2017-04-21 9:03 ` Peng Fan
(?)
@ 2017-04-24 15:54 ` Will Deacon
-1 siblings, 0 replies; 9+ messages in thread
From: Will Deacon @ 2017-04-24 15:54 UTC (permalink / raw)
To: Peng Fan, joro-zLv9SwRftAIdnm+yROfE0A
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan-3arQi8VN3Tc@public.gmane.org>
> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> Cc: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Joerg: do you mind picking this one up, please?
Thanks,
Will
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-24 15:54 ` Will Deacon
0 siblings, 0 replies; 9+ messages in thread
From: Will Deacon @ 2017-04-24 15:54 UTC (permalink / raw)
To: Peng Fan, joro; +Cc: robin.murphy, linux-arm-kernel, iommu, linux-kernel
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Joerg: do you mind picking this one up, please?
Thanks,
Will
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-24 15:54 ` Will Deacon
0 siblings, 0 replies; 9+ messages in thread
From: Will Deacon @ 2017-04-24 15:54 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Joerg: do you mind picking this one up, please?
Thanks,
Will
^ permalink raw reply [flat|nested] 9+ messages in thread[parent not found: <20170424155453.GP12323-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] iommu: arm-smmu: correct sid to mask
2017-04-24 15:54 ` Will Deacon
(?)
@ 2017-04-25 12:26 ` Joerg Roedel
-1 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2017-04-25 12:26 UTC (permalink / raw)
To: Will Deacon
Cc: Peng Fan, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, Apr 24, 2017 at 04:54:54PM +0100, Will Deacon wrote:
> On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> > - sid, smmu->smr_mask_mask);
> > + mask, smmu->smr_mask_mask);
> > goto out_free;
>
> Looks like a copy-paste error to me:
>
> Acked-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
>
> Joerg: do you mind picking this one up, please?
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-25 12:26 ` Joerg Roedel
0 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2017-04-25 12:26 UTC (permalink / raw)
To: Will Deacon; +Cc: Peng Fan, robin.murphy, linux-arm-kernel, iommu, linux-kernel
On Mon, Apr 24, 2017 at 04:54:54PM +0100, Will Deacon wrote:
> On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> > - sid, smmu->smr_mask_mask);
> > + mask, smmu->smr_mask_mask);
> > goto out_free;
>
> Looks like a copy-paste error to me:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Joerg: do you mind picking this one up, please?
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] iommu: arm-smmu: correct sid to mask
@ 2017-04-25 12:26 ` Joerg Roedel
0 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2017-04-25 12:26 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 24, 2017 at 04:54:54PM +0100, Will Deacon wrote:
> On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> > - sid, smmu->smr_mask_mask);
> > + mask, smmu->smr_mask_mask);
> > goto out_free;
>
> Looks like a copy-paste error to me:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Joerg: do you mind picking this one up, please?
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-04-25 12:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-21 9:03 [PATCH] iommu: arm-smmu: correct sid to mask Peng Fan
2017-04-21 9:03 ` Peng Fan
2017-04-21 9:03 ` Peng Fan
[not found] ` <1492765416-30835-1-git-send-email-peng.fan-3arQi8VN3Tc@public.gmane.org>
2017-04-24 15:54 ` Will Deacon
2017-04-24 15:54 ` Will Deacon
2017-04-24 15:54 ` Will Deacon
[not found] ` <20170424155453.GP12323-5wv7dgnIgG8@public.gmane.org>
2017-04-25 12:26 ` Joerg Roedel
2017-04-25 12:26 ` Joerg Roedel
2017-04-25 12:26 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.