* [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-13 13:47 ` Colin King 0 siblings, 0 replies; 10+ messages in thread From: Colin King @ 2017-06-13 13:47 UTC (permalink / raw) To: Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it be static?" Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c index 8e669b6254ae..2f7b0e64f628 100644 --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, return true; } -bool cnl_ddi_dp_set_dpll_hw_state(int clock, - struct intel_dpll_hw_state *dpll_hw_state) +static bool +cnl_ddi_dp_set_dpll_hw_state(int clock, + struct intel_dpll_hw_state *dpll_hw_state) { uint32_t cfgcr0; -- 2.11.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-13 13:47 ` Colin King 0 siblings, 0 replies; 10+ messages in thread From: Colin King @ 2017-06-13 13:47 UTC (permalink / raw) To: Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it be static?" Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c index 8e669b6254ae..2f7b0e64f628 100644 --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, return true; } -bool cnl_ddi_dp_set_dpll_hw_state(int clock, - struct intel_dpll_hw_state *dpll_hw_state) +static bool +cnl_ddi_dp_set_dpll_hw_state(int clock, + struct intel_dpll_hw_state *dpll_hw_state) { uint32_t cfgcr0; -- 2.11.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-13 13:47 ` Colin King 0 siblings, 0 replies; 10+ messages in thread From: Colin King @ 2017-06-13 13:47 UTC (permalink / raw) To: Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it be static?" Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c index 8e669b6254ae..2f7b0e64f628 100644 --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, return true; } -bool cnl_ddi_dp_set_dpll_hw_state(int clock, - struct intel_dpll_hw_state *dpll_hw_state) +static bool +cnl_ddi_dp_set_dpll_hw_state(int clock, + struct intel_dpll_hw_state *dpll_hw_state) { uint32_t cfgcr0; -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static 2017-06-13 13:47 ` Colin King (?) (?) @ 2017-06-13 14:07 ` Patchwork -1 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2017-06-13 14:07 UTC (permalink / raw) To: Colin King; +Cc: intel-gfx == Series Details == Series: drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static URL : https://patchwork.freedesktop.org/series/25716/ State : success == Summary == Series 25716v1 drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static https://patchwork.freedesktop.org/api/1.0/series/25716/revisions/1/mbox/ Test gem_exec_suspend: Subgroup basic-s4-devices: dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125 +1 Test kms_busy: Subgroup basic-flip-default-b: dmesg-warn -> FAIL (fi-skl-6700hq) fdo#101144 fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125 fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144 fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:448s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:437s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:577s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:513s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:482s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:480s fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:582s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:431s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:413s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:420s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:484s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:470s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:467s fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:575s fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:575s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:459s fi-skl-6700hq total:278 pass:228 dwarn:1 dfail:0 fail:27 skip:22 time:408s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:479s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:475s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:438s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:534s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:401s 63f3be17429f13293c42de2c6e8ed6f0fc425145 drm-tip: 2017y-06m-13d-08h-33m-44s UTC integration manifest c1f1fc3 drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static == Logs == For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4941/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static 2017-06-13 13:47 ` Colin King (?) @ 2017-06-14 13:03 ` Tvrtko Ursulin -1 siblings, 0 replies; 10+ messages in thread From: Tvrtko Ursulin @ 2017-06-14 13:03 UTC (permalink / raw) To: Colin King, Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel On 13/06/2017 14:47, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 8e669b6254ae..2f7b0e64f628 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > return true; > } > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > - struct intel_dpll_hw_state *dpll_hw_state) > +static bool > +cnl_ddi_dp_set_dpll_hw_state(int clock, > + struct intel_dpll_hw_state *dpll_hw_state) > { > uint32_t cfgcr0; > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-14 13:03 ` Tvrtko Ursulin 0 siblings, 0 replies; 10+ messages in thread From: Tvrtko Ursulin @ 2017-06-14 13:03 UTC (permalink / raw) To: Colin King, Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel On 13/06/2017 14:47, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 8e669b6254ae..2f7b0e64f628 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > return true; > } > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > - struct intel_dpll_hw_state *dpll_hw_state) > +static bool > +cnl_ddi_dp_set_dpll_hw_state(int clock, > + struct intel_dpll_hw_state *dpll_hw_state) > { > uint32_t cfgcr0; > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-14 13:03 ` Tvrtko Ursulin 0 siblings, 0 replies; 10+ messages in thread From: Tvrtko Ursulin @ 2017-06-14 13:03 UTC (permalink / raw) To: Colin King, Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel On 13/06/2017 14:47, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 8e669b6254ae..2f7b0e64f628 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > return true; > } > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > - struct intel_dpll_hw_state *dpll_hw_state) > +static bool > +cnl_ddi_dp_set_dpll_hw_state(int clock, > + struct intel_dpll_hw_state *dpll_hw_state) > { > uint32_t cfgcr0; > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static 2017-06-14 13:03 ` Tvrtko Ursulin (?) @ 2017-06-15 13:16 ` Ville Syrjälä -1 siblings, 0 replies; 10+ messages in thread From: Ville Syrjälä @ 2017-06-15 13:16 UTC (permalink / raw) To: Tvrtko Ursulin Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel, Daniel Vetter, Colin King On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote: > > On 13/06/2017 14:47, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > > scope, so make it static. > > > > Cleans up sparse warning: > > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > > be static?" > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > index 8e669b6254ae..2f7b0e64f628 100644 > > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > > return true; > > } > > > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > > - struct intel_dpll_hw_state *dpll_hw_state) > > +static bool > > +cnl_ddi_dp_set_dpll_hw_state(int clock, > > + struct intel_dpll_hw_state *dpll_hw_state) > > { > > uint32_t cfgcr0; > > > > > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks for the patch and review. Pushed to dinq. -- Ville Syrjälä Intel OTC -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-15 13:16 ` Ville Syrjälä 0 siblings, 0 replies; 10+ messages in thread From: Ville Syrjälä @ 2017-06-15 13:16 UTC (permalink / raw) To: Tvrtko Ursulin Cc: Colin King, Daniel Vetter, Jani Nikula, David Airlie, intel-gfx, dri-devel, kernel-janitors, linux-kernel On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote: > > On 13/06/2017 14:47, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > > scope, so make it static. > > > > Cleans up sparse warning: > > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > > be static?" > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > index 8e669b6254ae..2f7b0e64f628 100644 > > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > > return true; > > } > > > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > > - struct intel_dpll_hw_state *dpll_hw_state) > > +static bool > > +cnl_ddi_dp_set_dpll_hw_state(int clock, > > + struct intel_dpll_hw_state *dpll_hw_state) > > { > > uint32_t cfgcr0; > > > > > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks for the patch and review. Pushed to dinq. -- Ville Syrjälä Intel OTC ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static @ 2017-06-15 13:16 ` Ville Syrjälä 0 siblings, 0 replies; 10+ messages in thread From: Ville Syrjälä @ 2017-06-15 13:16 UTC (permalink / raw) To: Tvrtko Ursulin Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel, Daniel Vetter, Colin King On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote: > > On 13/06/2017 14:47, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > > scope, so make it static. > > > > Cleans up sparse warning: > > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > > be static?" > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > index 8e669b6254ae..2f7b0e64f628 100644 > > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > > return true; > > } > > > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > > - struct intel_dpll_hw_state *dpll_hw_state) > > +static bool > > +cnl_ddi_dp_set_dpll_hw_state(int clock, > > + struct intel_dpll_hw_state *dpll_hw_state) > > { > > uint32_t cfgcr0; > > > > > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks for the patch and review. Pushed to dinq. -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-06-15 13:16 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-13 13:47 [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Colin King 2017-06-13 13:47 ` Colin King 2017-06-13 13:47 ` Colin King 2017-06-13 14:07 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-06-14 13:03 ` [Intel-gfx] [PATCH][drm-next] " Tvrtko Ursulin 2017-06-14 13:03 ` Tvrtko Ursulin 2017-06-14 13:03 ` Tvrtko Ursulin 2017-06-15 13:16 ` [Intel-gfx] " Ville Syrjälä 2017-06-15 13:16 ` Ville Syrjälä 2017-06-15 13:16 ` Ville Syrjälä
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.