From: Stephen Boyd <sboyd@codeaurora.org>
To: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>,
Orson Zhai <orson.zhai@spreadtrum.com>,
Geng Ren <geng.ren@spreadtrum.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH V1 0/9] add clock driver for Spreadtrum platforms
Date: Mon, 19 Jun 2017 18:25:30 -0700 [thread overview]
Message-ID: <20170620012530.GG4493@codeaurora.org> (raw)
In-Reply-To: <20170618015855.27738-1-chunyan.zhang@spreadtrum.com>
On 06/18, Chunyan Zhang wrote:
> In the last cycle, the patches support Whale2 sc9860 mobile chip have been
> merged. This patchset adds clock driver which is used on almost all
> Spreadtrum SoCs.
>
> This is a rewrite of Spreadtrum's original clock driver[1] according to the
> comments[2] from Stephen Boyd.
>
> This series also adds Spreadtrum clock binding documentation and devicetree
> data.
>
> Any comments would be greatly appreciated.
Overall it seems to copy quite a bit of code from sunxi-ng, which
is OK, but if that's just copy/paste + replace some names then
perhaps we should consolidate the two implementations into one
that both SoCs can use.
Also, is there any reason why we can't use a platform device
driver for this instead of the DT probing mechanism? That is more
preferred method of probing clk controllers.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V1 0/9] add clock driver for Spreadtrum platforms
Date: Mon, 19 Jun 2017 18:25:30 -0700 [thread overview]
Message-ID: <20170620012530.GG4493@codeaurora.org> (raw)
In-Reply-To: <20170618015855.27738-1-chunyan.zhang@spreadtrum.com>
On 06/18, Chunyan Zhang wrote:
> In the last cycle, the patches support Whale2 sc9860 mobile chip have been
> merged. This patchset adds clock driver which is used on almost all
> Spreadtrum SoCs.
>
> This is a rewrite of Spreadtrum's original clock driver[1] according to the
> comments[2] from Stephen Boyd.
>
> This series also adds Spreadtrum clock binding documentation and devicetree
> data.
>
> Any comments would be greatly appreciated.
Overall it seems to copy quite a bit of code from sunxi-ng, which
is OK, but if that's just copy/paste + replace some names then
perhaps we should consolidate the two implementations into one
that both SoCs can use.
Also, is there any reason why we can't use a platform device
driver for this instead of the DT probing mechanism? That is more
preferred method of probing clk controllers.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-20 1:25 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 1:58 [PATCH V1 0/9] add clock driver for Spreadtrum platforms Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` [PATCH V1 1/9] dt-bindings: Add Spreadtrum CCU binding documentation Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-23 20:05 ` Rob Herring
2017-06-23 20:05 ` Rob Herring
2017-06-18 1:58 ` [PATCH V1 2/9] clk: sprd: Add common infrastructure Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-20 1:29 ` Stephen Boyd
2017-06-20 1:29 ` Stephen Boyd
2017-06-22 10:12 ` Chunyan Zhang
2017-06-22 10:12 ` Chunyan Zhang
2017-06-18 1:58 ` [PATCH V1 3/9] clk: sprd: add gate clock support Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-20 1:31 ` Stephen Boyd
2017-06-20 1:31 ` Stephen Boyd
2017-06-20 1:31 ` Stephen Boyd
2017-06-22 10:16 ` Chunyan Zhang
2017-06-22 10:16 ` Chunyan Zhang
2017-06-30 1:43 ` Stephen Boyd
2017-06-30 1:43 ` Stephen Boyd
2017-06-30 1:43 ` Stephen Boyd
2017-06-18 1:58 ` [PATCH V1 4/9] clk: sprd: add mux " Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` [PATCH V1 5/9] clk: sprd: add divider " Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` [PATCH V1 6/9] clk: sprd: add composite " Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-19 0:13 ` kbuild test robot
2017-06-19 0:13 ` kbuild test robot
2017-06-19 0:13 ` kbuild test robot
2017-06-18 1:58 ` [PATCH V1 7/9] clk: sprd: add adjustable pll support Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-20 1:37 ` Stephen Boyd
2017-06-20 1:37 ` Stephen Boyd
2017-06-22 10:17 ` Chunyan Zhang
2017-06-22 10:17 ` Chunyan Zhang
2017-06-22 10:17 ` Chunyan Zhang
2017-06-22 11:15 ` Arnd Bergmann
2017-06-22 11:15 ` Arnd Bergmann
2017-06-22 12:06 ` Chunyan Zhang
2017-06-22 12:06 ` Chunyan Zhang
2017-06-30 1:44 ` Stephen Boyd
2017-06-30 1:44 ` Stephen Boyd
2017-06-30 1:44 ` Stephen Boyd
2017-06-30 7:55 ` Chunyan Zhang
2017-06-30 7:55 ` Chunyan Zhang
2017-06-30 19:22 ` Stephen Boyd
2017-06-30 19:22 ` Stephen Boyd
2017-07-03 7:41 ` Chunyan Zhang
2017-07-03 7:41 ` Chunyan Zhang
2017-07-03 7:41 ` Chunyan Zhang
2017-06-18 1:58 ` [PATCH V1 8/9] clk: sprd: add clocks support for SC9860 Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-20 1:41 ` Stephen Boyd
2017-06-20 1:41 ` Stephen Boyd
2017-06-20 1:41 ` Stephen Boyd
2017-06-22 10:21 ` Chunyan Zhang
2017-06-22 10:21 ` Chunyan Zhang
2017-06-30 1:41 ` Stephen Boyd
2017-06-30 1:41 ` Stephen Boyd
2017-06-30 1:41 ` Stephen Boyd
2017-06-18 1:58 ` [PATCH V1 9/9] arm64: dts: add ccu " Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-18 1:58 ` Chunyan Zhang
2017-06-20 1:24 ` Stephen Boyd
2017-06-20 1:24 ` Stephen Boyd
2017-06-22 10:24 ` Chunyan Zhang
2017-06-22 10:24 ` Chunyan Zhang
2017-06-22 10:24 ` Chunyan Zhang
2017-06-30 0:57 ` Stephen Boyd
2017-06-30 0:57 ` Stephen Boyd
2017-06-30 7:37 ` Chunyan Zhang
2017-06-30 7:37 ` Chunyan Zhang
2017-06-20 1:25 ` Stephen Boyd [this message]
2017-06-20 1:25 ` [PATCH V1 0/9] add clock driver for Spreadtrum platforms Stephen Boyd
2017-06-22 10:07 ` Chunyan Zhang
2017-06-22 10:07 ` Chunyan Zhang
2017-06-30 0:45 ` Stephen Boyd
2017-06-30 0:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620012530.GG4493@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chunyan.zhang@spreadtrum.com \
--cc=devicetree@vger.kernel.org \
--cc=geng.ren@spreadtrum.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=orson.zhai@spreadtrum.com \
--cc=robh+dt@kernel.org \
--cc=xiaolong.zhang@spreadtrum.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.