All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	Dave Chinner <david@fromorbit.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-mm <linux-mm@kvack.org>, kernel-team <kernel-team@lge.com>,
	seungho1.park@lge.com, "karam . lee" <karam.lee@lge.com>
Subject: Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability
Date: Mon, 14 Aug 2017 17:48:37 +0900	[thread overview]
Message-ID: <20170814084837.GF26913@bbox> (raw)
In-Reply-To: <20170811104615.GA14397@lst.de>

Hi Christoph,

On Fri, Aug 11, 2017 at 12:46:15PM +0200, Christoph Hellwig wrote:
> On Wed, Aug 09, 2017 at 08:06:24PM -0700, Dan Williams wrote:
> > I like it, but do you think we should switch to sbvec[<constant>] to
> > preclude pathological cases where nr_pages is large?
> 
> Yes, please.

Still, I don't understand how sbvec[nr_pages] with on-stack bio in
do_mpage_readpage can help the performance.

IIUC, do_mpage_readpage works with page-base. IOW, it passes just one
page, not multiple pages so if we use on-stack bio, we just add *a page*
via bio_add_page and submit the bio before the function returning.

So, rather than sbvec[1], why de we need sbvec[nr_pages]?

Please, let me open my eyes. :)

Thanks.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	"karam . lee" <karam.lee@lge.com>,
	seungho1.park@lge.com, Dave Chinner <david@fromorbit.com>,
	Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	kernel-team <kernel-team@lge.com>
Subject: Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability
Date: Mon, 14 Aug 2017 17:48:37 +0900	[thread overview]
Message-ID: <20170814084837.GF26913@bbox> (raw)
In-Reply-To: <20170811104615.GA14397@lst.de>

Hi Christoph,

On Fri, Aug 11, 2017 at 12:46:15PM +0200, Christoph Hellwig wrote:
> On Wed, Aug 09, 2017 at 08:06:24PM -0700, Dan Williams wrote:
> > I like it, but do you think we should switch to sbvec[<constant>] to
> > preclude pathological cases where nr_pages is large?
> 
> Yes, please.

Still, I don't understand how sbvec[nr_pages] with on-stack bio in
do_mpage_readpage can help the performance.

IIUC, do_mpage_readpage works with page-base. IOW, it passes just one
page, not multiple pages so if we use on-stack bio, we just add *a page*
via bio_add_page and submit the bio before the function returning.

So, rather than sbvec[1], why de we need sbvec[nr_pages]?

Please, let me open my eyes. :)

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	"karam . lee" <karam.lee@lge.com>,
	seungho1.park@lge.com, Dave Chinner <david@fromorbit.com>,
	Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	kernel-team <kernel-team@lge.com>
Subject: Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability
Date: Mon, 14 Aug 2017 17:48:37 +0900	[thread overview]
Message-ID: <20170814084837.GF26913@bbox> (raw)
In-Reply-To: <20170811104615.GA14397@lst.de>

Hi Christoph,

On Fri, Aug 11, 2017 at 12:46:15PM +0200, Christoph Hellwig wrote:
> On Wed, Aug 09, 2017 at 08:06:24PM -0700, Dan Williams wrote:
> > I like it, but do you think we should switch to sbvec[<constant>] to
> > preclude pathological cases where nr_pages is large?
> 
> Yes, please.

Still, I don't understand how sbvec[nr_pages] with on-stack bio in
do_mpage_readpage can help the performance.

IIUC, do_mpage_readpage works with page-base. IOW, it passes just one
page, not multiple pages so if we use on-stack bio, we just add *a page*
via bio_add_page and submit the bio before the function returning.

So, rather than sbvec[1], why de we need sbvec[nr_pages]?

Please, let me open my eyes. :)

Thanks.

  parent reply	other threads:[~2017-08-14  8:46 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08  6:50 [PATCH v1 0/6] Remove rw_page Minchan Kim
2017-08-08  6:50 ` Minchan Kim
2017-08-08  6:50 ` [PATCH v1 1/6] bdi: introduce BDI_CAP_SYNC Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50 ` [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08 12:49   ` Matthew Wilcox
2017-08-08 12:49     ` Matthew Wilcox
2017-08-08 13:29     ` Matthew Wilcox
2017-08-08 13:29       ` Matthew Wilcox
2017-08-09  1:51       ` Minchan Kim
2017-08-09  1:51         ` Minchan Kim
2017-08-09  1:51         ` Minchan Kim
2017-08-09  2:31         ` Matthew Wilcox
2017-08-09  2:31           ` Matthew Wilcox
2017-08-09  2:41           ` Minchan Kim
2017-08-09  2:41             ` Minchan Kim
2017-08-10  3:04             ` Matthew Wilcox
2017-08-10  3:04               ` Matthew Wilcox
2017-08-10  3:06               ` Dan Williams
2017-08-10  3:06                 ` Dan Williams
2017-08-11 10:46                 ` Christoph Hellwig
2017-08-11 10:46                   ` Christoph Hellwig
2017-08-11 10:46                   ` Christoph Hellwig
2017-08-11 14:26                   ` Jens Axboe
2017-08-11 14:26                     ` Jens Axboe
2017-08-14  8:50                     ` Minchan Kim
2017-08-14  8:50                       ` Minchan Kim
2017-08-14  8:50                       ` Minchan Kim
2017-08-14 14:36                       ` Jens Axboe
2017-08-14 14:36                         ` Jens Axboe
2017-08-14 15:06                         ` Minchan Kim
2017-08-14 15:06                           ` Minchan Kim
2017-08-14 15:06                           ` Minchan Kim
2017-08-14 15:14                           ` Jens Axboe
2017-08-14 15:14                             ` Jens Axboe
2017-08-14 15:14                             ` Jens Axboe
2017-08-14 15:31                             ` Minchan Kim
2017-08-14 15:31                               ` Minchan Kim
2017-08-14 15:31                               ` Minchan Kim
2017-08-14 15:38                               ` Jens Axboe
2017-08-14 15:38                                 ` Jens Axboe
2017-08-14 15:38                                 ` Jens Axboe
2017-08-14 16:17                                 ` Jens Axboe
2017-08-14 16:17                                   ` Jens Axboe
2017-08-14 16:17                                   ` Jens Axboe
2017-08-16  4:48                                   ` Minchan Kim
2017-08-16  4:48                                     ` Minchan Kim
2017-08-16  4:48                                     ` Minchan Kim
2017-08-16 15:56                                     ` Jens Axboe
2017-08-16 15:56                                       ` Jens Axboe
2017-08-16 15:56                                       ` Jens Axboe
2017-08-21  6:13                                       ` Minchan Kim
2017-08-21  6:13                                         ` Minchan Kim
2017-08-21  6:13                                         ` Minchan Kim
2017-08-14  8:48                   ` Minchan Kim [this message]
2017-08-14  8:48                     ` Minchan Kim
2017-08-14  8:48                     ` Minchan Kim
2017-08-10  4:00               ` Minchan Kim
2017-08-10  4:00                 ` Minchan Kim
2017-08-09  1:48     ` Minchan Kim
2017-08-09  1:48       ` Minchan Kim
2017-08-08  6:50 ` [PATCH v1 3/6] mm:swap: remove end_swap_bio_write argument Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50 ` [PATCH v1 4/6] mm:swap: use on-stack-bio for BDI_CAP_SYNC devices Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50 ` [PATCH v1 5/6] zram: remove zram_rw_page Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  7:02   ` Sergey Senozhatsky
2017-08-08  7:02     ` Sergey Senozhatsky
2017-08-08  8:13     ` Minchan Kim
2017-08-08  8:13       ` Minchan Kim
2017-08-08  8:13       ` Minchan Kim
2017-08-08  8:23       ` Sergey Senozhatsky
2017-08-08  8:23         ` Sergey Senozhatsky
2017-08-08  8:23         ` Sergey Senozhatsky
2017-08-08 15:48         ` Matthew Wilcox
2017-08-08 15:48           ` Matthew Wilcox
2017-08-08  6:50 ` [PATCH v1 6/6] fs: remove rw_page Minchan Kim
2017-08-08  6:50   ` Minchan Kim
2017-08-08  6:50   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814084837.GF26913@bbox \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=karam.lee@lge.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=seungho1.park@lge.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.