From: Christoph Hellwig <hch@infradead.org>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/2] xfs: always use DAX if mount option is used
Date: Fri, 8 Sep 2017 00:20:28 -0700 [thread overview]
Message-ID: <20170908072027.GA27725@infradead.org> (raw)
In-Reply-To: <20170907210832.17969-2-ross.zwisler@linux.intel.com>
On Thu, Sep 07, 2017 at 03:08:31PM -0600, Ross Zwisler wrote:
> Before support for the per-inode DAX flag was disabled the XFS the code had
> an issue where the user couldn't reliably tell whether or not DAX was being
> used to service page faults and I/O when the DAX mount option was used. In
> this case each inode within the mounted filesystem started with S_DAX set
> due to the mount option, but it could be cleared if someone touched the
> individual inode flag.
Looks good, but can you please add a testcase to xfstests for this?
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: always use DAX if mount option is used
Date: Fri, 8 Sep 2017 00:20:28 -0700 [thread overview]
Message-ID: <20170908072027.GA27725@infradead.org> (raw)
In-Reply-To: <20170907210832.17969-2-ross.zwisler@linux.intel.com>
On Thu, Sep 07, 2017 at 03:08:31PM -0600, Ross Zwisler wrote:
> Before support for the per-inode DAX flag was disabled the XFS the code had
> an issue where the user couldn't reliably tell whether or not DAX was being
> used to service page faults and I/O when the DAX mount option was used. In
> this case each inode within the mounted filesystem started with S_DAX set
> due to the mount option, but it could be cleared if someone touched the
> individual inode flag.
Looks good, but can you please add a testcase to xfstests for this?
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-09-08 7:17 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 21:08 [PATCH 0/2] xfs: some DAX fixes Ross Zwisler
2017-09-07 21:08 ` Ross Zwisler
2017-09-07 21:08 ` [PATCH 1/2] xfs: always use DAX if mount option is used Ross Zwisler
2017-09-07 21:08 ` Ross Zwisler
2017-09-08 7:20 ` Christoph Hellwig [this message]
2017-09-08 7:20 ` Christoph Hellwig
2017-09-08 15:28 ` Ross Zwisler
2017-09-08 15:28 ` Ross Zwisler
2017-09-08 21:21 ` [PATCH] xfs: add regression test for DAX mount option usage Ross Zwisler
2017-09-08 21:21 ` Ross Zwisler
2017-09-11 15:16 ` Ross Zwisler
2017-09-11 15:16 ` Ross Zwisler
2017-09-11 15:37 ` Dan Williams
2017-09-11 15:37 ` Dan Williams
2017-09-11 20:01 ` [fstests PATCH v2] " Ross Zwisler
2017-09-11 20:01 ` Ross Zwisler
2017-09-14 6:57 ` Eryu Guan
2017-09-14 6:57 ` Eryu Guan
2017-09-15 22:42 ` Ross Zwisler
2017-09-15 22:42 ` Ross Zwisler
2017-09-16 22:26 ` Dave Chinner
2017-09-16 22:26 ` Dave Chinner
2017-09-12 6:44 ` [PATCH] " Dave Chinner
2017-09-12 6:44 ` Dave Chinner
2017-09-12 15:38 ` Ross Zwisler
2017-09-12 15:38 ` Ross Zwisler
2017-09-12 23:47 ` Dave Chinner
2017-09-12 23:47 ` Dave Chinner
2017-09-13 14:42 ` Ross Zwisler
2017-09-13 14:42 ` Ross Zwisler
2017-09-13 22:01 ` Dave Chinner
2017-09-13 22:01 ` Dave Chinner
2017-09-13 22:23 ` Dan Williams
2017-09-13 22:23 ` Dan Williams
2017-09-13 23:34 ` Dave Chinner
2017-09-13 23:34 ` Dave Chinner
2017-09-14 0:28 ` Dan Williams
2017-09-14 0:28 ` Dan Williams
2017-09-14 0:40 ` Dave Chinner
2017-09-14 0:40 ` Dave Chinner
2017-09-14 1:24 ` Dan Williams
2017-09-14 1:24 ` Dan Williams
2017-09-14 12:19 ` Jeff Moyer
2017-09-14 12:19 ` Jeff Moyer
2017-09-14 13:16 ` Johannes Thumshirn
2017-09-14 13:16 ` Johannes Thumshirn
2017-09-14 14:10 ` Dan Williams
2017-09-14 14:10 ` Dan Williams
2017-09-15 9:18 ` Johannes Thumshirn
2017-09-15 9:18 ` Johannes Thumshirn
2017-09-15 17:39 ` Dan Williams
2017-09-15 17:39 ` Dan Williams
2017-09-18 7:47 ` Johannes Thumshirn
2017-09-18 7:47 ` Johannes Thumshirn
2017-09-07 21:08 ` [PATCH 2/2] xfs: validate bdev support for DAX inode flag Ross Zwisler
2017-09-07 21:08 ` Ross Zwisler
2017-09-08 7:21 ` Christoph Hellwig
2017-09-08 7:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908072027.GA27725@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.