From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: sagi@grimberg.me, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>,
"Javier González" <jg@lightnvm.io>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH 1/3] nvme: do not check for ns on rw path
Date: Mon, 6 Nov 2017 10:13:24 +0100 [thread overview]
Message-ID: <20171106091323.GA30382@lst.de> (raw)
In-Reply-To: <20171104153844.GA12777@localhost.localdomain>
On Sat, Nov 04, 2017 at 09:38:45AM -0600, Keith Busch wrote:
> That's not quite right. For non-PI metadata formats, we use the
> 'nop_profile', which gets the metadata buffer allocated so we can safely
> use a metadata formatted namespace. There's no in-kernel user of the
> allocated payload, but we still need the metadata buffer in order to
> use the namespace at all.
You're right. But that means we will indeed always have a matching
integrity payload here and the check should not be needed.
Are you fine with turning it into something like:
if (WARN_ON_ONCE(ns->ms && !blk_integrity_rq(req)))
return BLK_STS_IOERR;
?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvme: do not check for ns on rw path
Date: Mon, 6 Nov 2017 10:13:24 +0100 [thread overview]
Message-ID: <20171106091323.GA30382@lst.de> (raw)
In-Reply-To: <20171104153844.GA12777@localhost.localdomain>
On Sat, Nov 04, 2017@09:38:45AM -0600, Keith Busch wrote:
> That's not quite right. For non-PI metadata formats, we use the
> 'nop_profile', which gets the metadata buffer allocated so we can safely
> use a metadata formatted namespace. There's no in-kernel user of the
> allocated payload, but we still need the metadata buffer in order to
> use the namespace at all.
You're right. But that means we will indeed always have a matching
integrity payload here and the check should not be needed.
Are you fine with turning it into something like:
if (WARN_ON_ONCE(ns->ms && !blk_integrity_rq(req)))
return BLK_STS_IOERR;
?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Javier González" <jg@lightnvm.io>,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 1/3] nvme: do not check for ns on rw path
Date: Mon, 6 Nov 2017 10:13:24 +0100 [thread overview]
Message-ID: <20171106091323.GA30382@lst.de> (raw)
In-Reply-To: <20171104153844.GA12777@localhost.localdomain>
On Sat, Nov 04, 2017 at 09:38:45AM -0600, Keith Busch wrote:
> That's not quite right. For non-PI metadata formats, we use the
> 'nop_profile', which gets the metadata buffer allocated so we can safely
> use a metadata formatted namespace. There's no in-kernel user of the
> allocated payload, but we still need the metadata buffer in order to
> use the namespace at all.
You're right. But that means we will indeed always have a matching
integrity payload here and the check should not be needed.
Are you fine with turning it into something like:
if (WARN_ON_ONCE(ns->ms && !blk_integrity_rq(req)))
return BLK_STS_IOERR;
?
next prev parent reply other threads:[~2017-11-06 9:13 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 10:02 [PATCH 0/3] nvme: small fixes reported by smatch Javier González
2017-11-03 10:02 ` Javier González
2017-11-03 10:02 ` [PATCH 1/3] nvme: do not check for ns on rw path Javier González
2017-11-03 10:02 ` Javier González
2017-11-03 12:53 ` Christoph Hellwig
2017-11-03 12:53 ` Christoph Hellwig
2017-11-03 13:00 ` Javier González
2017-11-03 13:00 ` Javier González
2017-11-03 15:02 ` Keith Busch
2017-11-03 15:02 ` Keith Busch
2017-11-04 8:18 ` Christoph Hellwig
2017-11-04 8:18 ` Christoph Hellwig
2017-11-04 15:38 ` Keith Busch
2017-11-04 15:38 ` Keith Busch
2017-11-06 9:13 ` Christoph Hellwig [this message]
2017-11-06 9:13 ` Christoph Hellwig
2017-11-06 9:13 ` Christoph Hellwig
2017-11-06 14:43 ` Keith Busch
2017-11-06 14:43 ` Keith Busch
2017-11-03 10:02 ` [PATCH 2/3] nvme: compare NQN string with right size Javier González
2017-11-03 10:02 ` Javier González
2017-11-03 12:54 ` Christoph Hellwig
2017-11-03 12:54 ` Christoph Hellwig
2017-11-03 12:54 ` Christoph Hellwig
2017-11-03 12:56 ` Javier González
2017-11-03 12:56 ` Javier González
2017-11-03 10:02 ` [PATCH 3/3] nvme: fix eui_show() print format Javier González
2017-11-03 10:02 ` Javier González
2017-11-03 12:55 ` Christoph Hellwig
2017-11-03 12:55 ` Christoph Hellwig
2017-11-03 12:55 ` Christoph Hellwig
2017-11-03 15:13 ` Keith Busch
2017-11-03 15:13 ` Keith Busch
2017-11-03 15:13 ` Keith Busch
2017-11-03 15:16 ` Joe Perches
2017-11-03 15:16 ` Joe Perches
2017-11-03 15:16 ` Joe Perches
2017-11-04 11:22 ` Javier González
2017-11-04 11:22 ` Javier González
2017-11-07 16:28 ` Christoph Hellwig
2017-11-07 16:28 ` Christoph Hellwig
2017-11-07 16:28 ` Christoph Hellwig
2017-11-07 16:36 ` Javier González
2017-11-07 16:36 ` Javier González
2017-11-07 16:36 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106091323.GA30382@lst.de \
--to=hch@lst.de \
--cc=javier@cnexlabs.com \
--cc=jg@lightnvm.io \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.