All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Christoph Hellwig" <hch@lst.de>, "Javier González" <jg@lightnvm.io>
Cc: linux-block@vger.kernel.org, sagi@grimberg.me,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	keith.busch@intel.com, "Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 3/3] nvme: fix eui_show() print format
Date: Fri, 03 Nov 2017 08:16:37 -0700	[thread overview]
Message-ID: <1509722197.15520.17.camel@perches.com> (raw)
In-Reply-To: <20171103125516.GC25186@lst.de>

On Fri, 2017-11-03 at 13:55 +0100, Christoph Hellwig wrote:
> On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier Gonz=E1lez wrote:
> > Signed-off-by: Javier Gonz=E1lez <javier@cnexlabs.com>
[]
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
[]
> > @@ -2108,7 +2108,7 @@ static ssize_t eui_show(struct device *dev, struc=
t device_attribute *attr,
> >  								char *buf)
> >  {
> >  	struct nvme_ns *ns =3D nvme_get_ns_from_dev(dev);
> > -	return sprintf(buf, "%8phd\n", ns->eui);
> > +	return sprintf(buf, "%8phD\n", ns->eui);
> >  }
> >  static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL);
> =

> This looks correct.  I wonder what the old code printed - does someone
> have a device with an EUI-64 at hand to quickly cross check what we
> did before?

It uses spaces between bytes and not dashes.

The code has been this way a couple years now.

I think this proposal, while it might fix an
unintentional output style, could also be an API
and could cause user breakage if changed.

Perhaps this should just become

	%8ph

without D



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
Subject: [PATCH 3/3] nvme: fix eui_show() print format
Date: Fri, 03 Nov 2017 08:16:37 -0700	[thread overview]
Message-ID: <1509722197.15520.17.camel@perches.com> (raw)
In-Reply-To: <20171103125516.GC25186@lst.de>

On Fri, 2017-11-03@13:55 +0100, Christoph Hellwig wrote:
> On Fri, Nov 03, 2017@11:02:50AM +0100, Javier Gonz?lez wrote:
> > Signed-off-by: Javier Gonz?lez <javier at cnexlabs.com>
[]
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
[]
> > @@ -2108,7 +2108,7 @@ static ssize_t eui_show(struct device *dev, struct device_attribute *attr,
> >  								char *buf)
> >  {
> >  	struct nvme_ns *ns = nvme_get_ns_from_dev(dev);
> > -	return sprintf(buf, "%8phd\n", ns->eui);
> > +	return sprintf(buf, "%8phD\n", ns->eui);
> >  }
> >  static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL);
> 
> This looks correct.  I wonder what the old code printed - does someone
> have a device with an EUI-64 at hand to quickly cross check what we
> did before?

It uses spaces between bytes and not dashes.

The code has been this way a couple years now.

I think this proposal, while it might fix an
unintentional output style, could also be an API
and could cause user breakage if changed.

Perhaps this should just become

	%8ph

without D

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: "Christoph Hellwig" <hch@lst.de>, "Javier González" <jg@lightnvm.io>
Cc: sagi@grimberg.me, keith.busch@intel.com,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 3/3] nvme: fix eui_show() print format
Date: Fri, 03 Nov 2017 08:16:37 -0700	[thread overview]
Message-ID: <1509722197.15520.17.camel@perches.com> (raw)
In-Reply-To: <20171103125516.GC25186@lst.de>

On Fri, 2017-11-03 at 13:55 +0100, Christoph Hellwig wrote:
> On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote:
> > Signed-off-by: Javier González <javier@cnexlabs.com>
[]
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
[]
> > @@ -2108,7 +2108,7 @@ static ssize_t eui_show(struct device *dev, struct device_attribute *attr,
> >  								char *buf)
> >  {
> >  	struct nvme_ns *ns = nvme_get_ns_from_dev(dev);
> > -	return sprintf(buf, "%8phd\n", ns->eui);
> > +	return sprintf(buf, "%8phD\n", ns->eui);
> >  }
> >  static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL);
> 
> This looks correct.  I wonder what the old code printed - does someone
> have a device with an EUI-64 at hand to quickly cross check what we
> did before?

It uses spaces between bytes and not dashes.

The code has been this way a couple years now.

I think this proposal, while it might fix an
unintentional output style, could also be an API
and could cause user breakage if changed.

Perhaps this should just become

	%8ph

without D

  parent reply	other threads:[~2017-11-03 15:16 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 10:02 [PATCH 0/3] nvme: small fixes reported by smatch Javier González
2017-11-03 10:02 ` Javier González
2017-11-03 10:02 ` [PATCH 1/3] nvme: do not check for ns on rw path Javier González
2017-11-03 10:02   ` Javier González
2017-11-03 12:53   ` Christoph Hellwig
2017-11-03 12:53     ` Christoph Hellwig
2017-11-03 13:00     ` Javier González
2017-11-03 13:00       ` Javier González
2017-11-03 15:02     ` Keith Busch
2017-11-03 15:02       ` Keith Busch
2017-11-04  8:18       ` Christoph Hellwig
2017-11-04  8:18         ` Christoph Hellwig
2017-11-04 15:38         ` Keith Busch
2017-11-04 15:38           ` Keith Busch
2017-11-06  9:13           ` Christoph Hellwig
2017-11-06  9:13             ` Christoph Hellwig
2017-11-06  9:13             ` Christoph Hellwig
2017-11-06 14:43             ` Keith Busch
2017-11-06 14:43               ` Keith Busch
2017-11-03 10:02 ` [PATCH 2/3] nvme: compare NQN string with right size Javier González
2017-11-03 10:02   ` Javier González
2017-11-03 12:54   ` Christoph Hellwig
2017-11-03 12:54     ` Christoph Hellwig
2017-11-03 12:54     ` Christoph Hellwig
2017-11-03 12:56     ` Javier González
2017-11-03 12:56       ` Javier González
2017-11-03 10:02 ` [PATCH 3/3] nvme: fix eui_show() print format Javier González
2017-11-03 10:02   ` Javier González
2017-11-03 12:55   ` Christoph Hellwig
2017-11-03 12:55     ` Christoph Hellwig
2017-11-03 12:55     ` Christoph Hellwig
2017-11-03 15:13     ` Keith Busch
2017-11-03 15:13       ` Keith Busch
2017-11-03 15:13       ` Keith Busch
2017-11-03 15:16     ` Joe Perches [this message]
2017-11-03 15:16       ` Joe Perches
2017-11-03 15:16       ` Joe Perches
2017-11-04 11:22       ` Javier González
2017-11-04 11:22         ` Javier González
2017-11-07 16:28         ` Christoph Hellwig
2017-11-07 16:28           ` Christoph Hellwig
2017-11-07 16:28           ` Christoph Hellwig
2017-11-07 16:36           ` Javier González
2017-11-07 16:36             ` Javier González
2017-11-07 16:36             ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509722197.15520.17.camel@perches.com \
    --to=joe@perches.com \
    --cc=hch@lst.de \
    --cc=javier@cnexlabs.com \
    --cc=jg@lightnvm.io \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.