From: Ladislav Michl <ladis@linux-mips.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-omap@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>, Roger Quadros <rogerq@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()
Date: Mon, 15 Jan 2018 19:33:42 +0000 [thread overview]
Message-ID: <20180115193342.GA32536@lenoch> (raw)
In-Reply-To: <9266b6cb-6b9f-5b76-dab8-8ec36269928f@users.sourceforge.net>
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote:
> > dev_dbg(dev,
> > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
> > - ver, tll->nch);
> > + ver, nch);
> > break;
>
> Does this format string need an other indentation when you touch this statement?
Well, lets that the chance and make it shorter as well:
default:
- tll->nch = OMAP_TLL_CHANNEL_COUNT;
- dev_dbg(dev,
- "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
- ver, tll->nch);
+ nch = OMAP_TLL_CHANNEL_COUNT;
+ dev_dbg(dev, "rev 0x%x not recognized, assuming %d channels\n",
+ ver, nch);
break;
Other proposals?
WARNING: multiple messages have this Message-ID (diff)
From: Ladislav Michl <ladis@linux-mips.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-omap@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>, Roger Quadros <rogerq@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()
Date: Mon, 15 Jan 2018 20:33:42 +0100 [thread overview]
Message-ID: <20180115193342.GA32536@lenoch> (raw)
In-Reply-To: <9266b6cb-6b9f-5b76-dab8-8ec36269928f@users.sourceforge.net>
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote:
> > dev_dbg(dev,
> > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
> > - ver, tll->nch);
> > + ver, nch);
> > break;
>
> Does this format string need an other indentation when you touch this statement?
Well, lets that the chance and make it shorter as well:
default:
- tll->nch = OMAP_TLL_CHANNEL_COUNT;
- dev_dbg(dev,
- "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
- ver, tll->nch);
+ nch = OMAP_TLL_CHANNEL_COUNT;
+ dev_dbg(dev, "rev 0x%x not recognized, assuming %d channels\n",
+ ver, nch);
break;
Other proposals?
next prev parent reply other threads:[~2018-01-15 19:33 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 13:14 [PATCH 0/3] mfd/omap-usb-tll: Adjustments for usbtll_omap_probe() SF Markus Elfring
2018-01-15 13:14 ` SF Markus Elfring
2018-01-15 13:15 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_oma SF Markus Elfring
2018-01-15 13:15 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 13:41 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll Ladislav Michl
2018-01-15 13:41 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 15:34 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll Roger Quadros
2018-01-15 15:34 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Roger Quadros
2018-01-15 15:34 ` Roger Quadros
2018-01-15 15:38 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll SF Markus Elfring
2018-01-15 15:38 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 16:05 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll Ladislav Michl
2018-01-15 16:05 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 16:21 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ SF Markus Elfring
2018-01-15 16:21 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 16:35 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ Ladislav Michl
2018-01-15 16:35 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 17:06 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ SF Markus Elfring
2018-01-15 17:06 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 17:41 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ Ladislav Michl
2018-01-15 17:41 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 18:12 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ SF Markus Elfring
2018-01-15 18:12 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 18:30 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ Ladislav Michl
2018-01-15 18:30 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 19:04 ` mfd/omap-usb-tll: Allocate driver data at once " SF Markus Elfring
2018-01-15 19:04 ` SF Markus Elfring
2018-01-15 19:23 ` Ladislav Michl
2018-01-15 19:23 ` Ladislav Michl
2018-01-15 19:40 ` SF Markus Elfring
2018-01-15 19:40 ` SF Markus Elfring
2018-01-15 19:26 ` SF Markus Elfring
2018-01-15 19:26 ` SF Markus Elfring
2018-01-15 19:33 ` Ladislav Michl [this message]
2018-01-15 19:33 ` Ladislav Michl
2018-01-15 13:16 ` [PATCH 2/3] mfd/omap-usb-tll: Improve a size determination " SF Markus Elfring
2018-01-15 13:16 ` SF Markus Elfring
2018-01-22 15:50 ` Lee Jones
2018-01-22 15:50 ` Lee Jones
2018-01-15 13:17 ` [PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant " SF Markus Elfring
2018-01-15 13:17 ` SF Markus Elfring
2018-01-22 15:50 ` Lee Jones
2018-01-22 15:50 ` Lee Jones
2018-01-23 13:04 ` Lee Jones
2018-01-23 13:04 ` Lee Jones
2018-01-23 14:43 ` [3/3] " SF Markus Elfring
2018-01-23 14:43 ` SF Markus Elfring
2018-01-23 15:04 ` Lee Jones
2018-01-23 17:13 ` Ladislav Michl
2018-01-23 17:13 ` Ladislav Michl
2018-01-24 15:16 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115193342.GA32536@lenoch \
--to=ladis@linux-mips.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.