All of lore.kernel.org
 help / color / mirror / Atom feed
From: marcus.folkesson@gmail.com (Marcus Folkesson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 0/7] watchdog: make use of timeout-secs
Date: Fri,  9 Feb 2018 20:27:17 +0100	[thread overview]
Message-ID: <20180209192724.1227-1-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <marcus.folkesson@gmail.com>

All these drivers is using watchdog_init_timeout() to set timeout.
If the timeout-parameter is set to an valid value, it will allways pick
that and not even consider if timeout-secs is set in the devicetree.

Most of the patches will just remove the initial value for
timeout-parameter.

Some of the drivers allready has documented device-tree-bindings for
timeout-secs (but will not work), add property for those which not.

I wrote a similiar (tested) patch for imx2 and simply did the same to these drivers.
These patches is *NOT* tested, so please review extra carefully.


Taken from Documentation/watchdog/watchdog-kernel-api.txt:
	The watchdog_init_timeout function allows you to initialize the timeout field
	using the module timeout parameter or by retrieving the timeout-sec property from
	the device tree (if the module timeout parameter is invalid). Best practice is
	to set the default timeout value as timeout value in the watchdog_device and
	then use this function to set the user "preferred" timeout value.


Best regards
Marcus Folkesson

WARNING: multiple messages have this Message-ID (diff)
From: Marcus Folkesson <marcus.folkesson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Barry Song <baohua-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>,
	Sylvain Lemieux
	<slemieux.tyco-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Nicolas Ferre
	<nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 0/7] watchdog: make use of timeout-secs
Date: Fri,  9 Feb 2018 20:27:17 +0100	[thread overview]
Message-ID: <20180209192724.1227-1-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <marcus.folkesson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

All these drivers is using watchdog_init_timeout() to set timeout.
If the timeout-parameter is set to an valid value, it will allways pick
that and not even consider if timeout-secs is set in the devicetree.

Most of the patches will just remove the initial value for
timeout-parameter.

Some of the drivers allready has documented device-tree-bindings for
timeout-secs (but will not work), add property for those which not.

I wrote a similiar (tested) patch for imx2 and simply did the same to these drivers.
These patches is *NOT* tested, so please review extra carefully.


Taken from Documentation/watchdog/watchdog-kernel-api.txt:
	The watchdog_init_timeout function allows you to initialize the timeout field
	using the module timeout parameter or by retrieving the timeout-sec property from
	the device tree (if the module timeout parameter is invalid). Best practice is
	to set the default timeout value as timeout value in the watchdog_device and
	then use this function to set the user "preferred" timeout value.


Best regards
Marcus Folkesson

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Carlo Caione <carlo@caione.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Barry Song <baohua@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH 0/7] watchdog: make use of timeout-secs
Date: Fri,  9 Feb 2018 20:27:17 +0100	[thread overview]
Message-ID: <20180209192724.1227-1-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <marcus.folkesson@gmail.com>

All these drivers is using watchdog_init_timeout() to set timeout.
If the timeout-parameter is set to an valid value, it will allways pick
that and not even consider if timeout-secs is set in the devicetree.

Most of the patches will just remove the initial value for
timeout-parameter.

Some of the drivers allready has documented device-tree-bindings for
timeout-secs (but will not work), add property for those which not.

I wrote a similiar (tested) patch for imx2 and simply did the same to these drivers.
These patches is *NOT* tested, so please review extra carefully.


Taken from Documentation/watchdog/watchdog-kernel-api.txt:
	The watchdog_init_timeout function allows you to initialize the timeout field
	using the module timeout parameter or by retrieving the timeout-sec property from
	the device tree (if the module timeout parameter is invalid). Best practice is
	to set the default timeout value as timeout value in the watchdog_device and
	then use this function to set the user "preferred" timeout value.


Best regards
Marcus Folkesson

WARNING: multiple messages have this Message-ID (diff)
From: marcus.folkesson@gmail.com (Marcus Folkesson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] watchdog: make use of timeout-secs
Date: Fri,  9 Feb 2018 20:27:17 +0100	[thread overview]
Message-ID: <20180209192724.1227-1-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <marcus.folkesson@gmail.com>

All these drivers is using watchdog_init_timeout() to set timeout.
If the timeout-parameter is set to an valid value, it will allways pick
that and not even consider if timeout-secs is set in the devicetree.

Most of the patches will just remove the initial value for
timeout-parameter.

Some of the drivers allready has documented device-tree-bindings for
timeout-secs (but will not work), add property for those which not.

I wrote a similiar (tested) patch for imx2 and simply did the same to these drivers.
These patches is *NOT* tested, so please review extra carefully.


Taken from Documentation/watchdog/watchdog-kernel-api.txt:
	The watchdog_init_timeout function allows you to initialize the timeout field
	using the module timeout parameter or by retrieving the timeout-sec property from
	the device tree (if the module timeout parameter is invalid). Best practice is
	to set the default timeout value as timeout value in the watchdog_device and
	then use this function to set the user "preferred" timeout value.


Best regards
Marcus Folkesson

         reply	other threads:[~2018-02-09 19:27 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <marcus.folkesson@gmail.com>
2012-05-10 17:52 ` [PATCH] ARM: davinci: turn off DDR PHY when entering deep sleep Marcus Folkesson
2012-05-10 17:52   ` Marcus Folkesson
2012-05-21 17:38   ` Sekhar Nori
2012-05-21 17:38     ` Sekhar Nori
2012-05-24 11:46     ` Marcus Folkesson
2012-05-24 11:46       ` Marcus Folkesson
2012-05-24 17:41       ` Sekhar Nori
2012-05-24 17:41         ` Sekhar Nori
2018-02-09 19:27 ` Marcus Folkesson [this message]
2018-02-09 19:27   ` [PATCH 0/7] watchdog: make use of timeout-secs Marcus Folkesson
2018-02-09 19:27   ` Marcus Folkesson
2018-02-09 19:27   ` Marcus Folkesson
2018-02-09 19:27   ` [PATCH 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:32     ` Marcus Folkesson
2018-02-09 19:32       ` Marcus Folkesson
2018-02-09 19:32       ` Marcus Folkesson
2018-02-09 19:32       ` Marcus Folkesson
2018-02-09 22:38     ` Guenter Roeck
2018-02-09 22:38       ` Guenter Roeck
2018-02-09 22:38       ` Guenter Roeck
2018-02-09 22:38       ` Guenter Roeck
2018-02-11 17:38     ` [1/7] " Guenter Roeck
2018-02-11 17:38       ` Guenter Roeck
2018-02-11 17:38       ` Guenter Roeck
2018-02-11 17:38       ` Guenter Roeck
2018-02-09 19:27   ` [PATCH 2/7] watchdog: sunxi: allow setting timeout " Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 22:39     ` Guenter Roeck
2018-02-09 22:39       ` Guenter Roeck
2018-02-09 22:39       ` Guenter Roeck
2018-02-09 22:39       ` Guenter Roeck
2018-02-09 19:27   ` [PATCH 3/7] watchdog: sirfsoc: " Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 22:40     ` Guenter Roeck
2018-02-09 22:40       ` Guenter Roeck
2018-02-09 22:40       ` Guenter Roeck
2018-02-09 19:27   ` [PATCH 4/7] watchdog: pnx4008: make use of timeout-secs provided " Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 22:41     ` Guenter Roeck
2018-02-09 22:41       ` Guenter Roeck
2018-02-09 22:41       ` Guenter Roeck
2018-02-09 22:41       ` Guenter Roeck
2018-02-09 22:43     ` Guenter Roeck
2018-02-09 22:43       ` Guenter Roeck
2018-02-09 22:43       ` Guenter Roeck
2018-02-09 22:43       ` Guenter Roeck
2018-02-09 19:27   ` [PATCH 5/7] watchdog: mtk: allow setting timeout " Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 22:43     ` Guenter Roeck
2018-02-09 22:43       ` Guenter Roeck
2018-02-09 22:43       ` Guenter Roeck
2018-02-09 22:43       ` Guenter Roeck
2018-02-09 19:27   ` [PATCH 6/7] watchdog: meson: " Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 22:48     ` Guenter Roeck
2018-02-09 22:48       ` Guenter Roeck
2018-02-09 22:48       ` Guenter Roeck
2018-02-09 22:48       ` Guenter Roeck
2018-02-09 23:19       ` Alexandre Belloni
2018-02-09 23:19         ` Alexandre Belloni
2018-02-09 23:19         ` Alexandre Belloni
2018-02-10  0:04         ` Guenter Roeck
2018-02-10  0:04           ` Guenter Roeck
2018-02-10  0:04           ` Guenter Roeck
2018-02-10  0:04           ` Guenter Roeck
2018-02-09 19:27   ` [PATCH 7/7] watchdog: coh901327: make use of timeout-secs provided " Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 19:27     ` Marcus Folkesson
2018-02-09 22:52     ` Guenter Roeck
2018-02-09 22:52       ` Guenter Roeck
2018-02-09 22:52       ` Guenter Roeck
2018-02-09 22:52       ` Guenter Roeck
2018-02-10  8:54       ` Marcus Folkesson
2018-02-10  8:54         ` Marcus Folkesson
2018-02-10  8:54         ` Marcus Folkesson
2018-02-10  8:54         ` Marcus Folkesson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180209192724.1227-1-marcus.folkesson@gmail.com \
    --to=marcus.folkesson@gmail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.