* [PATCH] ALSA: pcm: potential uninitialized return values
@ 2018-03-27 13:07 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-03-27 13:07 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Takashi Sakamoto, kernel-janitors, linux-kernel
Smatch complains that "tmp" can be uninitialized if we do a zero size
write.
Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index a9082f219561..40852c595453 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -1364,7 +1364,7 @@ static ssize_t snd_pcm_oss_write2(struct snd_pcm_substream *substream, const cha
static ssize_t snd_pcm_oss_write1(struct snd_pcm_substream *substream, const char __user *buf, size_t bytes)
{
size_t xfer = 0;
- ssize_t tmp;
+ ssize_t tmp = 0;
struct snd_pcm_runtime *runtime = substream->runtime;
if (atomic_read(&substream->mmap_count))
@@ -1474,7 +1474,7 @@ static ssize_t snd_pcm_oss_read2(struct snd_pcm_substream *substream, char *buf,
static ssize_t snd_pcm_oss_read1(struct snd_pcm_substream *substream, char __user *buf, size_t bytes)
{
size_t xfer = 0;
- ssize_t tmp;
+ ssize_t tmp = 0;
struct snd_pcm_runtime *runtime = substream->runtime;
if (atomic_read(&substream->mmap_count))
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ALSA: pcm: potential uninitialized return values
@ 2018-03-27 13:07 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-03-27 13:07 UTC (permalink / raw)
To: Takashi Iwai
Cc: Jaroslav Kysela, Takashi Sakamoto, alsa-devel, linux-kernel,
kernel-janitors
Smatch complains that "tmp" can be uninitialized if we do a zero size
write.
Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index a9082f219561..40852c595453 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -1364,7 +1364,7 @@ static ssize_t snd_pcm_oss_write2(struct snd_pcm_substream *substream, const cha
static ssize_t snd_pcm_oss_write1(struct snd_pcm_substream *substream, const char __user *buf, size_t bytes)
{
size_t xfer = 0;
- ssize_t tmp;
+ ssize_t tmp = 0;
struct snd_pcm_runtime *runtime = substream->runtime;
if (atomic_read(&substream->mmap_count))
@@ -1474,7 +1474,7 @@ static ssize_t snd_pcm_oss_read2(struct snd_pcm_substream *substream, char *buf,
static ssize_t snd_pcm_oss_read1(struct snd_pcm_substream *substream, char __user *buf, size_t bytes)
{
size_t xfer = 0;
- ssize_t tmp;
+ ssize_t tmp = 0;
struct snd_pcm_runtime *runtime = substream->runtime;
if (atomic_read(&substream->mmap_count))
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ALSA: pcm: potential uninitialized return values
@ 2018-03-27 13:07 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-03-27 13:07 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Takashi Sakamoto, kernel-janitors, linux-kernel
Smatch complains that "tmp" can be uninitialized if we do a zero size
write.
Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index a9082f219561..40852c595453 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -1364,7 +1364,7 @@ static ssize_t snd_pcm_oss_write2(struct snd_pcm_substream *substream, const cha
static ssize_t snd_pcm_oss_write1(struct snd_pcm_substream *substream, const char __user *buf, size_t bytes)
{
size_t xfer = 0;
- ssize_t tmp;
+ ssize_t tmp = 0;
struct snd_pcm_runtime *runtime = substream->runtime;
if (atomic_read(&substream->mmap_count))
@@ -1474,7 +1474,7 @@ static ssize_t snd_pcm_oss_read2(struct snd_pcm_substream *substream, char *buf,
static ssize_t snd_pcm_oss_read1(struct snd_pcm_substream *substream, char __user *buf, size_t bytes)
{
size_t xfer = 0;
- ssize_t tmp;
+ ssize_t tmp = 0;
struct snd_pcm_runtime *runtime = substream->runtime;
if (atomic_read(&substream->mmap_count))
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: pcm: potential uninitialized return values
2018-03-27 13:07 ` Dan Carpenter
(?)
@ 2018-03-27 13:21 ` Takashi Iwai
-1 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2018-03-27 13:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Jaroslav Kysela, Takashi Sakamoto, kernel-janitors,
linux-kernel
On Tue, 27 Mar 2018 15:07:52 +0200,
Dan Carpenter wrote:
>
> Smatch complains that "tmp" can be uninitialized if we do a zero size
> write.
>
> Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, that's an oversight indeed. Applied now.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: pcm: potential uninitialized return values
@ 2018-03-27 13:21 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2018-03-27 13:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Jaroslav Kysela, Takashi Sakamoto, kernel-janitors,
linux-kernel
On Tue, 27 Mar 2018 15:07:52 +0200,
Dan Carpenter wrote:
>
> Smatch complains that "tmp" can be uninitialized if we do a zero size
> write.
>
> Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, that's an oversight indeed. Applied now.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: pcm: potential uninitialized return values
@ 2018-03-27 13:21 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2018-03-27 13:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Jaroslav Kysela, Takashi Sakamoto, kernel-janitors,
linux-kernel
On Tue, 27 Mar 2018 15:07:52 +0200,
Dan Carpenter wrote:
>
> Smatch complains that "tmp" can be uninitialized if we do a zero size
> write.
>
> Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, that's an oversight indeed. Applied now.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-27 13:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-27 13:07 [PATCH] ALSA: pcm: potential uninitialized return values Dan Carpenter
2018-03-27 13:07 ` Dan Carpenter
2018-03-27 13:07 ` Dan Carpenter
2018-03-27 13:21 ` Takashi Iwai
2018-03-27 13:21 ` Takashi Iwai
2018-03-27 13:21 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.