All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Lippers-Hollmann <s.l-h@gmx.de>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Sebastian Gottschall <s.gottschall@newmedia-net.de>,
	linux-wireless@vger.kernel.org,
	Sebastian Gottschall <s.gottschall@dd-wrt.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets
Date: Sun, 8 Apr 2018 10:21:21 +0200	[thread overview]
Message-ID: <20180408102121.63d010bd@mir> (raw)
In-Reply-To: <1523027875-5143-1-git-send-email-kvalo@codeaurora.org>

Hi

On 2018-04-06, Kalle Valo wrote:
> From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
> 
> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
> chipsets with on chipset connected led's using WMI Firmware API.  The LED
> device will get available named as "ath10k-phyX" at sysfs and can be controlled
> with various triggers.  adds also debugfs interface for gpio control.
> 
> Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
> [kvalo: major reorg and cleanup]
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>

[...]

I've been able to test v13 of this patch, including the changes regarding 
removing ath10k_leds_start() and moving the ath10k_wmi_gpio_config() call
into ath10k_leds_set_brightness_blocking() as raised by Sebastian 
Gottschall, on a ZyXEL NBG6817 (using two QCA9984 wlan cards and firmware 
10.4-3.5.3-00053) running OpenWrt/ master r6644-eda27d7557 (ipq8065, 
kernel 4.9.92 with backports wt-2017-11-01-0-gfe248fc2c180/ 
v4.14-rc2-1-31-g86cf0e5d).

/sys/class/leds/ath10k-phy0/ and /sys/class/leds/ath10k-phy1/ are
registered correctly and the white wlan LEDs connected to the ath10k 
GPIOs are now working as designed (controlled via phy0tpt/ phy1tpt).

Thanks a lot to everyone involved!

Regards
	Stefan Lippers-Hollmann

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Lippers-Hollmann <s.l-h@gmx.de>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Sebastian Gottschall <s.gottschall@newmedia-net.de>,
	Sebastian Gottschall <s.gottschall@dd-wrt.com>
Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets
Date: Sun, 8 Apr 2018 10:21:21 +0200	[thread overview]
Message-ID: <20180408102121.63d010bd@mir> (raw)
In-Reply-To: <1523027875-5143-1-git-send-email-kvalo@codeaurora.org>

Hi

On 2018-04-06, Kalle Valo wrote:
> From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
> 
> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
> chipsets with on chipset connected led's using WMI Firmware API.  The LED
> device will get available named as "ath10k-phyX" at sysfs and can be controlled
> with various triggers.  adds also debugfs interface for gpio control.
> 
> Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
> [kvalo: major reorg and cleanup]
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>

[...]

I've been able to test v13 of this patch, including the changes regarding 
removing ath10k_leds_start() and moving the ath10k_wmi_gpio_config() call
into ath10k_leds_set_brightness_blocking() as raised by Sebastian 
Gottschall, on a ZyXEL NBG6817 (using two QCA9984 wlan cards and firmware 
10.4-3.5.3-00053) running OpenWrt/ master r6644-eda27d7557 (ipq8065, 
kernel 4.9.92 with backports wt-2017-11-01-0-gfe248fc2c180/ 
v4.14-rc2-1-31-g86cf0e5d).

/sys/class/leds/ath10k-phy0/ and /sys/class/leds/ath10k-phy1/ are
registered correctly and the white wlan LEDs connected to the ath10k 
GPIOs are now working as designed (controlled via phy0tpt/ phy1tpt).

Thanks a lot to everyone involved!

Regards
	Stefan Lippers-Hollmann

  parent reply	other threads:[~2018-04-08  8:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 15:17 [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets Kalle Valo
2018-04-06 15:17 ` Kalle Valo
2018-04-06 15:22 ` Kalle Valo
2018-04-06 15:22   ` Kalle Valo
2018-04-06 18:31 ` Sebastian Gottschall
2018-04-06 18:31   ` Sebastian Gottschall
2018-04-09 15:49   ` Kalle Valo
2018-04-09 15:49     ` Kalle Valo
2018-04-10 10:33     ` Sebastian Gottschall
2018-04-10 10:33       ` Sebastian Gottschall
2018-04-08  8:21 ` Stefan Lippers-Hollmann [this message]
2018-04-08  8:21   ` Stefan Lippers-Hollmann
2019-02-26  9:16 ` Sven Eckelmann
2019-02-26  9:16   ` Sven Eckelmann
2020-05-20  7:39   ` Sebastian Gottschall
2020-05-20  7:39     ` Sebastian Gottschall
2020-05-20 10:40     ` [OpenWrt-Devel] " Vincent Wiemann
2020-05-20 10:40       ` Vincent Wiemann
2020-05-20 13:00       ` Sebastian Gottschall
2020-05-20 13:00         ` Sebastian Gottschall
2020-05-20 19:05         ` Vincent Wiemann
2020-05-20 19:05           ` Vincent Wiemann
2020-05-22 10:29     ` Kalle Valo
2020-05-22 10:29       ` Kalle Valo
2020-05-22 14:26       ` Sebastian Gottschall
2020-05-22 14:26         ` Sebastian Gottschall
2020-05-25  9:22     ` Sven Eckelmann
2020-05-25  9:22       ` Sven Eckelmann
2020-05-25  9:27       ` Sebastian Gottschall
2020-05-25  9:27         ` Sebastian Gottschall
2020-05-25 16:04       ` Sven Eckelmann
2020-05-25 16:04         ` Sven Eckelmann
2020-05-29 15:34         ` Kalle Valo
2020-05-29 15:34           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180408102121.63d010bd@mir \
    --to=s.l-h@gmx.de \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=s.gottschall@dd-wrt.com \
    --cc=s.gottschall@newmedia-net.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.