From: Kalle Valo <kvalo@codeaurora.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Sebastian Gottschall <s.gottschall@dd-wrt.com>,
John Crispin <john@phrozen.org>,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
openwrt-devel@lists.openwrt.org,
Ansuel Smith <ansuelsmth@gmail.com>
Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets
Date: Fri, 29 May 2020 18:34:07 +0300 [thread overview]
Message-ID: <87k10usqkw.fsf@codeaurora.org> (raw)
In-Reply-To: <3445075.COMLMNsY4U@bentobox> (Sven Eckelmann's message of "Mon, 25 May 2020 18:04:49 +0200")
Sven Eckelmann <sven@narfation.org> writes:
> On Monday, 25 May 2020 11:22:13 CEST Sven Eckelmann wrote:
> [...]
>> And it still can with this OpenWrt version. But it doesn't seem to happen with
>> the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000
>> commits inbetween. So no idea what changed (just a timing thing or an actual
>> fix - no idea).
>
> Seems like there is a fix which solves some lost interrupt problems for
> IPQ40xx. Without this change, I see the reported problem. And with the patch,
> it is gone. Or in commits:
>
> * creates timeout problems: 46b949a067e5 ("ipq40xx: enlarge PCIe BAR size")
> * works fine: 18e942b6c4e5 ("ipq40xx: fix pcie msi IRQ trigger level")
>
> If you look in the git logs [1], you can see that the working commit is a
> child of the broken one. So at least from my point of view, my initial report
> is no blocker anymore for Sebastian's patch (or Kalle's version of it).
Great. If the patch is good to take can someone rebase the latest
version and resubmit, please?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
John Crispin <john@phrozen.org>,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
openwrt-devel@lists.openwrt.org,
Ansuel Smith <ansuelsmth@gmail.com>
Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets
Date: Fri, 29 May 2020 18:34:07 +0300 [thread overview]
Message-ID: <87k10usqkw.fsf@codeaurora.org> (raw)
In-Reply-To: <3445075.COMLMNsY4U@bentobox> (Sven Eckelmann's message of "Mon, 25 May 2020 18:04:49 +0200")
Sven Eckelmann <sven@narfation.org> writes:
> On Monday, 25 May 2020 11:22:13 CEST Sven Eckelmann wrote:
> [...]
>> And it still can with this OpenWrt version. But it doesn't seem to happen with
>> the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000
>> commits inbetween. So no idea what changed (just a timing thing or an actual
>> fix - no idea).
>
> Seems like there is a fix which solves some lost interrupt problems for
> IPQ40xx. Without this change, I see the reported problem. And with the patch,
> it is gone. Or in commits:
>
> * creates timeout problems: 46b949a067e5 ("ipq40xx: enlarge PCIe BAR size")
> * works fine: 18e942b6c4e5 ("ipq40xx: fix pcie msi IRQ trigger level")
>
> If you look in the git logs [1], you can see that the working commit is a
> child of the broken one. So at least from my point of view, my initial report
> is no blocker anymore for Sebastian's patch (or Kalle's version of it).
Great. If the patch is good to take can someone rebase the latest
version and resubmit, please?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-29 15:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 15:17 [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets Kalle Valo
2018-04-06 15:17 ` Kalle Valo
2018-04-06 15:22 ` Kalle Valo
2018-04-06 15:22 ` Kalle Valo
2018-04-06 18:31 ` Sebastian Gottschall
2018-04-06 18:31 ` Sebastian Gottschall
2018-04-09 15:49 ` Kalle Valo
2018-04-09 15:49 ` Kalle Valo
2018-04-10 10:33 ` Sebastian Gottschall
2018-04-10 10:33 ` Sebastian Gottschall
2018-04-08 8:21 ` Stefan Lippers-Hollmann
2018-04-08 8:21 ` Stefan Lippers-Hollmann
2019-02-26 9:16 ` Sven Eckelmann
2019-02-26 9:16 ` Sven Eckelmann
2020-05-20 7:39 ` Sebastian Gottschall
2020-05-20 7:39 ` Sebastian Gottschall
2020-05-20 10:40 ` [OpenWrt-Devel] " Vincent Wiemann
2020-05-20 10:40 ` Vincent Wiemann
2020-05-20 13:00 ` Sebastian Gottschall
2020-05-20 13:00 ` Sebastian Gottschall
2020-05-20 19:05 ` Vincent Wiemann
2020-05-20 19:05 ` Vincent Wiemann
2020-05-22 10:29 ` Kalle Valo
2020-05-22 10:29 ` Kalle Valo
2020-05-22 14:26 ` Sebastian Gottschall
2020-05-22 14:26 ` Sebastian Gottschall
2020-05-25 9:22 ` Sven Eckelmann
2020-05-25 9:22 ` Sven Eckelmann
2020-05-25 9:27 ` Sebastian Gottschall
2020-05-25 9:27 ` Sebastian Gottschall
2020-05-25 16:04 ` Sven Eckelmann
2020-05-25 16:04 ` Sven Eckelmann
2020-05-29 15:34 ` Kalle Valo [this message]
2020-05-29 15:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k10usqkw.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=s.gottschall@dd-wrt.com \
--cc=s.gottschall@newmedia-net.de \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.